diff options
| author | Natanael Copa <ncopa@alpinelinux.org> | 2013-07-10 07:07:47 +0000 |
|---|---|---|
| committer | Natanael Copa <ncopa@alpinelinux.org> | 2013-07-10 07:14:46 +0000 |
| commit | e1d629b6c439b35c8f7f4a62a9b65ac4d3f6fd81 (patch) | |
| tree | 87431cb2dd281373bf0b420878ced2ac329e960d /Makefile | |
| parent | 5021e13ffa222ac7344285aa90ec183064a5819b (diff) | |
| download | abuild-e1d629b6c439b35c8f7f4a62a9b65ac4d3f6fd81.tar.bz2 abuild-e1d629b6c439b35c8f7f4a62a9b65ac4d3f6fd81.tar.xz | |
abump: fix set -e issue
It appears that when the subshell has a ||, the 'set -e' within
subshell gets invalidated.
This will work as expected:
( set -e; false; echo "should not get here" )
While this will not work as expected:
( set -e; false; echo "should not get here" ) || false
We resolve it by using $? to detect the status of subshell. We also let
the exitcode indicate how many packages that failed.
While here we also refactor it so most of the loop happens within the
subshell. This lets us set (or increase) rc variable once, and it
reduces number of forks which gives slightly better performance.
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions