From 09dbe46a7608f56f07914137834e7ddda15c4837 Mon Sep 17 00:00:00 2001 From: Alexander Wauck Date: Tue, 24 Mar 2020 14:51:15 -0500 Subject: libfetch: minor HTTP handling improvement The recent TCP_CORK change missed this bit of code. This change should improve performance a bit when making HTTP requests by calling http_cmd only once instead of three times. --- libfetch/http.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libfetch/http.c b/libfetch/http.c index 08b2361..418968a 100644 --- a/libfetch/http.c +++ b/libfetch/http.c @@ -711,11 +711,8 @@ http_connect(struct url *URL, struct url *purl, const char *flags, int *cached) /* fetch_connect() has already set an error code */ return (NULL); if (strcasecmp(URL->scheme, SCHEME_HTTPS) == 0 && purl) { - http_cmd(conn, "CONNECT %s:%d HTTP/1.1\r\n", - URL->host, URL->port); - http_cmd(conn, "Host: %s:%d\r\n", - URL->host, URL->port); - http_cmd(conn, "\r\n"); + http_cmd(conn, "CONNECT %s:%d HTTP/1.1\r\nHost: %s:%d\r\n\r\n", + URL->host, URL->port, URL->host, URL->port); if (http_get_reply(conn) != HTTP_OK) { http_seterr(conn->err); goto ouch; -- cgit v1.2.3