solver, upgrade: properly detect missing repository tags

 * upgrade needs explicit check so we don't try self-upgrade
   (which would print additional messages on screen)
 * add can fix problems, so check against the new world
 * merge the code in few places

1 files changed, 0 insertions, 7 deletions

diff --git a/src/add.c b/src/add.c
index 34ed9a3988..238a388d73 100644
--- a/src/add.c
+++ b/src/add.c
@@ -107,7 +107,6 @@ static int add_main(void *ctx, struct apk_database *db, int argc, char **argv)
 			}
 			apk_dep_from_pkg(&dep, db, pkg);
 		} else {
-			struct apk_repository_tag *tag;
 			apk_blob_t b = APK_BLOB_STR(argv[i]);
 
 			apk_blob_pull_dep(&b, db, &dep);
@@ -116,12 +115,6 @@ static int add_main(void *ctx, struct apk_database *db, int argc, char **argv)
 					  argv[i]);
 				return -1;
 			}
-			tag = &db->repo_tags[dep.repository_tag];
-			if (!tag->allowed_repos) {
-				apk_error("Repository tag '" BLOB_FMT "' is not defined",
-					  BLOB_PRINTF(*tag->name));
-				return -1;
-			}
 		}
 
 		if (virtpkg == NULL) {