diff options
Diffstat (limited to 'main/libvirt/fix-migration-without-params.patch')
| -rw-r--r-- | main/libvirt/fix-migration-without-params.patch | 36 |
1 files changed, 36 insertions, 0 deletions
diff --git a/main/libvirt/fix-migration-without-params.patch b/main/libvirt/fix-migration-without-params.patch new file mode 100644 index 0000000000..f3615bad7c --- /dev/null +++ b/main/libvirt/fix-migration-without-params.patch @@ -0,0 +1,36 @@ +From d802d9ab83ad0d852310c79998ee11c0a440b615 Mon Sep 17 00:00:00 2001 +From: Jiri Denemark <jdenemar@redhat.com> +Date: Wed, 27 Nov 2019 17:21:58 +0100 +Subject: [PATCH] qemu: Fix migration without parameters + +The virTypedParamsFilter function doesn't mind params == NULL if nparams +is zero. And there's no need to check for params == NULL && nparams > 0 +because this is checked higher in the stack. + +In fact all the virCheckNonNull* checks in virTypedParamsFilter are +useless. + +https://bugzilla.redhat.com/show_bug.cgi?id=1777094 + +Signed-off-by: Jiri Denemark <jdenemar@redhat.com> +Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com> +Reviewed-by: Erik Skultety <eskultet@redhat.com> +--- + src/util/virtypedparam.c | 4 ---- + 1 file changed, 4 deletions(-) + +diff --git a/src/util/virtypedparam.c b/src/util/virtypedparam.c +index 603fcf213a..be3dac1571 100644 +--- a/src/util/virtypedparam.c ++++ b/src/util/virtypedparam.c +@@ -403,10 +403,6 @@ virTypedParamsFilter(virTypedParameterPtr params, + { + size_t i, n = 0; + +- virCheckNonNullArgGoto(params, error); +- virCheckNonNullArgGoto(name, error); +- virCheckNonNullArgGoto(ret, error); +- + if (VIR_ALLOC_N(*ret, nparams) < 0) + goto error; + |