From 2881266313824ed1c2d422ea905e25509f9bc924 Mon Sep 17 00:00:00 2001 From: Marian Buschsieweke Date: Wed, 2 Aug 2017 23:36:08 +0200 Subject: [PATCH 14/16] miscutils/microcom: Fixed segfault microcom did not check if required parameter TTY is present. Thus, bb_basename() was called with a NULL pointer if TTY was missing. This commit adds the missing check. --- miscutils/microcom.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/miscutils/microcom.c b/miscutils/microcom.c index fa090057e..96ea02b16 100644 --- a/miscutils/microcom.c +++ b/miscutils/microcom.c @@ -76,6 +76,11 @@ int microcom_main(int argc UNUSED_PARAM, char **argv) // argc -= optind; argv += optind; + if (*argv == NULL){ + bb_show_usage(); + return EXIT_FAILURE; + } + // try to create lock file in /var/lock device_lock_file = (char *)bb_basename(argv[0]); device_lock_file = xasprintf("/var/lock/LCK..%s", device_lock_file); -- 2.16.2