From a5585f5922afe5d6a9207f98bfd9c054432b2a0a Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Wed, 9 Jan 2013 22:17:09 +0100 Subject: [PATCH] Initialize refLine totally Fixes uninitialized memory read in 1004.pdf.asan.7.3 (cherry picked from commit b1026b5978c385328f2a15a2185c599a563edf91) --- poppler/Stream.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/poppler/Stream.cc b/poppler/Stream.cc index 3e6c908..9e37d53 100644 --- a/poppler/Stream.cc +++ b/poppler/Stream.cc @@ -14,7 +14,7 @@ // under GPL version 2 or later // // Copyright (C) 2005 Jeff Muizelaar -// Copyright (C) 2006-2010, 2012 Albert Astals Cid +// Copyright (C) 2006-2010, 2012, 2013 Albert Astals Cid // Copyright (C) 2007 Krzysztof Kowalczyk // Copyright (C) 2008 Julien Rebetez // Copyright (C) 2009 Carlos Garcia Campos @@ -1710,8 +1710,9 @@ int CCITTFaxStream::lookChar() { for (i = 0; codingLine[i] < columns; ++i) { refLine[i] = codingLine[i]; } - refLine[i++] = columns; - refLine[i] = columns; + for (; i < columns + 2; ++i) { + refLine[i] = columns; + } codingLine[0] = 0; a0i = 0; b1i = 0; -- 1.8.0