From 97456fa7bb23c22e2a06ca4a99e62e75529f8a91 Mon Sep 17 00:00:00 2001 From: Natanael Copa Date: Wed, 14 Mar 2012 09:16:03 +0100 Subject: pingu_route: add helper function for generating route string Use for logging. --- pingu_netlink.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) (limited to 'pingu_netlink.c') diff --git a/pingu_netlink.c b/pingu_netlink.c index 0c0ff0e..1dec0c0 100644 --- a/pingu_netlink.c +++ b/pingu_netlink.c @@ -643,21 +643,14 @@ static struct pingu_route *gw_from_rtmsg(struct pingu_route *gw, static void log_route_change(struct pingu_route *route, int table, int action) { - char deststr[64] = "", gwstr[64] = "", viastr[68] = ""; - char ifname[IF_NAMESIZE] = ""; - char devstr[IF_NAMESIZE + 5] = ""; + char routestr[512] = ""; char *actionstr = "New"; if (action == RTM_DELROUTE) actionstr = "Delete"; - if (if_indextoname(route->dev_index, ifname) != NULL) - snprintf(devstr, sizeof(devstr), "dev %s ", ifname); - sockaddr_to_string(&route->dest, deststr, sizeof(deststr)); - sockaddr_to_string(&route->gw_addr, gwstr, sizeof(gwstr)); - if (gwstr[0] != '\0') - snprintf(viastr, sizeof(viastr), "via %s ", gwstr); - log_info("%s route to %s/%i %s%stable %i", actionstr, - deststr, route->dst_len, viastr, devstr, table); + log_info("%s route to %s table %i", actionstr, + pingu_route_to_string(route, routestr, sizeof(routestr)), + table); } void route_changed_for_iface(struct pingu_iface *iface, -- cgit v1.2.3