From 618bdff5f21b7b90c40fba93bafa88ceb3e522dc Mon Sep 17 00:00:00 2001 From: Alex Dowad Date: Thu, 1 May 2014 13:45:32 +0200 Subject: squark-filter, squark-auth-ip: avoid overflow of login_name buffer --- src/squark-auth-ip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/squark-auth-ip.c') diff --git a/src/squark-auth-ip.c b/src/squark-auth-ip.c index 94c450f..74e0583 100644 --- a/src/squark-auth-ip.c +++ b/src/squark-auth-ip.c @@ -60,7 +60,7 @@ static void handle_line(blob_t line) blob_push(&b, id); if (auth_ok) { blob_push(&b, BLOB_STR(" OK user=")); - blob_push(&b, BLOB_STRLEN(entry.p.login_name)); + blob_push(&b, BLOB_CHAR_ARRAY(entry.p.login_name)); blob_push(&b, BLOB_PTR_LEN("\n", 1)); } else { blob_push(&b, BLOB_STR(" ERR\n")); @@ -210,6 +210,8 @@ int main(int argc, char **argv) return 2; } authdb_clear_entry(&entry); + if (username.len > sizeof(entry.p.login_name)) + username.len = sizeof(entry.p.login_name); /* avoid buffer overflow */ memcpy(entry.p.login_name, username.ptr, username.len); authdb_commit_login(token, &entry, now, &adbc); break; -- cgit v1.2.3