clandmeter/patchwork, branch master

patchwork/templates: Suppress cycle template tag warning

2015-06-05T06:53:07+00:00

Running on django 1.7 gives a warning:

RemovedInDjango18Warning: 'The `cycle` template tag is changing to escape its arguments; the non-autoescaping version is deprecated. Load it from the `future` tag library to start using the new behavior.

Although this change doesn't affect this template, suppress the warning
by loading from the future library.

Signed-off-by: Jeremy Kerr

patchwork/views: request.REQUEST is deprecated in django 1.8

2015-06-05T06:48:31+00:00

.. so do explicit accesses to request.GET or request.POST.

Signed-off-by: Jeremy Kerr

patchwork/parser: Adapt for new unsaved-foreign-key behaviour in django 1.8

2015-06-05T06:37:48+00:00

Django 1.8 no longer supports assignment of unsaved models to
ForeignKey fields:

  File "/home/jk/devel/patchwork/patchwork/tests/test_patchparser.py", line 75, in setUp
    (self.patch, self.comment) = find_content(self.project, email)
  File "/home/jk/devel/patchwork/patchwork/bin/parsemail.py", line 231, in find_content
    headers = mail_headers(mail))
  File "/home/jk/devel/patchwork/lib/python/django/db/models/base.py", line 468, in __init__
    setattr(self, field.name, rel_obj)
  File "/home/jk/devel/patchwork/lib/python/django/db/models/fields/related.py", line 668, in __set__
    (value, self.field.rel.to._meta.object_name)
ValueError: Cannot assign "": "Patch" instance isn't saved in the database.

Even though we'd be guaranteed to save the patch before the comment, we
need to avoid this error.

This change defers the assigment of Comment.patch until we know we have
a saved Patch instance.

Signed-off-by: Jeremy Kerr

patchwork: Add initial migrations

2015-06-05T06:37:09+00:00

Add migrations for the patchwork app; these will be required for
django-1.9, and are required to express the test dependencies (to the
auth models) on 1.8.

Signed-off-by: Jeremy Kerr

patchwork: Explicitly load states fixtures

2015-06-05T06:37:09+00:00

Apps with migrations will no longer load the initial_data fixtures by
default. In order to prepare to add migrations to patchwork, rename the
initial_data fixture to default_states (to match the default_tags
fixture), and explicitly load them in tests that require them.

Also, include this step in the INSTALL document.

Signed-off-by: Jeremy Kerr

patchwork/views: prefetch delegate in generic_list

2015-06-05T06:37:05+00:00

If patches have a delegate, the patch list template will cause a query
to render the delegate username. Instead, we should include the delegate
in the select_related query.

Signed-off-by: Jeremy Kerr

patchwork/models: Use OneToOneField for PatchChangeNotifcation.patch

2015-06-04T09:49:01+00:00

Same functionality, but we suppress an error from django 1.8+

Signed-off-by: Jeremy Kerr

parsemail: Don't catch all exceptions when a Project isn't found

2015-05-29T00:08:32+00:00

This is the first query that parsemail will do, and we don't want to
lose any non-missing-project-related errors.

Signed-off-by: Jeremy Kerr

parsemail: run django.setup to initialise Models

2015-05-29T00:08:31+00:00

From 1.7 onwards, we need to call django.setup() before we can use the
Model interfaces.

Signed-off-by: Jeremy Kerr

tests: Remove old-style test runner module

2015-05-28T05:59:36+00:00

We get the following warning on django 1.7:

System check identified some issues:

WARNINGS:
?: (1_6.W001) Some project unittests may not execute as expected.
	HINT: Django 1.6 introduced a new default test runner. It looks like this project was generated using Django 1.5 or earlier. You should ensure your tests are all running & behaving as expected. See https://docs.djangoproject.com/en/dev/releases/1.6/#new-test-runner for more information.

This change removes the unneeded base test module, and moves the
patchparser doctests into a proper test module.

Signed-off-by: Jeremy Kerr