clandmeter/patchwork/apps, branch master

Move to a more recent django project structure

2015-05-27T02:26:41+00:00

This change updates patchwor to the newer project struture: we've moved
the actual application out of the apps/ directory, and the
patchwork-specific templates to under the patchwork application.

This gives us the manage.py script in the top-level now.

Signed-off-by: Jeremy Kerr

settings: Split 'settings.py' into multiple files

2015-05-03T05:46:52+00:00

This will make testing/developing a little easier and prevent people
deploying insecure instances.

This also adds references to Django documentation in said files (for
Django novices) and restructures the files to group them together
logically.

This allows us to remove the settings file used for tests.

Signed-off-by: Stephen Finucane 
Signed-off-by: Jeremy Kerr

Integrate 'django.contrib.staticfiles'

2015-05-03T05:46:52+00:00

Rather than providing a custom solution for serving static files, use
the solution provided in the upstream Django source.

This allows us to remove the top-level 'urls.py' file.

Signed-off-by: Stephen Finucane 
Signed-off-by: Jeremy Kerr

settings: Restructure settings file

2015-05-03T05:46:52+00:00

Restructure to add some order to the settings file. This includes
removing some variables:

- TEMPLATE_CONTEXT_PROCESSORS
- TEMPLATE_LOADERS

These variables have the exact same value as the Django defaults and
thus do not need to be specified.

Signed-off-by: Stephen Finucane 
Signed-off-by: Jeremy Kerr

settings: Resolve all but one Django 1.7 warning

2015-05-03T05:46:52+00:00

Resolve remaining Django 1.7 warnings with the exception of a single
deprecation warning. However, this remaining issue is really a
non-issue due to the limited (and non-offending) use of the code.

Signed-off-by: Stephen Finucane 
Signed-off-by: Jeremy Kerr

views: Replace 'mimetype' with 'content_type'

2015-05-03T05:46:52+00:00

Passing 'mimetype' to 'HttpResponse' is deprecated in 1.6 and
removed in Django 1.7. Among other things, this causes some unit
tests to fail when using Django 1.7. Its replacement - 'content_type'
- is available in Django 1.5+. This can be seen here:

    https://docs.djangoproject.com/en/1.5/ref/request-response/#django.http.HttpResponse.__init__

This is therefore a like-for-like replacement.

Signed-off-by: Stephen Finucane 
Signed-off-by: Jeremy Kerr

Resolve removed 'AUTH_PROFILE_MODULE' setting

2015-05-03T05:46:52+00:00

The 'AUTH_PROFILE_MODULE' setting, and the 'get_profile()' method on
the 'User' model are removed in Django 1.7. This causes errors when
using Patchwork with Django 1.7+.

There are three changes necessary:

 * Replace profile model's 'ForeignKey' with a 'OneToOneField'
 * Remove all 'get_profile()' calls
 * Delete 'AUTH_PROFILE_MODULE' settings from 'settings.py'

These changes are discussed here:

    http://deathofagremmie.com/2014/05/24/retiring-get-profile-and-auth-profile-module/

Django 1.6 also introduces two other notable changes:

 * The 'XViewMiddleware' module has been moved
 * A new test runner has been introduced

It is not possible to fix these issues without breaking compatibility
with Django 1.5. As a result they have been ignored and must be
resolved in a future release.

Signed-off-by: Stephen Finucane 
Signed-off-by: Jeremy Kerr

Make the submitter name link to a query for that submitter

2015-05-03T05:43:42+00:00

Currently the submitter name is rendered as a mailto: link. This is
possibly useful in some circumstances, but in my experience is not
usually what I want. Although it opens a mail to the submitter, it
doesn't include any of the patch context, so is not very helpful.

Instead the submitter link can be a link to a query for patches by that
submitter. In my experience that is more useful, ie. when looking at a
single patch for a submitter you can then quickly get the list of all
patches by them.

So do that conversion.

In order to do it we need to know the current project, so that becomes a
parameter to personify. I believe the url reversal is correct, though
it's not pretty, and pulling SubmitterFilter.param out feels a little
wrong, but is the best solution I could come up with.

Signed-off-by: Michael Ellerman 
Signed-off-by: Jeremy Kerr

pwclient: honor PAGER for view

2015-05-03T05:40:02+00:00

Use the PAGER of the environment to view patches

Signed-off-by: Bernhard Reutner-Fischer 
Signed-off-by: Jeremy Kerr

parser: Fix parsing of patches with a trailing no-newline marker

2015-03-22T13:27:09+00:00

If a patch ends with a "No newline at end of file" marker, it is
incorrectly considered part of the comment.

Add a testcase which shows the bug, and then fix the parser. The parser
fix is hopefully sufficiently specific so as to not break any other
unrelated case. But ..

Signed-off-by: Michael Ellerman