summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGuilherme Salgado <guilherme.salgado@linaro.org>2011-02-28 02:40:44 +0000
committerJeremy Kerr <jk@ozlabs.org>2011-03-30 14:42:26 +0800
commitf23f76b8756a12614097fec500d3ca3e6aa3227b (patch)
treefe3b6b7ce0e53a7ed7a3a4d0a8b8b08255977aaa
parenta7bbbeba8f1dd2e859767c4873f584ea87afd77d (diff)
downloadpatchwork-f23f76b8756a12614097fec500d3ca3e6aa3227b.tar.bz2
patchwork-f23f76b8756a12614097fec500d3ca3e6aa3227b.tar.xz
Remove a bunch of unused variables
Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
-rw-r--r--apps/patchwork/models.py6
-rw-r--r--apps/patchwork/views/bundle.py2
-rw-r--r--apps/patchwork/views/patch.py1
-rw-r--r--apps/patchwork/views/user.py3
-rw-r--r--apps/patchwork/views/xmlrpc.py2
5 files changed, 3 insertions, 11 deletions
diff --git a/apps/patchwork/models.py b/apps/patchwork/models.py
index 6ad4e1a..6959731 100644
--- a/apps/patchwork/models.py
+++ b/apps/patchwork/models.py
@@ -223,13 +223,8 @@ class Patch(models.Model):
if self.submitter.user == user or self.delegate == user:
return True
- profile = user.get_profile()
return self.project in user.get_profile().maintainer_projects.all()
- def form(self):
- f = PatchForm(instance = self, prefix = self.id)
- return f
-
def filename(self):
fname_re = re.compile('[^-_A-Za-z0-9\.]+')
str = fname_re.sub('-', self.name)
@@ -256,7 +251,6 @@ class Patch(models.Model):
else:
postscript = ''
- responses = False
for comment in Comment.objects.filter(patch = self) \
.exclude(msgid = self.msgid):
body += comment.patch_responses()
diff --git a/apps/patchwork/views/bundle.py b/apps/patchwork/views/bundle.py
index d9db490..e418b3a 100644
--- a/apps/patchwork/views/bundle.py
+++ b/apps/patchwork/views/bundle.py
@@ -68,7 +68,7 @@ def setbundle(request):
try:
patch = Patch.objects.get(id = id)
bundle.append_patch(patch)
- except ex:
+ except:
pass
bundle.save()
diff --git a/apps/patchwork/views/patch.py b/apps/patchwork/views/patch.py
index 6c9fb44..1583009 100644
--- a/apps/patchwork/views/patch.py
+++ b/apps/patchwork/views/patch.py
@@ -30,7 +30,6 @@ def patch(request, patch_id):
patch = get_object_or_404(Patch, id=patch_id)
context.project = patch.project
editable = patch.is_editable(request.user)
- messages = []
form = None
createbundleform = None
diff --git a/apps/patchwork/views/user.py b/apps/patchwork/views/user.py
index c83f0b1..1ae3c2d 100644
--- a/apps/patchwork/views/user.py
+++ b/apps/patchwork/views/user.py
@@ -72,7 +72,7 @@ def link(request):
context),
settings.DEFAULT_FROM_EMAIL,
[form.cleaned_data['email']])
- except Exception, ex:
+ except Exception:
context['confirmation'] = None
context['error'] = 'An error occurred during confirmation. ' + \
'Please try again later'
@@ -97,7 +97,6 @@ def link_confirm(request, key):
@login_required
def unlink(request, person_id):
- context = PatchworkRequestContext(request)
person = get_object_or_404(Person, id = person_id)
if request.method == 'POST':
diff --git a/apps/patchwork/views/xmlrpc.py b/apps/patchwork/views/xmlrpc.py
index 8e8b78c..bb9ebe1 100644
--- a/apps/patchwork/views/xmlrpc.py
+++ b/apps/patchwork/views/xmlrpc.py
@@ -129,7 +129,7 @@ def xmlrpc(request):
try:
ret = dispatcher._marshaled_dispatch(request)
response.write(ret)
- except Exception, e:
+ except Exception:
return HttpResponseServerError()
return response