summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* xmlrpc: Remove duplicated "name" fieldAbhishek Kulkarni2009-08-151-1/+0
| | | | | | | | Remove duplicated "name" field from the list of allowed fields for a patch list filter in the XML RPC interface. Signed-off-by: Abhishek Kulkarni <adkulkar@umail.iu.edu> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests: check some edge cases in bundle reordering testsEduardo Habkost2009-08-151-16/+35
| | | | | | | | | | | | | | | | | | While testing BundleReorderTest, I felt like adding more test cases to check if reordering is touching only the right patches on the bundle. This increases the number of patches on the test bundle to 5, and changes the code to do the following tests: - Reorder all patches - Reorder only the first 3 patches - Reorder only the last 3 patches - Reorder only the middle 3 patches - On all above tests, check if the 'order' field on the BundlePatch objects is still consistent Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests: Fix 'order_start' on BundleReorderTest unit testEduardo Habkost2009-08-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | The 'order_start' parameter on the reorder form should be a patch ID, not the 'order' field of BundlePatch. This fixes the following test failure: > ====================================================================== > FAIL: testBundleReorder (patchwork.tests.bundles.BundleReorderTest) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/mnt/common/code/admin/rh-patchwork/apps/patchwork/tests/bundles.py", line 358, in testBundleReorder > self.failUnlessEqual(response.status_code, 200) > AssertionError: 404 != 200 > > ---------------------------------------------------------------------- > Ran 123 tests in 4.527s > > FAILED (failures=1) Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* parser: allow short-form List-Id headersJeremy Kerr2009-08-012-3/+56
| | | | | | | | | | | | | | | | | Some lists (eg, nongnu.org) have short-form List-Id headers. For example: List-Id: qemu-devel.nongnu.org Although RFC 2919 prescribes that: list-id-header = "List-ID:" [phrase] "<" list-id ">" CRLF we should allow for these headers anyway. Based on an original patch from "J.H." <warthog9@kernel.org>. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* docs: add note about -pass-header Authorization' to INSTALLJeremy Kerr2009-07-111-0/+8
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Fix unarchive actionCarl-Daniel Hailfinger2009-07-081-1/+1
| | | | | | We want to un-archive, not re-archive. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Add nacked-by tagJeremy Kerr2009-07-083-1/+7
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* views: order bundle correctlyJeremy Kerr2009-06-091-1/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* templates: close table cell in project maintainer listJeremy Kerr2009-04-051-0/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* views: separate project views into separate fileJeremy Kerr2009-04-054-16/+41
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* docs: remove completed todo itemsJeremy Kerr2009-02-271-2/+0
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* docs: add items to todoJeremy Kerr2009-02-271-0/+7
| | | | | | Additions to pwclient. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests: test creating bundles with existing namesJeremy Kerr2009-02-271-0/+14
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* migration: fix whitespaceJeremy Kerr2009-02-271-1/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* migration: reset bundlepatch sequence on setupJeremy Kerr2009-02-271-0/+4
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Add extra patch meta tags (Tested/Reviewed/Nacked-by)Mauro Carvalho Chehab2009-02-152-1/+3
| | | | | Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Fix non-ascii character encodings on xmlrpc interfaceMauro Carvalho Chehab2009-02-151-6/+6
| | | | | | | | | | The current xmlrpc interface dies when trying to retrieve patches that contain non-ascii characters. This change uses unicode() rather than str(). Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [views] Check count() for duplicate bundle patches, rather than try/exceptJeremy Kerr2009-02-132-4/+49
| | | | | | | If the exception is raised, the transaction will still be in a bad state, due to the foreign key constraint. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [views] Don't create bundles with no nameJeremy Kerr2009-02-132-1/+27
| | | | | | Check to see that we have a valid name before creating. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [docs] Remove done things from TODOJeremy Kerr2009-02-121-2/+0
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [mbox] Add extra newline after patch commentJeremy Kerr2009-02-121-1/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [mbox] Put ACKs before '---' updatesJeremy Kerr2009-02-123-2/+94
| | | | | | | | | Update the Patch's mbox() function to split into '--- update' sections, allowing us to add Acks and Signoffs in the right place Add tests too. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [sql] Fix up bundle-reorder migration scriptJeremy Kerr2009-02-101-1/+5
| | | | | | | We need to add grants for the new table, and drop the old to prevent reference constraint errors. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [tests] Add initial bundle testsJeremy Kerr2009-02-103-3/+317
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Bundle reordering supportJeremy Kerr2009-02-0810-60/+203
| | | | | | | | Bundles can now be reordered and saved. Add dependency on jquery in INSTALL. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [views] Allow Order class to be user-editableJeremy Kerr2009-02-082-5/+11
| | | | | | | This can be enabled with the editable_order parameter to generic_list Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [sql] Perserve bundle ordering in bundle reorder migration scriptJeremy Kerr2009-02-081-7/+25
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Normalise order numbers in bundle-ordering migration SQLJeremy Kerr2009-02-071-0/+3
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Complete bundle ordering migration scriptJeremy Kerr2009-02-071-5/+7
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Initial bundle reordering supportJeremy Kerr2009-01-297-75/+158
| | | | | | | | | todo: * implement ajax reorder api * finish migration script * order patches in bundle view Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Add per-user default filters to TODOJeremy Kerr2009-01-281-0/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [models] use case-insensitve lookup when creating confirmationJeremy Kerr2009-01-271-1/+1
| | | | | | | We were getting multiple entries when the case-sensitive lookup failed. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Add TODOJeremy Kerr2009-01-081-0/+13
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Use 'from' import for urlresolversJeremy Kerr2009-01-071-3/+2
| | | | | | | Some python installs can't seem to find the fully-qualified module, so use the 'from'-style import instead. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [models] Make patches unique on (msgid, project), not just (msgid)Jeremy Kerr2008-10-294-10/+87
| | | | | | | | | | On patchwork.ozlabs.org, we may see multiple patches for different projects, but with the same message-id. We want these patches to show up on both projects, so we need to change the current UNIQUE contstraint on msgid. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [views] Use standard UserAdmin for admin siteJeremy Kerr2008-10-231-2/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [parser] Handle special case of "New newline at end of file"Nate Case2008-10-231-0/+3
| | | | | | | | | | | | | | | If a file doesn't have a newline at the end, diff will insert a "\ No newline at end of file" line in the middle of the last hunk. parser.py was counting this line as part of the hunk line count. This had the side effect of putting the last line of the hunk in the patch comment, and truncating out the last line of the diff. Handle this special case by not including this line in the internal line counter. This appears to be the only case where diff will insert a string like this within a hunk. Signed-off-by: Nate Case <ncase@xes-inc.com> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [parser] Handle patches with no content charset definedJeremy Kerr2008-10-232-2/+19
| | | | | | If we don't have an incoming charset defined, assume utf-8. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [parser] Convert patch content to unicode before parsingJeremy Kerr2008-10-141-0/+2
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [packages] Fix bug with django 1.0Jeremy Kerr2008-10-101-0/+1
| | | | | | We needed an extra to_field_name Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [parser] Accept x-diff patchesJeremy Kerr2008-10-102-3/+8
| | | | | | We should accept x-diff attachments as well as x-patch. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [packages] update to django 1.0Jeremy Kerr2008-10-104-7/+6
| | | | | | With a minor code change, and a small workaround. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [docs] Create python and packages directoriesJeremy Kerr2008-10-101-0/+4
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [models] Fix exception on mbox view with non-ascii submitter nameJeremy Kerr2008-10-092-2/+25
| | | | | | | | We need to unicode the name instead of str-ing it. Add test. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [sql] use separate grant-all scripts for postgresql and mysqlJeremy Kerr2008-10-093-8/+50
| | | | | | | | | | Mysql doesn't support granting to multiple tables, and requires a different username format. Would be nice to code the permissions somewhere, then generate the grant statements as required. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [encoding] Don't output patch mbox as quoted-printableJeremy Kerr2008-10-072-3/+21
| | | | | | | | git-am doesn't like quoted-printable, so output mbox files as raw 7- or 8-bit mbox files. This means we have to create a new MIMEText class, so that the content isn't automatically QP-encoded on __init__(). Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [models] Create patch mbox with utf-8 encodingJeremy Kerr2008-09-293-3/+59
| | | | | | | | | We were getting exceptions on the mbox view when looking at a non-ascii patch. Add test to suit. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [sql] Default data should be in fixtures, not custom SQLJeremy Kerr2008-09-294-26/+73
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [tests] Remove print from SenderCorrelationTestJeremy Kerr2008-09-291-2/+0
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* [tests] Add tests for utf-8 patchesJeremy Kerr2008-09-294-14/+35
| | | | | | .. which expose a bug in the patch parser, so fix that. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>