summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* templates/bundle: Unify public bundle meta informationJeremy Kerr2012-12-301-2/+8
| | | | | | | | Currently, the public bundle meta information (the download link before the list of patches) differs from that of the private bundle view. This change unifies this information with the private view. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests/bundle: Add tests for public bundle viewsJeremy Kerr2012-12-301-0/+27
| | | | | | | Ensure that public bundles are accessible, and that private ones are not. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* views/bundle: Allow downloading public bundle as mboxSimo Sorce2012-12-303-5/+17
| | | | | | | | | | | Downloading single patches anonymously is allowed, we may as well allow downloading public bundles as mboxes. This patch also changes the file name to be bundle-<id>-<name>.mbox so that the file name is unique even if bundle names are reused. Signed-off-by: Simo Sorce <idra@samba.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* pwclient: Add a little more space in 'pwclient list'Doug Anderson2012-12-301-3/+3
| | | | | | | | New patch IDs are now 7 digits long on patchwork.kernel.org. Give a little more space. Signed-off-by: Doug Anderson <dianders@chromium.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* xmlrpc: Avoid trying to marshall None for people with no nameDoug Anderson2012-12-301-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a person sent patches with no real name, they may have None for their name. In this case just use their email address as their name. The previous pwclient error that would show up looks like: $ pwclient list -w anonymous@example.com Traceback (most recent call last): File ".../pwclient", line 631, in <module> main() File ".../pwclient", line 570, in main action_list(rpc, filt, submitter_str, delegate_str, series_str) File ".../pwclient", line 316, in action_list ids = person_ids_by_name(rpc, submitter_str) File ".../pwclient", line 241, in person_ids_by_name people = rpc.person_list(name, 0) File "/usr/lib/python2.7/xmlrpclib.py", line 1224, in __call__ return self.__send(self.__name, args) File "/usr/lib/python2.7/xmlrpclib.py", line 1578, in __request verbose=self.__verbose File "/usr/lib/python2.7/xmlrpclib.py", line 1264, in request return self.single_request(host, handler, request_body, verbose) File "/usr/lib/python2.7/xmlrpclib.py", line 1297, in single_request return self.parse_response(response) File "/usr/lib/python2.7/xmlrpclib.py", line 1473, in parse_response return u.close() File "/usr/lib/python2.7/xmlrpclib.py", line 793, in close raise Fault(**self._stack[0]) xmlrpclib.Fault: <Fault 1: "<type 'exceptions.TypeError'>:cannot marshal None unless allow_none is enabled"> Signed-off-by: Doug Anderson <dianders@chromium.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* pwclient: Add command for printing patch infoDoug Anderson2012-12-301-2/+14
| | | | | | | | This command prints raw information that patchwork has about a patch. This can be useful for debugging problems with patchwork. Signed-off-by: Doug Anderson <dianders@chromium.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* templates: patchwork project URL fixesJeremy Kerr2012-11-292-2/+2
| | | | | | We need a trailing slash, and to update the URL in the about page too. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* templates: Update patchwork project URLJeremy Kerr2012-11-151-1/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* templates: Add link to the projects website in the projects viewSimo Sorce2012-11-151-2/+7
| | | | | | | | Allows the casual visitor to check out what all these projects actually are. Signed-off-by: Simo Sorce <idra@samba.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Add URL and SCM data to projectsSimo Sorce2012-11-153-0/+26
| | | | | | | | | | | | | | | This allows us to display friendly links to the project website, web SCM UI and SCM URL. For example for the patchwork project these could be set to: web_url: http://jk.ozlabs.org/projects/patchwork/ scm_url: git://ozlabs.org/home/jk/git/patchwork webscm_url: http://git.ozlabs.org/?p=patchwork;a=tree Requires a DB schema upgrade Signed-off-by: Simo Sorce <idra@samba.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Add shortcut to admin panelSimo Sorce2012-11-051-0/+3
| | | | | | | | This patch adds a shortcut to the admin panel but only for users that are members of staff. Signed-off-by: Simo Sorce <idra@samba.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* pwclient: lookup patch_id given Message-IdBen Myers2012-11-051-2/+9
| | | | | | | | Add a pwclient search option '-m' to look up a patch id given a Message-id. This is useful for automation and mailer hooks. Signed-off-by: Ben Myers <bpm@sgi.com> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Fix grant scriptSimo Sorce2012-10-251-2/+1
| | | | | | | | patchwork_patchchangenotification_id_seq does not exist, so running this script simply fails with a rollback Signed-off-by: Simo Sorce <idra@samba.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* bundles: Add check for duplicate bundlesJeremy Kerr2012-10-222-0/+36
| | | | | | ... rather than failing with an IntegrityError. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* requestcontext: Initialise 'messages' context varJeremy Kerr2012-10-081-1/+4
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* settings: Use new class for auth context processorJeremy Kerr2012-10-081-1/+1
| | | | | | Since django 1.2 auth module is in contrib, not core. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* settings: Use class-based template loading APIJeremy Kerr2012-10-081-2/+2
| | | | | | | The TEMPLATE_LOADERS setting changed in django-1.2. Template loaders are now based on calsses rather than callables. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* settings: Add message middlewareJeremy Kerr2012-09-061-0/+1
| | | | | | This seems to be required for admin updates. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* pwclient: Pass input to git-am as a UTF-8 stringJeremy Kerr2012-09-041-1/+1
| | | | | | .. to prevent ascii codec exceptions. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* templates: Don't rely on bool(Page)Jeremy Kerr2012-06-174-2/+41
| | | | | | | | | The behaviour of bool(Page) changed in django 1.4 - it no longer evaluates to False when page has no objects. When checking for an empty patch list, use page.paginator.count. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* models: Add connection parameter for HashField.db_type.Jeremy Kerr2012-05-041-1/+1
| | | | | | This is required by django-1.4. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests: Find test data relative to file locationDirk Wallenstein2012-05-041-2/+2
| | | | | | | Make test execution independent of the current directory. Signed-off-by: Dirk Wallenstein <halsmit@t-online.de> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests/notifications: Add test for escaped patch namesJeremy Kerr2012-05-011-0/+14
| | | | | | .. to test for the fix introduced in 18986b7e. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* notifications: do not HTML-escape patch change notificationsStefan Hajnoczi2012-05-011-1/+1
| | | | | | | | | Patch change notifications are text/plain emails and should not HTML-escape patch names. This means quotes and ampersands in patch names should not be turned into &quot; and &amp; HTML entities. Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests: Check the right optin emailDirk Wallenstein2012-05-011-1/+1
| | | | | Signed-off-by: Dirk Wallenstein <halsmit@t-online.de> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests/patchparser: abstract delegate and state testingJeremy Kerr2012-04-301-21/+17
| | | | | | No need to repeat the same query logic. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests/patchparser: don't assume PK valuesJeremy Kerr2012-04-301-14/+21
| | | | | | | PK values may not start at 1 for each test, so remove filters that assume this. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests: Add tests for explicit delegate and state requestsDirk Wallenstein2012-04-301-2/+106
| | | | | Signed-off-by: Dirk Wallenstein <halsmit@t-online.de> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Use an explicit initial default patch stateDirk Wallenstein2012-04-302-4/+7
| | | | | | | | | | | This will make editing states through the admin UI less error-prone, and will facilitate parsing patches when relying on a default state, as well as testing. Use the explicit default state when parsing mails. Signed-off-by: Dirk Wallenstein <halsmit@t-online.de> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* parser: allow words starting with "diff" at beginning of lineStefan Hajnoczi2012-01-142-1/+6
| | | | | | | | | | | | | | | The patch parser splits emails incorrectly when the comment contains a line whose first word starts with "diff" (like "difficult" or "different"). For a real-life example of an email that triggers this bug, see http://patchwork.ozlabs.org/patch/135291/. Fix the issue by checking for a space after "diff". Add DiffWordInCommentTest to the test suite. Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* sql: remove development migration scriptJeremy Kerr2011-12-081-22/+0
| | | | | | | The projectmaintainer heirachy hasn't been implemented, so we don't need the migration script yet. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests/patchparser: Add CVS format patch testJeremy Kerr2011-12-082-0/+142
| | | | | | | Test that CVS-formatted patches are parsed correctly, and that we capture the correct 'Index: ' metadata. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests: add abstract mbox parsing testJeremy Kerr2011-12-081-7/+9
| | | | | | | Add a new class to handle mbox-parsing code, abstracting what is done by the current git-pull tests. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* filters: handle utf-8 characters when building filter querystringJeremy Kerr2011-12-082-2/+17
| | | | | | | | | | | | | Currently, we build the filter querystring by passing the raw string to urllib.quote, which expects an encoded string. When the raw string (in this case, a unicode object) contains a unicode character, quote() raises a KeyError. This fixes the problem by encoding the parameter name and values to UTF-8 first. Reported-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* patchwork: new pwclient git-am actiondavid decotigny2011-11-251-3/+20
| | | | | | | | | This commit adds a new "pwclient git-am" action which applies given patch ID on the current git branch using "git am". It's convenient to keep track and authorship of patches applied locally from a patchwork server. Signed-off-by: David Decotigny <david.decotigny@google.com>
* parser: allow other protocol types in pull-request handlingJeremy Kerr2011-11-255-1/+1055
| | | | | | Change the parser's regex to allow other protocol types, not just git:// Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* models: Update Person & UserProfile object whenever User is savedJeremy Kerr2011-09-192-5/+46
| | | | | | | | | | | | Currently, UserProfiles are only saved on creation of the User object, before the first_name and last_name attributes are set. This means that we fallback to using the User.username value as the new Person.name. This change modifies User's post-save signal to always update the Person object, both on creation and updates. This means we get the proper name appearing on Person instances. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Merge branch 'notifications'Jeremy Kerr2011-09-1946-118/+1694
|\
| * notifications: implement opt-outnotificationsJeremy Kerr2011-04-143-3/+29
| | | | | | | | | | | | Check for opt-out status before sending notification mail. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
| * notifications: Add NOTIFICATION_FROM_EMAIL settingJeremy Kerr2011-04-143-1/+4
| | | | | | | | | | | | Allow a separate From: address for notificaton emails. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
| * notifications: Add code to send notificationsJeremy Kerr2011-04-146-1/+205
| | | | | | | | | | | | | | | | | | Add a function (patchwork.utils.send_notifications) to process the PatchChangeNotification queue. We try to group mail to the same sender, by waiting settings.NOTIFICATION_DELAY_MINUTES to allow other notifications to arrive. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
| * models: Add PatchChangeNotification and record patch state changesJeremy Kerr2011-04-146-2/+179
| | | | | | | | | | | | | | | | | | Add a PatchChangeNotification model to keep track of changes to a patch's state. Hook this up to Patch's pre_save signal. Requires a DB schema upgrade. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
| * Add email opt-out systemJeremy Kerr2011-04-1421-15/+725
| | | | | | | | | | | | | | | | | | | | | | We're going to start generating emails on patchwork updates, so firstly allow people to opt-out of all patchwork communications. We do this with a 'mail settings' interface, allowing non-registered users to set preferences on their email address. Logged-in users can do this through the user profile view. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
| * registration: use EmailConfimation rather than separate registration appJeremy Kerr2011-04-1424-78/+293
| | | | | | | | | | | | | | | | | | | | Since we have infrastructure for email confirmations, we no longer need the separate registration app. Requires a migration script, which will delete all inactive users, including those newly added and pending confirmation. Use carefully. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
| * Use generic email confirmation objectJeremy Kerr2011-04-1412-33/+274
| | | | | | | | | | | | | | | | | | | | | | | | | | Rather than having a UserPerson-specific confirmation, add an EmailConfirmation object to allow multiple types of confirmations (eg, opt-out requests in future). To do this, we use a view (patchwork.views.confirm) that will call the type-specific view with the confirmation object. Also, add tests to check that the User/Person linkage system works. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* | xmlrpc: do slice before patch_to_dictJeremy Kerr2011-07-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | Currently, we map patch_to_dict before we slice the results (to only return max_count patches). This means that we hacve to retrieve all patches, then throw away most of the results of the map. This change does the slice on the patches before the map, letting django do a LIMIT-ed query instead. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* | settings: Use multiple-DB-style format for default settingsJeremy Kerr2011-04-191-6/+6
| | | | | | | | | | | | | | | | | | | | The DATABASE_* settings have been deprecated in django 1.3, replaced by the multiple-database style format (introduced in 1.2, which patchwork requires anyway). This change modifies the default settings.py to use the new format. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* | Patchwork now requires Django 1.2, so state that in docs/INSTALLGuilherme Salgado2011-04-191-3/+3
| | | | | | | | | | Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* | Order: always set Order.orderJeremy Kerr2011-04-191-2/+1
|/ | | | | | | | | | If we create an Order objecty with editable = True, we don't initialise self.order, leading to testsuite failures with django-1.3. This change always initialises Order.order (and Order.reversed), so we don't exit the constructor without these initalised. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* forms: Fix MultipleBooleanField.to_python when the field value is missingGuilherme Salgado2011-04-141-2/+2
| | | | | | | | | | | If you write a test for, say, the bundle form of a patch list, you'd still have to specify the 'no change' value to other form (e.g. the multiple update one) fields using MultipleBooleanField or else it'd raise a ValueError when field.clean() is called as part of form._get_errors(). Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
generated by cgit v1.2.3 (git 2.25.1) at 2025-09-16 19:31:11 +0000