summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* views: implement CSRF protectionJeremy Kerr2010-08-102-0/+3
| | | | | | | | | | | Since we've got the csrf token present, we may as well check it for requests. We're using RequestContext already (via PatchworkRequestContext), so we just need to switch it on in the settings, and add an exemption on the xmlrpc interface. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* templates: Add CSRF (cross-site request forgery) values to form postsJohn 'Warthog9' Hawley2010-08-1010-0/+20
| | | | | | | | This is a fairly simple patch, basically it does what the error message told me to do: "add In the template, there is a {% csrf_token %} template tag inside each POST form that targets an internal URL." Signed-off-by: John 'Warthog9' Hawley <warthog9@kernel.org>
* parser: decode stdin from utf-8Jeremy Kerr2010-08-101-1/+4
| | | | | | | We need to decode stdin from the patch parser as UTF-8, rather than python assuming ascii. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests/utils: Specify content encoding on MIMEText() constructionJeremy Kerr2010-08-101-6/+5
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tools: add simple patchwork-update-commits scriptJeremy Kerr2010-08-101-0/+16
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* sql: Add uncommitted migration scriptsJeremy Kerr2010-08-102-0/+29
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* docs: fix apache2 referencesJeremy Kerr2010-08-101-3/+3
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Remove broken registration symlinkJeremy Kerr2010-08-101-1/+0
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* lib/apache2: Add WSGI HandlerMartin Krafft2010-08-104-2/+52
| | | | | | | | | | | | | | | | | | | Patchwork/Django can be run directly with WSGI, which is bound to be faster and less complex than FastCGI. This patch provides the necessary Apache configuration and the WSGI handler, as well as an update to the docs. Since python-flup is deprecated and WSGI supersedes FastCGI, it should be(come) the preferred method. Hence I documented it first. For the xmlrpc interface to work with WSGI, the HTTP authorization information needs to be passed to the WSGI handler. This is done by setting WSGIPassAuthorization On in the apache2 config file snippet. Ref: http://www.arnebrodowski.de/blog/508-Django,-mod_wsgi-and-HTTP-Authentication.html Signed-off-by: martin f. krafft <madduck@madduck.net> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* docs: Document password-based pgsql loginMartin Krafft2010-08-101-3/+24
| | | | | | | | | As an alternative to ident-based authentication for PostgreSQL, one can use password-based authentication. This patch adds the alternative to the docs. Signed-off-by: martin f. krafft <madduck@madduck.net> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* docs: reformat INSTALLJeremy Kerr2010-08-101-55/+55
| | | | | | Fix up some tabs. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* docs: elaborate on lib/ dirs in INSTALLJeremy Kerr2010-08-101-0/+3
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* docs: update INSTALL for commonly-available packagesJeremy Kerr2010-08-101-6/+8
| | | | | | | We probably don't need to download django or django-registration anymore. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Registration framework maintained on bitbucketMartin Krafft2010-08-102-6/+4
| | | | | | | | The django-registration framework is now maintained on bitbucket, which requires some changes to the in-tree symlink and the documentation. Signed-off-by: martin f. krafft <madduck@madduck.net> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tools: Update license for post-receive hook.Jeremy Kerr2010-08-101-2/+1
| | | | | | | Martin has allowed distribution under the GPL. http://lists.ozlabs.org/pipermail/patchwork/2010-June/000263.html Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tools: Add a simple sample Git post-receive hookMartin Krafft2010-08-101-0/+73
| | | | | | | | | | | This patch adds a post-receive hook to lib/git, which can be used to update Patchwork following a push to the Git repository. Surely, it can be improved. One thing to do would be to export the state map to git-config somehow. Signed-off-by: martin f. krafft <madduck@madduck.net> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tools: De-hyphenate Git commands in update-patchwork-status.pyMartin Krafft2010-08-101-2/+2
| | | | | | | | Even though update-patchwork-status.py doesn't really do anything yet, it uses the ancient way to call Git commands, so this patch fixes that. Signed-off-by: martin f. krafft <madduck@madduck.net> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* templates/patch-list: add default text for patches with no nameJeremy Kerr2010-08-101-1/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* views/bundle/public: Lookup on userJeremy Kerr2010-07-191-1/+2
| | | | | | | | | | | Currently, the public bundle view is only looking up bundles by their name. This may return multiple bundles if two users have bundles with the same name. This change adds the user to the bundle lookup. Reported-by: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Add TODO item: changing primary email addressesJeremy Kerr2010-04-271-0/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* views: Use request scheme in sample pwclientrc file.Jeremy Kerr2010-03-192-1/+5
| | | | | | Adapt the pwclientrc file to suit the current scheme in use. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* pwclient: allow authenticated https connectionsJeremy Kerr2010-03-191-4/+15
| | | | | | | | If the xmlrpc server is using HTTPS, we need to adapt our custom transport to use SafeTransport.make_connection Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Tested-by: Paul Mundt <lethal@linux-sh.org>
* pwclient get: fix for handling messages encoded in UTF-8Paul Menzel2010-01-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Trying `pwclient get` with a message containing UTF-8 characters you would get the following error. $ python -v pwclient get ID [...] # trying /usr/lib/python2.5/encodings/ascii.so # trying /usr/lib/python2.5/encodings/asciimodule.so # trying /usr/lib/python2.5/encodings/ascii.py # /usr/lib/python2.5/encodings/ascii.pyc matches /usr/lib/python2.5/encodings/ascii.py import encodings.ascii # precompiled from /usr/lib/python2.5/encodings/ascii.pyc Failed to write to subject.patch [...] You can reproduce it with $ pwclient get http://patchwork.openembedded.org/patch/1440/ and the fix is the same as in 4fc6a16910e595401e919abde28cca436193e0dd by Mauro Carvalho Chehab. Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
* pwclient: fallback to patch_get_by_hashJeremy Kerr2009-11-251-1/+7
| | | | | | | | | patch_get_by_project_hash isn't in older xmlrpc interfaces, so fall back to patch_get_by_hash if we see an xmlrpc fault when calling this function. Reported-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Adjust postgres "grant all" script to new name of bundle tableJunio C Hamano2009-11-231-2/+2
| | | | | | | | | | | | | | Since c105cb0 (Initial bundle reordering support, 2009-01-29), the patchwork_bundle_patches table and its associated id sequence does not exist. The script to grant appropriate privileges was not updated when this change was made, and causes the set-up procedure described in docs/INSTALL to fail. This change adjust the script to grant appropriate access rights to match the change in the DB schema. Signed-off-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* models: Add Reported-By to parsed comment fieldsJeremy Kerr2009-10-231-1/+3
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* docs: Fix typo in INSTALLJeremy Kerr2009-10-231-1/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* pwclient,xmlrpc: Specify project for patch hash lookupsJeremy Kerr2009-10-222-3/+13
| | | | | | | | | | | | We may see the same hash for two patches if one is sent to two lists tracked by patchwork. This change adds a new xmlrpc method, patch_get_by_project_hash, which adds the linkname parameter to the lookup. We need to add a new method instead of replacing patch_get_by_hash, to avoid breaking existing pwclient apps. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* pwclient: Add newline to 'no hash' messageJeremy Kerr2009-10-221-1/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Copy headers from original mail into patch mbox outputJeremy Kerr2009-09-302-1/+38
| | | | | | | Preserve the Cc and To headers in the mbox output by parsing the saved original headers, and adding them to the mail object. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Use psycopg2 as default DB engineJeremy Kerr2009-09-301-1/+1
| | | | | | | As the 'postgres' engine seems to have been deprecated, use the postgres_psycopg2 engine instead Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Add pwclient items to TODOJeremy Kerr2009-09-181-0/+2
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Add Message-Id to xmlrpc patch_get_mbox headersThomas Gleixner2009-09-181-0/+1
| | | | | | | | | | | | While trying to utilize patchwork for my daily workflow I noticed that the xmlrpc patch_get_mbox function does not add the original message id to the headers. That forces me to look it up with the browser which is a major PITA. Add Message-Id to the headers. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* pwclient fix for handling messages with UTF-8Mauro Carvalho Chehab2009-09-181-1/+1
| | | | | | | | | | | | | | | | | pwclient works fine viewing utf-8 messages, if you don't try to redirect stdout. However, if you do things like pwclient view 5063 >/tmp/patch, it fails due to the weird character handling logic in python: Traceback (most recent call last): File "/usr/local/bin/pwclient", line 446, in ? main() File "/usr/local/bin/pwclient", line 411, in main print s UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in position 249: ordinal not in range(128) Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* xmlrpc: Remove duplicated "name" fieldAbhishek Kulkarni2009-08-151-1/+0
| | | | | | | | Remove duplicated "name" field from the list of allowed fields for a patch list filter in the XML RPC interface. Signed-off-by: Abhishek Kulkarni <adkulkar@umail.iu.edu> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests: check some edge cases in bundle reordering testsEduardo Habkost2009-08-151-16/+35
| | | | | | | | | | | | | | | | | | While testing BundleReorderTest, I felt like adding more test cases to check if reordering is touching only the right patches on the bundle. This increases the number of patches on the test bundle to 5, and changes the code to do the following tests: - Reorder all patches - Reorder only the first 3 patches - Reorder only the last 3 patches - Reorder only the middle 3 patches - On all above tests, check if the 'order' field on the BundlePatch objects is still consistent Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests: Fix 'order_start' on BundleReorderTest unit testEduardo Habkost2009-08-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | The 'order_start' parameter on the reorder form should be a patch ID, not the 'order' field of BundlePatch. This fixes the following test failure: > ====================================================================== > FAIL: testBundleReorder (patchwork.tests.bundles.BundleReorderTest) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/mnt/common/code/admin/rh-patchwork/apps/patchwork/tests/bundles.py", line 358, in testBundleReorder > self.failUnlessEqual(response.status_code, 200) > AssertionError: 404 != 200 > > ---------------------------------------------------------------------- > Ran 123 tests in 4.527s > > FAILED (failures=1) Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* parser: allow short-form List-Id headersJeremy Kerr2009-08-012-3/+56
| | | | | | | | | | | | | | | | | Some lists (eg, nongnu.org) have short-form List-Id headers. For example: List-Id: qemu-devel.nongnu.org Although RFC 2919 prescribes that: list-id-header = "List-ID:" [phrase] "<" list-id ">" CRLF we should allow for these headers anyway. Based on an original patch from "J.H." <warthog9@kernel.org>. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* docs: add note about -pass-header Authorization' to INSTALLJeremy Kerr2009-07-111-0/+8
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Fix unarchive actionCarl-Daniel Hailfinger2009-07-081-1/+1
| | | | | | We want to un-archive, not re-archive. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Add nacked-by tagJeremy Kerr2009-07-083-1/+7
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* views: order bundle correctlyJeremy Kerr2009-06-091-1/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* templates: close table cell in project maintainer listJeremy Kerr2009-04-051-0/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* views: separate project views into separate fileJeremy Kerr2009-04-054-16/+41
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* docs: remove completed todo itemsJeremy Kerr2009-02-271-2/+0
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* docs: add items to todoJeremy Kerr2009-02-271-0/+7
| | | | | | Additions to pwclient. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* tests: test creating bundles with existing namesJeremy Kerr2009-02-271-0/+14
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* migration: fix whitespaceJeremy Kerr2009-02-271-1/+1
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* migration: reset bundlepatch sequence on setupJeremy Kerr2009-02-271-0/+4
| | | | Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
* Add extra patch meta tags (Tested/Reviewed/Nacked-by)Mauro Carvalho Chehab2009-02-152-1/+3
| | | | | Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-14 00:36:33 +0000