From 8d4b4c7ee342115b50d539dc8a07c5a6178aa508 Mon Sep 17 00:00:00 2001 From: Brian Norris Date: Sat, 22 Nov 2014 20:38:42 -0800 Subject: xmlrpc: include UNIX mbox 'From ' header in patch_get_mbox() This function is misleadingly named 'mbox'; the contents do not begin with a proper 'From xxx ' separator line. (Notably, the mbox format does not have an authoritative standard, but at least this basic 'separator' construct is noted in http://tools.ietf.org/html/rfc4155.) The Message.as_string() function takes an optional [unixfrom] boolean argument. Let's use it, like we do everywhere else (including in the web interface 'mbox' link). Among other things, this means that we can straightforwardly concatenate the output of patch_get_mbox(), and more tools can use this output as-is. Example header: >From patchwork Fri Nov 21 18:24:29 2014 ... Signed-off-by: Brian Norris Signed-off-by: Jeremy Kerr --- apps/patchwork/views/xmlrpc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'apps/patchwork/views') diff --git a/apps/patchwork/views/xmlrpc.py b/apps/patchwork/views/xmlrpc.py index a109866..e188eb3 100644 --- a/apps/patchwork/views/xmlrpc.py +++ b/apps/patchwork/views/xmlrpc.py @@ -381,7 +381,7 @@ def patch_get_mbox(patch_id): """Return mbox string for the given patch ID.""" try: patch = Patch.objects.filter(id = patch_id)[0] - return patch_to_mbox(patch).as_string() + return patch_to_mbox(patch).as_string(True) except: return "" -- cgit v1.2.3