From 7cc12f61df06e90c09b706dc34007bce099a9350 Mon Sep 17 00:00:00 2001 From: Jeremy Kerr Date: Wed, 10 Sep 2008 13:21:39 +1000 Subject: xmlrpc: Fix Python 2.4 compatibility in _marshaled_dispatch Based on an original patch from Nate Case . Python 24 doesn't accept encoding and allow_none fields for xmlrpclib.dumps, so abstract this function at dispatcher init time. Signed-off-by: Jeremy Kerr --- apps/patchwork/views/xmlrpc.py | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) (limited to 'apps') diff --git a/apps/patchwork/views/xmlrpc.py b/apps/patchwork/views/xmlrpc.py index 245962d..791c89e 100644 --- a/apps/patchwork/views/xmlrpc.py +++ b/apps/patchwork/views/xmlrpc.py @@ -39,13 +39,20 @@ class PatchworkXMLRPCDispatcher(SimpleXMLRPCDispatcher): if sys.version_info[:3] >= (2,5,): SimpleXMLRPCDispatcher.__init__(self, allow_none=False, encoding=None) + def _dumps(obj, *args, **kwargs): + kwargs['allow_none'] = self.allow_none + kwargs['encoding'] = self.encoding + return xmlrpclib.dumps(obj, *args, **kwargs) else: + def _dumps(obj, *args, **kwargs): + return xmlrpclib.dumps(obj, *args, **kwargs) SimpleXMLRPCDispatcher.__init__(self) + self.dumps = _dumps + # map of name => (auth, func) self.func_map = {} - def register_function(self, fn, auth_required): self.func_map[fn.__name__] = (auth_required, fn) @@ -99,16 +106,13 @@ class PatchworkXMLRPCDispatcher(SimpleXMLRPCDispatcher): response = self._dispatch(request, method, params) # wrap response in a singleton tuple response = (response,) - response = xmlrpclib.dumps(response, methodresponse=1, - allow_none=self.allow_none, encoding=self.encoding) + response = self.dumps(response, methodresponse=1) except xmlrpclib.Fault, fault: - response = xmlrpclib.dumps(fault, allow_none=self.allow_none, - encoding=self.encoding) + response = self.dumps(fault) except: # report exception back to server - response = xmlrpclib.dumps( + response = self.dumps( xmlrpclib.Fault(1, "%s:%s" % (sys.exc_type, sys.exc_value)), - encoding=self.encoding, allow_none=self.allow_none, ) return response -- cgit v1.2.3