summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKaarle Ritvanen <kaarle.ritvanen@datakunkku.fi>2013-09-18 23:30:41 +0300
committerKaarle Ritvanen <kaarle.ritvanen@datakunkku.fi>2013-09-18 23:30:41 +0300
commitacca3809011b16c9f141d0811bb2d0b9adcb0361 (patch)
tree4206cc092bf8fb45cd07082dbc67ae0788abc983
parent299d5d53f8122b315a9036e192a7f13c0ea2f424 (diff)
downloadaconf-acca3809011b16c9f141d0811bb2d0b9adcb0361.tar.bz2
aconf-acca3809011b16c9f141d0811bb2d0b9adcb0361.tar.xz
web client: remove unnecessary value arguments from rendering functions
-rw-r--r--web/client.js20
1 files changed, 6 insertions, 14 deletions
diff --git a/web/client.js b/web/client.js
index 65a4289..c61e5c7 100644
--- a/web/client.js
+++ b/web/client.js
@@ -557,10 +557,9 @@ $(function() {
table.append(row);
}
- function renderField(
- name, value, meta, label, editable, removable
- ) {
+ function renderField(name, meta, label, editable, removable) {
+ var value = data.get(name);
var status = data.status(name);
if (!(meta.widget in widgets))
@@ -629,11 +628,10 @@ $(function() {
}
}
- function renderCollectionMember(name, value, meta) {
+ function renderCollectionMember(name, meta) {
var set = meta.type == "set";
renderField(
name,
- value,
meta.members,
meta["ui-member"] + " " + name,
!set,
@@ -645,7 +643,6 @@ $(function() {
_.each(data.meta.fields, function(field) {
renderField(
field.name,
- data.get(field.name),
field,
field["ui-name"],
true,
@@ -655,7 +652,7 @@ $(function() {
else _.each(data.data, function(value, name) {
if (_.isArray(data.data)) name++;
- renderCollectionMember(name, data.get(name), data.meta);
+ renderCollectionMember(name, data.meta);
});
if (_.contains(["collection", "list"], data.meta.type)) {
@@ -676,15 +673,10 @@ $(function() {
}
keys.push(name);
- var tn = isTreeNode(data.meta.members);
data.set(
- name, tn ? {} : null
+ name, isTreeNode(data.meta.members) ? {} : null
).done(function(txnValid) {
- renderCollectionMember(
- name,
- tn ? join(path, name) : null,
- data.meta
- );
+ renderCollectionMember(name, data.meta);
button.prop("class", null);
statusBar.validationReady(txnValid);
});