From 884fabbf30837157b7f79f8b603f12dcc0730644 Mon Sep 17 00:00:00 2001 From: Timo Teras Date: Mon, 21 Dec 2009 18:12:45 +0200 Subject: db: honor overlay file even for protected paths --- src/database.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) (limited to 'src') diff --git a/src/database.c b/src/database.c index debe897..3ea8976 100644 --- a/src/database.c +++ b/src/database.c @@ -1923,11 +1923,15 @@ static void apk_db_migrate_files(struct apk_database *db, cstype |= APK_FI_NOFOLLOW; r = apk_file_get_info(db->root_fd, name, cstype, &fi); - if ((diri->dir->flags & APK_DBDIRF_PROTECTED) && - (r == 0) && - (ofile == NULL || - ofile->csum.type == APK_CHECKSUM_NONE || - apk_checksum_compare(&ofile->csum, &fi.csum) != 0)) { + if (ofile->name == NULL) { + /* File was from overlay, delete the + * packages version */ + unlinkat(db->root_fd, tmpname, 0); + } else if ((diri->dir->flags & APK_DBDIRF_PROTECTED) && + (r == 0) && + (ofile == NULL || + ofile->csum.type == APK_CHECKSUM_NONE || + apk_checksum_compare(&ofile->csum, &fi.csum) != 0)) { /* Protected directory, with file without * db entry, or local modifications. * @@ -1942,15 +1946,9 @@ static void apk_db_migrate_files(struct apk_database *db, apk_checksum_compare(&file->csum, &fi.csum) == 0)) unlinkat(db->root_fd, tmpname, 0); } else { - if (ofile->name == NULL) { - /* File was from overlay, delete the - * packages version */ - unlinkat(db->root_fd, tmpname, 0); - } else { - /* Overwrite the old file */ - renameat(db->root_fd, tmpname, - db->root_fd, name); - } + /* Overwrite the old file */ + renameat(db->root_fd, tmpname, + db->root_fd, name); } /* Claim ownership of the file in db */ -- cgit v1.2.3