summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Hemminger <shemminger@vyatta.com>2010-01-13 00:32:40 +0000
committerDavid Lamparter <equinox@diac24.net>2010-02-03 01:53:43 +0100
commitb32d20cfdabab1ae8deec25b608fb23056b38f8d (patch)
tree47bc266049b5dfcd4b8d1dd9c9c6649e8fd296b8
parent29f3a2241609fd547e8e11b1c0a996ff1965a3c8 (diff)
downloadquagga-b32d20cfdabab1ae8deec25b608fb23056b38f8d.tar.bz2
quagga-b32d20cfdabab1ae8deec25b608fb23056b38f8d.tar.xz
thread: remove except fd set
The fd_set exceptfd is never used by any Quagga thread. According to documentation it is only meaningful for out of band data, and no routing protocol uses out of band data. It saves some small amount of kernel overhead to not use it.
-rw-r--r--lib/thread.c4
-rw-r--r--lib/thread.h1
2 files changed, 1 insertions, 4 deletions
diff --git a/lib/thread.c b/lib/thread.c
index e89af541..3880e8af 100644
--- a/lib/thread.c
+++ b/lib/thread.c
@@ -910,7 +910,6 @@ thread_fetch (struct thread_master *m, struct thread *fetch)
struct thread *thread;
fd_set readfd;
fd_set writefd;
- fd_set exceptfd;
struct timeval timer_val;
struct timeval timer_val_bg;
struct timeval *timer_wait;
@@ -936,7 +935,6 @@ thread_fetch (struct thread_master *m, struct thread *fetch)
/* Structure copy. */
readfd = m->readfd;
writefd = m->writefd;
- exceptfd = m->exceptfd;
/* Calculate select wait timer if nothing else to do */
quagga_get_relative (NULL);
@@ -947,7 +945,7 @@ thread_fetch (struct thread_master *m, struct thread *fetch)
(!timer_wait || (timeval_cmp (*timer_wait, *timer_wait_bg) > 0)))
timer_wait = timer_wait_bg;
- num = select (FD_SETSIZE, &readfd, &writefd, &exceptfd, timer_wait);
+ num = select (FD_SETSIZE, &readfd, &writefd, NULL, timer_wait);
/* Signals should get quick treatment */
if (num < 0)
diff --git a/lib/thread.h b/lib/thread.h
index b52bc541..09cb2d99 100644
--- a/lib/thread.h
+++ b/lib/thread.h
@@ -53,7 +53,6 @@ struct thread_master
struct thread_list background;
fd_set readfd;
fd_set writefd;
- fd_set exceptfd;
unsigned long alloc;
};