2005-05-06 Paul Jakma <paul.jakma@sun.com>

        * (general) extern and static qualifiers added.
          unspecified arguments in definitions fixed, typically they should
          be 'void'.
          function casts added for callbacks.
          Guards added to headers which lacked them.
          Proper headers included rather than relying on incomplete
          definitions.
          gcc noreturn function attribute where appropriate.
        * ospf_opaque.c: remove the private definition of ospf_lsa's
          ospf_lsa_refresh_delay.
        * ospf_lsa.h: export ospf_lsa_refresh_delay
        * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
          correct thing to do - removes need for the casts later.
        * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
          home-brewed versions, shuts up several warnings.
        * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
          VTY_GET_IPV4_PREFIX moved to lib/vty.h.
        * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
          overloading of the THREAD_ARG pointer should at least use
          uintptr_t.

1 files changed, 32 insertions, 31 deletions

diff --git a/ospfd/ospf_packet.h b/ospfd/ospf_packet.h
index af9e634b..7b3d6866 100644
--- a/ospfd/ospf_packet.h
+++ b/ospfd/ospf_packet.h
@@ -131,36 +131,37 @@ struct ospf_db_desc
 #define IS_SET_DD_ALL(X)        ((X) & OSPF_DD_FLAG_ALL)
 
 /* Prototypes. */
-void ospf_output_forward (struct stream *, int);
-struct ospf_packet *ospf_packet_new (size_t);
-void ospf_packet_free (struct ospf_packet *);
-struct ospf_fifo *ospf_fifo_new ();
-void ospf_fifo_push (struct ospf_fifo *, struct ospf_packet *);
-struct ospf_packet *ospf_fifo_pop (struct ospf_fifo *);
-struct ospf_packet *ospf_fifo_head (struct ospf_fifo *);
-void ospf_fifo_flush (struct ospf_fifo *);
-void ospf_fifo_free (struct ospf_fifo *);
-void ospf_packet_add (struct ospf_interface *, struct ospf_packet *);
-void ospf_packet_delete (struct ospf_interface *);
-struct stream *ospf_stream_dup (struct stream *);
-struct ospf_packet *ospf_packet_dup (struct ospf_packet *);
-
-int ospf_read (struct thread *);
-void ospf_hello_send (struct ospf_interface *);
-void ospf_db_desc_send (struct ospf_neighbor *);
-void ospf_db_desc_resend (struct ospf_neighbor *);
-void ospf_ls_req_send (struct ospf_neighbor *);
-void ospf_ls_upd_send_lsa (struct ospf_neighbor *, struct ospf_lsa *, int);
-void ospf_ls_upd_send (struct ospf_neighbor *, struct list *, int);
-void ospf_ls_ack_send (struct ospf_neighbor *, struct ospf_lsa *);
-void ospf_ls_ack_send_delayed (struct ospf_interface *);
-void ospf_ls_retransmit (struct ospf_interface *, struct ospf_lsa *);
-void ospf_ls_req_event (struct ospf_neighbor *);
-
-int ospf_ls_upd_timer (struct thread *);
-int ospf_ls_ack_timer (struct thread *);
-int ospf_poll_timer (struct thread *);
-int ospf_hello_reply_timer (struct thread *);
-void ospf_hello_send_sub (struct ospf_interface *, struct in_addr *);
+extern void ospf_output_forward (struct stream *, int);
+extern struct ospf_packet *ospf_packet_new (size_t);
+extern void ospf_packet_free (struct ospf_packet *);
+extern struct ospf_fifo *ospf_fifo_new (void);
+extern void ospf_fifo_push (struct ospf_fifo *, struct ospf_packet *);
+extern struct ospf_packet *ospf_fifo_pop (struct ospf_fifo *);
+extern struct ospf_packet *ospf_fifo_head (struct ospf_fifo *);
+extern void ospf_fifo_flush (struct ospf_fifo *);
+extern void ospf_fifo_free (struct ospf_fifo *);
+extern void ospf_packet_add (struct ospf_interface *, struct ospf_packet *);
+extern void ospf_packet_delete (struct ospf_interface *);
+extern struct stream *ospf_stream_dup (struct stream *);
+extern struct ospf_packet *ospf_packet_dup (struct ospf_packet *);
+
+extern int ospf_read (struct thread *);
+extern void ospf_hello_send (struct ospf_interface *);
+extern void ospf_db_desc_send (struct ospf_neighbor *);
+extern void ospf_db_desc_resend (struct ospf_neighbor *);
+extern void ospf_ls_req_send (struct ospf_neighbor *);
+extern void ospf_ls_upd_send_lsa (struct ospf_neighbor *, struct ospf_lsa *,
+				  int);
+extern void ospf_ls_upd_send (struct ospf_neighbor *, struct list *, int);
+extern void ospf_ls_ack_send (struct ospf_neighbor *, struct ospf_lsa *);
+extern void ospf_ls_ack_send_delayed (struct ospf_interface *);
+extern void ospf_ls_retransmit (struct ospf_interface *, struct ospf_lsa *);
+extern void ospf_ls_req_event (struct ospf_neighbor *);
+
+extern int ospf_ls_upd_timer (struct thread *);
+extern int ospf_ls_ack_timer (struct thread *);
+extern int ospf_poll_timer (struct thread *);
+extern int ospf_hello_reply_timer (struct thread *);
+extern void ospf_hello_send_sub (struct ospf_interface *, struct in_addr *);
 
 #endif /* _ZEBRA_OSPF_PACKET_H */