diff options
author | paul <paul> | 2003-05-21 19:09:31 +0000 |
---|---|---|
committer | paul <paul> | 2003-05-21 19:09:31 +0000 |
commit | 163b5fcaf73d47e04ff6b8d51c312c0a9a2432b6 (patch) | |
tree | 02b2e2e567bb96118cfeb5bb86c16e1065c1f949 /vtysh | |
parent | d8affd795000b39a367ea27fe831eeec2f44a1ee (diff) | |
download | quagga-163b5fcaf73d47e04ff6b8d51c312c0a9a2432b6.tar.bz2 quagga-163b5fcaf73d47e04ff6b8d51c312c0a9a2432b6.tar.xz |
From: Paul Jakma <paulj@alphyra.ie>
Subject: [zebra 19125] vtysh bogus perms check
vtysh checks that the zebra.vty socket uid is == to its own euid, this is
bogus - let the kernel decide whether permissions match, vtysh shouldnt
try second guess. (this becomes noticeable when neither zebra nor vtysh
are run as root :) )
Diffstat (limited to 'vtysh')
-rw-r--r-- | vtysh/vtysh.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/vtysh/vtysh.c b/vtysh/vtysh.c index d1a5c5fd..be1f03e4 100644 --- a/vtysh/vtysh.c +++ b/vtysh/vtysh.c @@ -1618,14 +1618,6 @@ vtysh_connect (struct vtysh_client *vclient, char *path) exit (1); } - if (euid != s_stat.st_uid - || !(s_stat.st_mode & S_IWUSR) - || !(s_stat.st_mode & S_IRUSR)) - { - fprintf (stderr, "vtysh_connect(%s): No permission to access socket\n", - path); - exit (1); - } } sock = socket (AF_UNIX, SOCK_STREAM, 0); |