summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* [BGP/cleanup] make community hash table staticStephen Hemminger2009-06-181-1/+1
|
* [BGP/cleanup] make some damp function staticStephen Hemminger2009-06-182-5/+4
|
* [BGP/cleanup] make ecommunity variables/functions localStephen Hemminger2009-06-182-3/+2
|
* [BGP/cleanup] main program cleanupStephen Hemminger2009-06-181-7/+11
| | | | | Check result of daemon() call to fix warning Make local variables static
* [zebra/cleanup] make message table read onlyStephen Hemminger2009-06-181-1/+1
|
* [OSPF/cleanup] make message lists read onlyStephen Hemminger2009-06-183-23/+23
|
* [bgpd/cleanup] make message lists read onlyStephen Hemminger2009-06-182-16/+16
|
* [bgpd] add comment that bgp_capability_receive is exported for unit-testsPaul Jakma2009-06-181-1/+4
|
* [cleanup] Allow message tables to be constantStephen Hemminger2009-06-182-2/+2
| | | | | Avoid bugs, and improve cache locality by allowing message lists to be read/only.
* [cleanup] Fix compile warningsStephen Hemminger2009-06-181-4/+5
| | | | Fix printf format warning and make capability table 'const static'
* [cleanup] Use const in smux interfaceStephen Hemminger2009-06-182-10/+11
| | | | smux_trap and oid_copy should allow read-only source.
* [bgpd/cleanup] BGP make attribute variables localStephen Hemminger2009-06-181-5/+5
| | | | | Message lists can be read-only, and hash tables are local to this code.
* [bgpd/cleanup] Make BGP FSM table read-only staticStephen Hemminger2009-06-181-1/+1
| | | | The finite state machine table is immutable.
* [bgpd] reference count the BGP instanceStephen Hemminger2009-06-183-19/+47
| | | | | | | | | | | | | | | | When a BGP instance is deleted with lots of routes and neighbors it is possible for the peer rsclient queue to run after bgp_delete has been called. This would lead to bgpd crashing, see https://bugzilla.vyatta.com/show_bug.cgi?id=3436 The fix is to add reference counting to the BGP instance and defer actual freeing until all references are gone. This patch also fixes a memory leak where the self-reference peer instance was being created but never freed. The check in bgp_clear_route is no longer valid because it is possible for it to be called when peer is in Deleted state during cleanup.
* [bgpd] Make declarations matchStephen Hemminger2009-06-181-2/+2
| | | | These variables are const.
* [zebra] Remove unused structure elementStephen Hemminger2009-06-181-3/+0
|
* [zebra] Force rib_update when connected route deletedStephen Hemminger2009-06-181-0/+4
|
* [cleanup] Use correct buffer size for inet_ntop()Stephen Hemminger2009-06-183-23/+25
| | | | | Don't need big buffer 1024 to hold IPV4 (INET_ADDRSTRLEN) or IPv6 (INET6_ADDRSTRLEN) message.
* [ripd] Ignore non-running interfaces in rip statusStephen Hemminger2009-06-181-0/+3
| | | | Vyatta Bug 3999
* [lib] Put symbolic backtrace on system logStephen Hemminger2009-06-181-6/+15
| | | | When BGP crashes, sometimes all we get to see is syslog.
* [lib] sockopt_tcp_signature: sin6 requires HAVE_IPV6Stephen Hemminger2009-06-181-0/+2
| | | | | An external user was building on system without IPv6 and it wouldn't work.
* [ospf6d] Remove 'no router' from OSPF6_NODEStephen Hemminger2009-06-181-1/+0
| | | | Don't need command twice.
* [ospf6d] Fix ospf6d crash if removing interface with no areaJon2009-06-181-0/+7
| | | | | | ospf6d will crash if attempting to remove interface when no areas have been defined Check if any areas have been defined. Should prevent use of empty pointer.
* [ospf6d] Fix ospf6d crash in show border routersJon2009-06-181-0/+6
| | | | | | ospf6d will crash if this command is executed on a non-border-router. Included test to verify that any routes are defined, preventing empty pointer from being used.
* [ospf6] Add no router ospf6Jon2009-06-181-0/+1
| | | | | | Suggestion: Makes no sense to me that the statement to remove ospf6 configuration is located in OSPF6D_NODE. Moved to CONFIG_NODE next to matching define command.
* [ospf6d] Fix ospf6d crash if range defined twiceJon2009-06-181-0/+6
| | | | | | ospf6d will crash if the same range is defined twice. There was no check if the same range had previously been defined, thereby causing a later assert to fail.
* [ospfd] Fix OSPF route refcount leakStephen Hemminger2009-06-181-1/+2
| | | | | This may fix vyatta BUG 3096. The reference count for OSPF route table was never completely freed on deleting all neighbors.
* [zebra] Only announce connected routes if link is detectedStephen Hemminger2009-06-181-1/+1
| | | | | Need to check both IFF_UP and IFF_RUNNING if link-detect is enabled, before announcing routes.
* [zebra] MTU is unsignedStephen Hemminger2009-06-181-1/+1
| | | | | The MTU data in the netlink message is always unsigned 32 bits. Don't use integer.
* [zebra] remove incorrect debug messageStephen Hemminger2009-06-181-2/+0
|
* [zebra] Cleanup meta-queue codeStephen Hemminger2009-06-181-64/+70
| | | | | | | | Do some cleanup work on recently added meta-queue code: * use table rather than switch * indent with quagga standard indentation * since meta_queue_new is only used at initialization allocation failure should be fatal.
* [zebra] netlink interface minor cleanupStephen Hemminger2009-06-182-7/+4
| | | | Add more prototypes and make some functions static
* [zebra] Fix vyatta bug 2814: Add "show ip route summary" command.Stig Thormodsrud2009-06-181-35/+86
|
* [vtysh] Add a --noerror optionStephen Hemminger2009-06-181-7/+18
| | | | | There are times that configuration scripts want to run vtysh but don't want to get error messages or failed exit status
* [vtysh] Return non-zero exit code on error.Stephen Hemminger2009-06-181-1/+2
| | | | If passed a bad command, return non-zero exit code
* [vtysh] Make vtysh more useable for scriptingStephen Hemminger2009-06-183-13/+53
| | | | | | Add environment variable (VTYSH_LOG) for logging. If a command fails, exit with non-zero exit code and don't continue multipart commands.
* [vtysh] Force line buffered mode.Stephen Hemminger2009-06-181-0/+1
| | | | | Vtysh is used in pipelines and it helps if the output starts right away instead of waiting for a whole buffer to fill.
* [gcc] Add gcc printf format checksStephen Hemminger2009-06-181-6/+12
|
* [cleanup] Make command nodes staticStephen Hemminger2009-06-1229-68/+61
| | | | | The cmd_nodes used to configure vty, can mostly be static so (basic data hiding 101).
* [cleanup] functions taking no args should be declared with void argsStephen Hemminger2009-06-1215-35/+35
| | | | | Use Ansi-C prototypes rather than old K&R method of declaring function without arguments
* [cleanup] add const attribute to lib/if.c::if_dumpStephen Hemminger2009-06-121-1/+1
|
* [cleanup] Convert XMALLOC/memset to XCALLOCStephen Hemminger2009-06-1241-248/+79
| | | | Simple conversion of XMALLOC/memset to XCALLOC
* [bgpd] Add support for the old Linux 2.4, TCP_MD5_AUTH RFC2385 patchPaul Jakma2009-06-122-2/+31
| | | | | | | | | * configure.ac: Add a --enable-linux24-tcp-md5 argument, to compile in support for the old TCP-MD5 patch for Linux 2.4 systems. This overrides auto-detection of TCP-MD5 supported by the target system. * lib/sockopt.c: (sockopt_tcp_signature) add in a variant for the old Linux 2.4, TCP_MD5_AUTH variant of TCP-MD5 support, conditional on the previous configure arg.
* [bgpd] Fixed as-path prepend/exclude ASN handlingDenis Ovsienko2009-06-092-5/+5
| | | | | | | | | - aspath_gettoken(): use as_t to fix 4-byte ASN scanning (bug #484) - set_aspath_prepend_cmd(): use CMD_AS_RANGE in message to match actual range - no_set_aspath_prepend_val_cmd(): idem - set_aspath_exclude_cmd(): idem - no_set_aspath_exclude_val_cmd(): idem
* Merge remote branch 'origin/master'Paul Jakma2009-06-0210-12/+12
|\
| * [trivia] Fixed typos in communities text (#334)Denis Ovsienko2009-06-012-4/+4
| |
| * [doc] Stick with quagga.net for consistency (#436)Denis Ovsienko2009-06-017-7/+7
| |
| * [bgpd] 64-bit bugfix in community_del_val by Jeremy Jackson <jerj@coplanar.net>Andrew J. Schorr2009-05-291-1/+1
| | | | | | | | | | * bgpd/bgp_community.c: (community_del_val) Fix bug in memcpy that was using the wrong size on architectures where a pointer is not 32 bits.
* | [snmp] Compiler warning fixes for when "--enable-snmp" is configured.Chris Caputo2009-06-026-143/+172
| | | | | | | | | | Compiled on 32-bit and 64-bit linux gcc 4.1.2 platforms. No run-time testing on 32-bit and limited run-time testing on 64-bit.
* | [smux] 64-bit fix for lib/smux.h SNMP_INTEGER() macroChris Caputo2009-06-021-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Macro SNMP_INTEGER() prepares data which is eventually processed by asn_build_int(). SNMP_INTEGER() was using "int32_t" whereas asn_build_int() uses "long". On 32-bit systems these are the same, both 4 bytes, but on x86 64-bit systems "long" is 8 bytes. asn_build_int()'s reaction to an improperly sized value is to return a NULL pointer. Quagga's smux.c would eventually get this NULL pointer and use it in calculations to determine how much data to send over the smux connection, resulting in garbage being sent to the SNMP agent. Corrected SNMP_INTEGER() to use "long". Tested on 32-bit and 64-bit x86 Linux 2.6.27.10 systems running Quagga 0.99.11 with bgpd smux.