summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* [lib] list_delete shouldn't duplicate list_delete_all_nodePaul Jakma2006-06-152-10/+3
| | | | | | | 2006-06-15 Paul Jakma <paul.jakma@sun.com> * linklist.c: (list_delete) call list_delete_all_node, don't duplicate it.
* [lib] Experimental: have XFREE NULL out the freed pointerPaul Jakma2006-06-152-1/+6
| | | | | | | 2006-06-15 Paul Jakma <paul.jakma@sun.com> * memory.h: Experimental, have XFREE macro NULL out the freed pointer.
* [lib] Fix vector leak in error path in command.c, CID #38Paul Jakma2006-06-152-1/+7
| | | | | | 2006-06-15 Paul Jakma <paul.jakma@sun.com> * command.c: (cmd_describe_command_real) Fix leak, CID #38.
* [ospfd] lsdb_delete/discard_from_db should be more robust to bad argsPaul Jakma2006-06-153-2/+43
| | | | | | | | | | 2006-05-31 Paul Jakma <paul.jakma@sun.com> * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments, print warning. * ospf_lsa.c: (ospf_discard_from_db) ditto. (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible mitigation (but not solution) for bug #269.
* [ospfd] suppres mostly uninteresting debug message unless debug is setPaul Jakma2006-06-152-3/+10
| | | | | | | | 2006-05-30 Paul Jakma <paul.jakma@sun.com> * ospf_packet.c: (ospf_read) Debug message about packets received on unenabled interfaces should be conditional on debug being set.
* [tests] Fix stray character in previous commitPaul Jakma2006-05-281-2/+1
|
* [tests] test-sig.c: configure loggingPaul Jakma2006-05-282-1/+14
| | | | | | | | 2006-05-28 Paul Jakma <paul.jakma@sun.com> * test-sig.c: (main) configure logging, there's no terminal to write to for one thing, but we do want stdout, and we don't want a test to spam syslog.
* [lib] Add support for Sun libc printstack to zlog_backtrace_sigsafePaul Jakma2006-05-284-16/+38
| | | | | | | | | | | | | | 2006-05-28 Paul Jakma <paul.jakma@sun.com> * configure.ac: Check for Sun libc printstack(), add a general HAVE_STACK_TRACE define for lib/log.c, if any supported stack symbol dumping function is found (glibc backtrace/sun libc printstack). * log.c: (general) Add support for Sun libc printstack(). (hex_append) make the cpp conditional on general HAVE_STACK_TRACE define. (zlog_backtrace_sigsafe) Ditto. Add printstack() version of the the DUMP macro in this function.
* [lib] vty_log shouldn't crash if called when vty isn't initiliasedPaul Jakma2006-05-282-0/+9
| | | | | | | 2006-05-28 Paul Jakma <paul.jakma@sun.com> * vty.c: (vty_log/vty_log_fixed) dont crash if called when vty hasn't been initiliased.
* [lib] malloc.h is deprecated, try not to include it anymorePaul Jakma2006-05-282-0/+5
| | | | | | | 2006-05-28 Paul Jakma <paul.jakma@sun.com> * memory.c: malloc.h is deprecated in favour of stdlib.h, however we still need it on GNU Libc for mallinfo().
* [lib] include inttypes.h rather than stdint.h, provide defines where missingPaul Jakma2006-05-282-6/+29
| | | | | | | | 2006-05-28 Paul Jakma <paul.jakma@sun.com> * zebra.h: Include inttypes.h rather than stdint.h, best practice according to the autoconf manual. Add UINT*_MAX defines for older platforms lacking these (FBSD 4)
* [build] Update SOS CFLAGS and add check for GNU Make in configure.acPaul Jakma2006-05-282-4/+33
| | | | | | | | | 2006-05-28 Paul Jakma <paul.jakma@sun.com> * configure.ac: Update SOS CFLAGS, Xt shouldn't be used and enable debug options. Add a check for GNU Make and warn the user if it does not appear to be the make used.
* [vtysh] Add "show memory" to vtyshPaul Jakma2006-05-282-0/+30
| | | | | | 2006-05-24 Paul Jakma <paul.jakma@sun.com> * vtysh.c: (general) Add 'show memory' command.
* [bgpd] expand vty help for neighbor ... update-sourcePaul Jakma2006-05-232-4/+13
| | | | | | | 2006-05-23 Paul Jakma <paul.jakma@sun.com> * bgp_vty.c: (neighbor_update_source_cmd) Expand tab completion to make it clear it takes both address and ifname.
* [doc] document neighbor ..... update-sourcePaul Jakma2006-05-232-3/+23
| | | | | | 2006-05-23 Paul Jakma <paul.jakma@sun.com> * bgpd.texi: Document the update-source command.
* [vtysh] suppress output in 'show logging' for daemons not presentPaul Jakma2006-05-232-6/+13
| | | | | | | 2006-05-21 Paul Jakma <paul.jakma@sun.com> * vtysh.c: (vtysh_show_logging_cmd) Suppress output for daemons which are not running (Andrew Schorr).
* [vtysh] Add 'show logging' commandPaul Jakma2006-05-232-1/+28
| | | | | | 2006-05-17 Paul Jakma <paul.jakma@sun.com> * vtysh.c: (general) Add 'show logging' command.
* [interface configuration] Try to avoid losing address info after shutdown.Andrew J. Schorr2006-05-214-4/+32
| | | | | | | | | | | | 2006-05-21 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * if.h: (struct connected) Document the meaning of the ZEBRA_IFC_REAL and ZEBRA_IFC_CONFIGURED flags. * connected.c: (connected_withdraw) Do not delete the connected address if the ZEBRA_IFC_CONFIGURED flag is set. (connected_add_ipv4,connected_add_ipv6) Before calling connected_withdraw, unset the ZEBRA_IFC_CONFIGURED flag on the superseded connected structure.
* [interface configuration] Preserve flag indicating address was set by quagga.Andrew J. Schorr2006-05-192-2/+17
| | | | | | | | | 2006-05-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * connected.c: (connected_add_ipv4,connected_add_ipv6) If the new struct connected matches an already existing one (that will consequently be removed by connected_withdraw), then be sure to preserve the ZEBRA_IFC_CONFIGURED flag.
* [debug] Improve zebra kernel socket debug message to include IP addresses.Andrew J. Schorr2006-05-172-3/+45
| | | | | | | 2006-05-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * kernel_socket.c: (ifam_read_mesg) Improve debug message to show the IP address.
* [zebra] Remove private command string tablePaul Jakma2006-05-152-29/+6
| | | | | | | 2006-05-15 Paul Jakma <paul.jakma@sun.com> * zserv.c: (general) Remove the private zebra_command_str in favour of newly added libzebra zserv_command_string.
* [lib] Add string mapping table for Zserv commandsPaul Jakma2006-05-153-22/+81
| | | | | | | | | | | | | | 2006-05-15 Paul Jakma <paul.jakma@sun.com> * log.c: (general) Generalise struct zebra_route_desc into struct zebra_desc_table and, similar to route_types, add a command_types table to describe Zserv protocol commands. (route_types[]) use a macro to use designated initialisers while avoiding tedious duplication. (zserv_command_string) lookup string from zebra_desc_table, similar to zebra_route_string * zebra.h: Add declaration for zserv_command_string, adjust the comments to reflect zebra_desc_table.
* [lib] CID #39, Fix the vty completion leak-fix to only free when desiredPaul Jakma2006-05-152-1/+8
| | | | | | | | 2006-05-13 Paul Jakma <paul.jakma@sun.com> * vty.c: (vty_describe_command) CID #39 fix was too hasty, just cause it /can/ leak doesn't mean it always will have, check first.
* [ospf6d] GNU Zebra 3563: Fix as-external forwarding addressPaul Jakma2006-05-153-3/+9
| | | | | | | 2006-03-01 Yasuhiro Ohara <yasu@sfc.wide.ad.jp> * ospf6_asbr.c: fix bug of needless forwarding address * ospf6d.h: version 0.9.7r
* [ospf6d] GNU Zebra #3562: ABR Crash fix, memory fixes, route table debugsPaul Jakma2006-05-1511-54/+340
| | | | | | | | 2006-02-22 Yasuhiro Ohara <yasu@sfc.wide.ad.jp> * valgrind check and memory fix * route table identification string added * ospf6d.h: version 0.9.7q
* [ospf6d] GNU Zebra 3560: Call ospf6_maxage_remove when out of Exchange/LoadingPaul Jakma2006-05-153-12/+8
| | | | | | | 2005-10-20 Yasuhiro Ohara <yasu@sfc.wide.ad.jp> * ospf6_neighbor.c: add the calling of ospf6_maxage_remove () when the neighbor went out of Exchange/Loading.
* [ospf6d] Import GNU Zebra CVSps#3559: Fix inter-area as-ext bug, cleanup debugPaul Jakma2006-05-157-70/+286
| | | | | | | | | 2005-10-06 Yasuhiro Ohara <yasu@sfc.wide.ad.jp> * ospf6_asbr.c: fix bug of calculating AS-External routes in other areas. Add debugging function for border-router calculation. * ospf6d.h: version 0.9.7p
* [bgpd] CID #4,#5,#9,#10, simplify aspath_print_vty usagePaul Jakma2006-05-124-30/+24
| | | | | | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * bgp_aspath.{c,h}: (aspath_print_vty) take a format string, so as to reduce burden on callers, all in bgp_route.c * bgp_route.c: (route_vty_out{,tmp}) Update to match aspath_print_vty, simplifying checks needed to get spacing right. CID #4,#5. ({damp,flap}_route_vty_out) Ditto, CID #9, #10
* [bgpd] CID #6, remove useless NULL check, bgp_static_update_rsclientPaul Jakma2006-05-122-6/+9
| | | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * bgp_route.c: (bgp_static_update_rsclient) Remove useless NULL check, code already assumes bgp_static can not be NULL, fixes CID #6.
* [bgpd] CID #7, remove useless NULL check, bgp_static_update_mainPaul Jakma2006-05-122-6/+11
| | | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * bgp_route.c: (bgp_static_update_main) Remove useless NULL check, code already assumes bgp_static can not be NULL, fixes CID #7.
* [bgpd] Remove dead code in ORIGINATOR_ID packet forming codePaul Jakma2006-05-122-7/+7
| | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity CID #1
* [lib] CID #55, fix return of freed pointer, cmd_describe_command_realPaul Jakma2006-05-122-3/+5
| | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * command.c: (cmd_describe_command_real) Fix return of freed pointer when no-match, CID #55.
* [lib] CID #39, fix leak in error path, vty_describe_commandPaul Jakma2006-05-122-8/+5
| | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * vty.c: (vty_describe_command) fix leak of describe vector in error path, CID #39.
* [lib] CID #37, fix error case leak, cmd_complete_command_realPaul Jakma2006-05-122-1/+4
| | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * command.c: (cmd_complete_command_real) Fix leak of cmd_vector in error case, Coverity CID #37.
* [lib] CID #3, fix forward-null errors in vty_prefix_list_uninstallPaul Jakma2006-05-122-0/+12
| | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * plist.c: (vty_prefix_list_uninstall) Fix potential NULL deref of prefix and typestr strings, Coverity CID #3.
* [ospfd] Fix small error in CID #13 commitPaul Jakma2006-05-122-1/+6
| | | | | | | 2006-05-13 Paul Jakma <paul.jakma@sun.com> * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity check to match the assert, small error in CID #13 fix.
* [ospfd] CID #13, debug for NULL type7 LSA should not print out data from itPaul Jakma2006-05-122-2/+8
| | | | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * ospf_lsa.c: (ospf_translated_nssa_refresh) Add non-assert sanity check, in case DEBUG isn't defined. Debug message when no type7 exists should print the ID from the type5, not the type7, fixes CID #13.
* [ospfd] CID #15, remove redundant NULL check in ism_change_statePaul Jakma2006-05-122-11/+13
| | | | | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * ospf_ism.c: (ism_change_state) NULL check on oi->area is useless, it's always valid. Only possibility where it couldn't be is if there is a race between abr_task and cleaning up oi's, in which case a NULL check here isn't going to do anything. Fixes CID #15.
* [ospfd] CID #14, NULL check ospf->backbone before use, ospf_update_router_routePaul Jakma2006-05-122-7/+8
| | | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be NULL when passed to ospf_find_asbr_route_through_area, check for NULL first, CID #14.
* [ospfd] CID #28, remove another ospf_lookup call - ospf_redistribute_withdrawPaul Jakma2006-05-124-6/+9
| | | | | | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup call by taking the struct ospf * as argument, which the caller has, fixing CID #28. * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration * ospf_zebra.c: (ospf_redistribute_unset) update call to ospf_redistribute_withdraw to match.
* [ospfd] CID #27, fix missing NULL return checkPaul Jakma2006-05-122-1/+4
| | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * ospf_interface.c: (ospf_if_exists) Fix missing NULL return check on ospf_lookup, CID #27.
* [ospfd] CID #29, fix missing NULL check by removing unused code.Paul Jakma2006-05-122-22/+10
| | | | | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup call, which is not checked for NULL return, by stripping out functionality which is never used, hence fixing Coverity CID #29. (struct lsa_action) remove unused member.
* [ospfd] Squash another ospf_lookup callPaul Jakma2006-05-124-10/+11
| | | | | | | | | | | | 2006-05-11 Paul Jakma <paul.jakma@sun.com> * ospf_lsa.c: (ospf_default_originate_timer) Let the thread take (struct ospf *) as thread argument, rather than (struct ospf *)->default_originate, thus avoiding having to call ospf_lookup. * ospf_zebra.c: (ospf_redistribute_default_set) change setup of ospf_default_originate_timer thread to match. * ospfd.c: (ospf_router_id_update) ditto.
* [ospfd] Fix leak in area-range-cost command, CID #46.Paul Jakma2006-05-122-1/+4
| | | | | | | | 2006-05-11 Paul Jakma <paul.jakma@sun.com> * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new range, should just lookup to see if one exists, the new range is just leaked. Fixes CID #46.
* [ospfd] CID #49, fix dereference before NULL checkPaul Jakma2006-05-122-1/+3
| | | | | | | 2006-05-11 Paul Jakma <paul.jakma@sun.com> * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before NULL check by moving into check-protected block, fix CID #49.
* [ospfd] Check NULL result from ospf_area_lookup_by_area_id, CID #69Paul Jakma2006-05-112-1/+5
| | | | | | | 2006-05-11 Paul Jakma <paul.jakma@sun.com> * ospf_vty.c: (no_ospf_area_filter_list) Check NULL result from ospf_area_lookup_by_area_id, fixes Coverity CID #69
* [ospfd] Fix missing check for ospf_lookup NULL return, CID #70Paul Jakma2006-05-112-16/+29
| | | | | | | | | 2006-05-11 Paul Jakma <paul.jakma@sun.com> * ospf_vty.c: (general) Audit ospf_lookup calls in commands, ensure check for NULL result, make vty messages consistent. (show_ip_ospf_interface) Missing NULL check on ospf_lookup result, fixes Coverity CID #70.
* [zebra] CID #31, guard against potential NULL return of route_node_lookupPaul Jakma2006-05-112-2/+7
| | | | | | | 2006-05-11 Paul Jakma <paul.jakma@sun.com> * interface.c: (if_delete_update) route_node_lookup may return NULL, should fix Coverity CID #31.
* [ripngd] CID #72, remove unneeded NULL checkPaul Jakma2006-05-112-11/+14
| | | | | | | 2006-05-11 Paul Jakma <paul.jakma@sun.com> * ripng_interface.c: (ripng_interface_address_add) Remove unneeded NULL check, Coverity CID #72.
* [doc] Update auto-generated quagga.infoquagga_0_99_4_releasePaul Jakma2006-05-102-234/+409
| | | | | | 2006-05-10 Paul Jakma <paul.jakma@sun.com> * quagga.info: update auto-built file.