summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* [ospfd] Avoid getting NSM stuck in ExStart by using local view of DR/BDRajs2006-06-302-2/+9
| | | | | | | | | 2006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * ospf_nsm.c: (nsm_twoway_received) When deciding whether to change from state Init to ExStart, the test for whether the neighboring router is DR or BDR should be against the local router's notion of DR/BDR, not the neighbor's view.
* [ospfd] Implement new ospf router subcommand "log-adjacency-changes [detail]"ajs2006-06-296-3/+116
| | | | | | | | | | | | | | | | | | 2006-06-28 Erik Muller <erikm@internap.com> * ospfd.h: Define 2 new struct ospf config flags: OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL * ospf_nsm.c (nsm_change_state): Log adjacency changes if requested. * ospf_vty.c (ospf_log_adjacency_changes): New command function to implement ospf subcommand "log-adjacency-changes [detail]". (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes. (show_ip_ospf) Show whether adjacency changes are logged. (ospf_config_write) Add "log-adjacency-changes [detail]" to config. (ospf_vty_init) Add ospf_log_adjacency_changes and no_ospf_log_adjacency_changes. * ospfd.texi: Document new ospf router subcommand "log-adjacency-changes [detail]".
* [lib] Remove bare routes in route_types: fix mistake in commmitpaul2006-06-271-3/+1
| | | | | | | 2006-06-27 Paul Jakma <paul.jakma@sun.com> * route_types.awk: Fix previous commit. Forgot to remove the printf of the bare/numeric route-type help string (empty string)
* [lib] Remove numeric route-type argument in redistribute arg stringspaul2006-06-272-6/+13
| | | | | | | 2006-06-27 Paul Jakma <paul.jakma@sun.com> * route_types.awk: Remove setting the 'bare' numeric route type in redist strings.
* [ospfd] Replace redistribution strings with new route_types.h defines.paul2006-06-272-89/+49
| | | | | | | | 2006-05-23 Paul Jakma <paul.jakma@sun.com> * ospf_vty.c: (general) Replace in-place route redistribution command and help strings with the new auto-generated defines from lib/route_types.h
* [lib] Centralise Zserv route type information, auto-generate redist stringspaul2006-06-275-4/+279
| | | | | | | | | | | 2006-05-23 Paul Jakma <paul.jakma@sun.com> * route_types.txt: New file, table of ZEBRA_ROUTE definitions. * route_types.awk: New script, to parse previous and generate (for now) redistribute string defines. * Makefile.am: build route_types.h using previous two, ala memtypes.h, include the script and table file in EXTRA_DIST. * command.h: pull in route_types.h, add a REDIST_STR define.
* [doc] OSPF MD5 keyid documentation, fix texinfo warnings in bgpd.texipaul2006-06-263-4/+16
| | | | | | | | 2006-06-26 Paul Jakma <paul.jakma@sun.com> * ospfd.texi: Document that MD5 keyid is part of the protocol. * bgpd.texi: shut texinfo warnings up by replacing brackets in variable with angle brackets.
* [ospfd] NSSA translate-enabled ABR should declare itself as ASBRpaul2006-06-263-49/+76
| | | | | | | | | | | | | | | 2006-06-26 Paul Jakma <paul.jakma@sun.com> * ospf_abr.c: (general) NSSA translate-candidate ABRs need to be ASBRs, or other routers may rightfully refuse to install translated type-5s LSAs. reported by dendroot@gmail.com. (ospf_abr_nssa_check_status) Detect change in translator state when ABR, and inc/dec redistribute count as when we leave/enter the disabled state - so that translate-enabled ABR properly sets ASBR bit on non-NSSA areas. Run the resulting function through indent to clean it up. * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit, NSSA area is same as stub area.
* [ospfd] Improve two info log messages in ospf_snmp.cajs2006-06-242-2/+13
| | | | | | | 2006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve info log message to indicate why the trap is being sent.
* [ospfd] When writing out config, show "debug ospf nsm status" properlyajs2006-06-242-1/+6
| | | | | | | 2006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm status properly (not ism status).
* [ospfd] Fix ospf passive-interface subcommand to create interface if necessaryajs2006-06-182-14/+9
| | | | | | | | | 2006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name with a call to if_get_by_name -- if the interface does not exist already, it should be created. And remove the obsolete warning message.
* [redhat quagga.spec] Detect fedora release automaticallyajs2006-06-152-2/+8
| | | | | | | | 2006-06-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * redhat/quagga.spec.in: Get default distro automatically by using rpm to query the fedora-release version. And fix a typo (should be default_dist, not dist_default).
* [ospfd] Fix multicast membership drop bugpaul2006-06-155-22/+66
| | | | | | | | | | | | | | | | | | 2006-06-15 Paul Jakma <paul.jakma@sun.com> * Reported by Milan Koci * ospf_interface.h: (struct ospf_if_info) Add reference counts for multicast group memberships. Add various macros to help manipulate/check membership state. * ospf_interface.c: (ospf_if_set_multicast) Maintain the ospf_if_info reference counts, and only actually drop memberships if it hits 0, to avoid losing membership when OSPF is disabled on an interface with multiple active OSPF interfaces. * ospf_packet.c: (ospf_{hello,read}) Use the new macros to check/set multicast membership. * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
* [zebra] Fix forgetfulness wrt configured address on FreeBSDpaul2006-06-153-21/+74
| | | | | | | | | | | | | | | | 2006-06-15 Paul Jakma <paul.jakma@sun.com> * (general) The key fixes are actually Andrew Schorr's. * interface.c: (ip_address_uninstall) Unset the configured flag. * connected.c: (connected_same) new helper, check whether two connected are same. (connected_implicit_withdraw) new helper, consolidation of existing code in connected_add_ipv{4,6}. Try filter out unneeded Zserv address delete/adds when address is exact same. Where old address is implicitely removed, be sure to preserve the IFC_CONFIGURED flag if set, fixes bug where configured addresses were being lost on FreeBSD.
* [zebra] remove internal if_flag_dump, use libzebras version.paul2006-06-154-46/+11
| | | | | | | | | 2006-06-15 Paul Jakma <paul.jakma@sun.com> * lib/if.c: (if_flag_dump) remove the whitespace indentation, callers should provide. * zebra/interface.c: (if_flag_dump_vty) redundant code, remove. (if_dump_vty) use libzebra if_flag_dump.
* [lib] list_delete shouldn't duplicate list_delete_all_nodepaul2006-06-152-10/+3
| | | | | | | 2006-06-15 Paul Jakma <paul.jakma@sun.com> * linklist.c: (list_delete) call list_delete_all_node, don't duplicate it.
* [lib] Experimental: have XFREE NULL out the freed pointerpaul2006-06-152-1/+6
| | | | | | | 2006-06-15 Paul Jakma <paul.jakma@sun.com> * memory.h: Experimental, have XFREE macro NULL out the freed pointer.
* [lib] Fix vector leak in error path in command.c, CID #38paul2006-06-152-0/+6
| | | | | | 2006-06-15 Paul Jakma <paul.jakma@sun.com> * command.c: (cmd_describe_command_real) Fix leak, CID #38.
* [ospfd] lsdb_delete/discard_from_db should be more robust to bad argspaul2006-06-153-2/+43
| | | | | | | | | | 2006-05-31 Paul Jakma <paul.jakma@sun.com> * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments, print warning. * ospf_lsa.c: (ospf_discard_from_db) ditto. (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible mitigation (but not solution) for bug #269.
* [ospfd] suppres mostly uninteresting debug message unless debug is setpaul2006-06-152-3/+10
| | | | | | | | 2006-05-30 Paul Jakma <paul.jakma@sun.com> * ospf_packet.c: (ospf_read) Debug message about packets received on unenabled interfaces should be conditional on debug being set.
* [tests] Fix stray character in previous commitpaul2006-05-281-2/+1
|
* [tests] test-sig.c: configure loggingpaul2006-05-282-1/+14
| | | | | | | | 2006-05-28 Paul Jakma <paul.jakma@sun.com> * test-sig.c: (main) configure logging, there's no terminal to write to for one thing, but we do want stdout, and we don't want a test to spam syslog.
* [lib] Add support for Sun libc printstack to zlog_backtrace_sigsafepaul2006-05-284-15/+37
| | | | | | | | | | | | | | 2006-05-28 Paul Jakma <paul.jakma@sun.com> * configure.ac: Check for Sun libc printstack(), add a general HAVE_STACK_TRACE define for lib/log.c, if any supported stack symbol dumping function is found (glibc backtrace/sun libc printstack). * log.c: (general) Add support for Sun libc printstack(). (hex_append) make the cpp conditional on general HAVE_STACK_TRACE define. (zlog_backtrace_sigsafe) Ditto. Add printstack() version of the the DUMP macro in this function.
* [lib] vty_log shouldn't crash if called when vty isn't initiliasedpaul2006-05-282-0/+9
| | | | | | | 2006-05-28 Paul Jakma <paul.jakma@sun.com> * vty.c: (vty_log/vty_log_fixed) dont crash if called when vty hasn't been initiliased.
* [lib] malloc.h is deprecated, try not to include it anymorepaul2006-05-282-0/+5
| | | | | | | 2006-05-28 Paul Jakma <paul.jakma@sun.com> * memory.c: malloc.h is deprecated in favour of stdlib.h, however we still need it on GNU Libc for mallinfo().
* [lib] include inttypes.h rather than stdint.h, provide defines where missingpaul2006-05-282-6/+29
| | | | | | | | 2006-05-28 Paul Jakma <paul.jakma@sun.com> * zebra.h: Include inttypes.h rather than stdint.h, best practice according to the autoconf manual. Add UINT*_MAX defines for older platforms lacking these (FBSD 4)
* [build] Update SOS CFLAGS and add check for GNU Make in configure.acpaul2006-05-282-3/+32
| | | | | | | | | 2006-05-28 Paul Jakma <paul.jakma@sun.com> * configure.ac: Update SOS CFLAGS, Xt shouldn't be used and enable debug options. Add a check for GNU Make and warn the user if it does not appear to be the make used.
* [vtysh] Add "show memory" to vtyshpaul2006-05-282-0/+30
| | | | | | 2006-05-24 Paul Jakma <paul.jakma@sun.com> * vtysh.c: (general) Add 'show memory' command.
* [bgpd] expand vty help for neighbor ... update-sourcepaul2006-05-232-4/+13
| | | | | | | 2006-05-23 Paul Jakma <paul.jakma@sun.com> * bgp_vty.c: (neighbor_update_source_cmd) Expand tab completion to make it clear it takes both address and ifname.
* [doc] document neighbor ..... update-sourcepaul2006-05-232-3/+23
| | | | | | 2006-05-23 Paul Jakma <paul.jakma@sun.com> * bgpd.texi: Document the update-source command.
* [vtysh] suppress output in 'show logging' for daemons not presentpaul2006-05-232-6/+13
| | | | | | | 2006-05-21 Paul Jakma <paul.jakma@sun.com> * vtysh.c: (vtysh_show_logging_cmd) Suppress output for daemons which are not running (Andrew Schorr).
* [vtysh] Add 'show logging' commandpaul2006-05-232-1/+28
| | | | | | 2006-05-17 Paul Jakma <paul.jakma@sun.com> * vtysh.c: (general) Add 'show logging' command.
* [interface configuration] Try to avoid losing address info after shutdown.ajs2006-05-214-4/+32
| | | | | | | | | | | | 2006-05-21 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * if.h: (struct connected) Document the meaning of the ZEBRA_IFC_REAL and ZEBRA_IFC_CONFIGURED flags. * connected.c: (connected_withdraw) Do not delete the connected address if the ZEBRA_IFC_CONFIGURED flag is set. (connected_add_ipv4,connected_add_ipv6) Before calling connected_withdraw, unset the ZEBRA_IFC_CONFIGURED flag on the superseded connected structure.
* [interface configuration] Preserve flag indicating address was set by quagga.ajs2006-05-192-2/+17
| | | | | | | | | 2006-05-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * connected.c: (connected_add_ipv4,connected_add_ipv6) If the new struct connected matches an already existing one (that will consequently be removed by connected_withdraw), then be sure to preserve the ZEBRA_IFC_CONFIGURED flag.
* [debug] Improve zebra kernel socket debug message to include IP addresses.ajs2006-05-172-3/+45
| | | | | | | 2006-05-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * kernel_socket.c: (ifam_read_mesg) Improve debug message to show the IP address.
* [zebra] Remove private command string tablepaul2006-05-152-29/+6
| | | | | | | 2006-05-15 Paul Jakma <paul.jakma@sun.com> * zserv.c: (general) Remove the private zebra_command_str in favour of newly added libzebra zserv_command_string.
* [lib] Add string mapping table for Zserv commandspaul2006-05-153-21/+80
| | | | | | | | | | | | | | 2006-05-15 Paul Jakma <paul.jakma@sun.com> * log.c: (general) Generalise struct zebra_route_desc into struct zebra_desc_table and, similar to route_types, add a command_types table to describe Zserv protocol commands. (route_types[]) use a macro to use designated initialisers while avoiding tedious duplication. (zserv_command_string) lookup string from zebra_desc_table, similar to zebra_route_string * zebra.h: Add declaration for zserv_command_string, adjust the comments to reflect zebra_desc_table.
* [lib] CID #39, Fix the vty completion leak-fix to only free when desiredpaul2006-05-152-1/+8
| | | | | | | | 2006-05-13 Paul Jakma <paul.jakma@sun.com> * vty.c: (vty_describe_command) CID #39 fix was too hasty, just cause it /can/ leak doesn't mean it always will have, check first.
* [ospf6d] GNU Zebra 3563: Fix as-external forwarding addresspaul2006-05-153-3/+9
| | | | | | | 2006-03-01 Yasuhiro Ohara <yasu@sfc.wide.ad.jp> * ospf6_asbr.c: fix bug of needless forwarding address * ospf6d.h: version 0.9.7r
* [ospf6d] GNU Zebra #3562: ABR Crash fix, memory fixes, route table debugspaul2006-05-1511-54/+340
| | | | | | | | 2006-02-22 Yasuhiro Ohara <yasu@sfc.wide.ad.jp> * valgrind check and memory fix * route table identification string added * ospf6d.h: version 0.9.7q
* [ospf6d] GNU Zebra 3560: Call ospf6_maxage_remove when out of Exchange/Loadingpaul2006-05-153-12/+8
| | | | | | | 2005-10-20 Yasuhiro Ohara <yasu@sfc.wide.ad.jp> * ospf6_neighbor.c: add the calling of ospf6_maxage_remove () when the neighbor went out of Exchange/Loading.
* [ospf6d] Import GNU Zebra CVSps#3559: Fix inter-area as-ext bug, cleanup debugpaul2006-05-157-70/+286
| | | | | | | | | 2005-10-06 Yasuhiro Ohara <yasu@sfc.wide.ad.jp> * ospf6_asbr.c: fix bug of calculating AS-External routes in other areas. Add debugging function for border-router calculation. * ospf6d.h: version 0.9.7p
* [bgpd] CID #4,#5,#9,#10, simplify aspath_print_vty usagepaul2006-05-124-30/+24
| | | | | | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * bgp_aspath.{c,h}: (aspath_print_vty) take a format string, so as to reduce burden on callers, all in bgp_route.c * bgp_route.c: (route_vty_out{,tmp}) Update to match aspath_print_vty, simplifying checks needed to get spacing right. CID #4,#5. ({damp,flap}_route_vty_out) Ditto, CID #9, #10
* [bgpd] CID #6, remove useless NULL check, bgp_static_update_rsclientpaul2006-05-122-6/+9
| | | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * bgp_route.c: (bgp_static_update_rsclient) Remove useless NULL check, code already assumes bgp_static can not be NULL, fixes CID #6.
* [bgpd] CID #7, remove useless NULL check, bgp_static_update_mainpaul2006-05-122-6/+11
| | | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * bgp_route.c: (bgp_static_update_main) Remove useless NULL check, code already assumes bgp_static can not be NULL, fixes CID #7.
* [bgpd] Remove dead code in ORIGINATOR_ID packet forming codepaul2006-05-122-7/+7
| | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity CID #1
* [lib] CID #55, fix return of freed pointer, cmd_describe_command_realpaul2006-05-122-2/+4
| | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * command.c: (cmd_describe_command_real) Fix return of freed pointer when no-match, CID #55.
* [lib] CID #39, fix leak in error path, vty_describe_commandpaul2006-05-122-8/+5
| | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * vty.c: (vty_describe_command) fix leak of describe vector in error path, CID #39.
* [lib] CID #37, fix error case leak, cmd_complete_command_realpaul2006-05-122-0/+3
| | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * command.c: (cmd_complete_command_real) Fix leak of cmd_vector in error case, Coverity CID #37.
* [lib] CID #3, fix forward-null errors in vty_prefix_list_uninstallpaul2006-05-122-0/+12
| | | | | | | 2006-05-12 Paul Jakma <paul.jakma@sun.com> * plist.c: (vty_prefix_list_uninstall) Fix potential NULL deref of prefix and typestr strings, Coverity CID #3.
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-03 21:48:31 +0000