summaryrefslogtreecommitdiffstats
path: root/bgpd
Commit message (Collapse)AuthorAgeFilesLines
* Be safer in bgp_terminateStephen Hemminger2009-05-081-2/+6
| | | | | bgp_terminate is used when process SIGHUP, clear workqueue references after freeing them.
* avoid zombie accepted peer entriesTimo Teräs2009-05-071-0/+2
| | | | | | | | | | | Currently, when accepting the connection, it can be left as zombie, when the peer just initiates a connection, but never sends data (and the TCP connection end packets are lost). This happens because for accepted connections a temporary new peer entry is created until OPEN message is exchanged, and this temporary peer entry does not get the hold time parameter set at all. Signed-off-by: Timo Teras <timo.teras@iki.fi>
* Fix "show ip bgp dampened-paths" garbage output.Chris Caputo2009-05-063-10/+8
| | | | | | | | | | | | | | | | | * bgpd/bgp_damp.c: Make bgp_damp_reuse_time_vty() accept a buffer and length, rather than returning a local var buffer whose contents can get trounced. Remove duplicate BGP_UPTIME_LEN define. * bgpd/bgp_damp.h: bgp_damp_reuse_time_vty() prototype change. * bgpd/bgp_route.c: Provide bgp_damp_reuse_time_vty() with a buffer and length. Remove duplicate BGP_UPTIME_LEN define. This problem was noticed in 2005... http://hibernia.jakma.org/~paul/patches/quagga-test.diff ...but the fix didn't make it into the code. Signed-off-by: Chris Caputo <ccaputo at alt.net>
* Compiler warning fixes for when --enable-snmp is configured.Chris Caputo2009-05-061-15/+22
| | | | | Compiled on 32-bit and 64-bit linux gcc 4.1.2 platforms. No run-time testing on 32-bit and limited run-time testing on 64-bit.
* Expanding asn path bufferStephen Hemminger2009-04-301-53/+27
| | | | | | | | Based on: [bgpd] AS4 bugfix by Chris Caputo <ccaputo@alt.net> * bgpd/bgp_aspath.c: (aspath_make_str_count) "assert (len < str_size)" was getting hit under certain 4-byte ASN conditions. New realloc strategy.
* Handle large ASN print formattingDenis Ovsienko2009-04-309-31/+31
| | | | | "%d" -> "%u" 4-byte ASN corrections. Prevent negative number when ASN is above 2^31.
* Align bgp with upstreamStephen Hemminger2009-02-096-4/+16
|
* Convert XMALLOC/memset to XCALLOCStephen Hemminger2009-02-092-16/+7
| | | | Simple conversion of XMALLOC/memset to XCALLOC
* whitespace fixStephen Hemminger2009-02-091-1/+1
|
* Merge branch 'vyatta-update' of /home/shemminger/src/quagga into jennerStephen Hemminger2009-02-0912-32/+32
|\
| * bgp: change () to (void)Stephen Hemminger2009-02-0912-32/+32
| | | | | | | | | | Use Ansi-C prototypes rather than old K&R method of declaring function without arguments
* | Use XCALLOC instead of XMALLOC/memsetStephen Hemminger2008-12-011-6/+2
| | | | | | | | A couple more trivial optimization.
* | Merge branch 'master' of /home/shemminger/src/quagga into jennerStephen Hemminger2008-12-011-0/+31
|\| | | | | | | | | | | Conflicts: lib/checksum.c
| * [bgpd] Add 'show bgp views' commandMichael Lambert2008-11-161-0/+31
| | | | | | | | | | | | | | | | * bgp_vty.c: (show_bgp_views_cmd) new command to list all defined views. (with small edits by Paul Jakma) Signed-off-by: Paul Jakma <paul@quagga.net>
* | Merge in latest quagga (0.99.11)Stephen Hemminger2008-10-2710-3999/+177
|\ \ | | | | | | | | | Merge in current upstream version of quagga.
| * | Merge branch 'master' of /home/shemminger/src/quagga into upstreamStephen Hemminger2008-10-1320-4032/+299
| |\| | | | | | | | | | Resolve all conflicts by using upstream version.
| | * Merge branch 'bgpd/fsm'Paul Jakma2008-10-021-4/+5
| | |\
| | | * [bgpd] Allow accepted peers to progress even if realpeer is in ConnectPaul Jakma2008-09-091-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * bgpd/bgp_packet.c: (bgp_open_receive) Try fix the little race in the FSM, where a accept-peer that progress faster than realpeer gets closed down if realpeer is still just in Connect, by allowing the realpeer to be bgp_stop'ed and doing the regular swapping-of-FSM state.
| | * | [bgpd] Fix definition of an rsclient commandMichael Lambert2008-09-241-1/+1
| | |/ | | | | | | | | | | | | | | | | | | * bgp_route.c: (show_ip_bgp_view_rsclient_route_cmd) Add the missing "ip" to the command string. Signed-off-by: Paul Jakma <paul@quagga.net>
| | * [bgpd] Document the FSM dummy-peer race that sometimes afflicts session setupPaul Jakma2008-09-061-0/+45
| | | | | | | | | | | | | | | | | | | | | * bgp_packet.c: (bgp_open_receive) the accept-peer hack can sometimes cause a race between two peers that try to establish sessions to each other, causing session setup to fail when it should have succeeded. In the worst case, the race can 'loop', causing prolonged failure to establish sessions.
| | * Merge branch 'restricted-mode'Paul Jakma2008-09-043-0/+96
| | |\
| | | * [vty] Add support for a 'restricted mode' with anonymous vty connectionsPaul Jakma2008-08-233-0/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * lib/command.h: Add a RESTRICTED_NODE, intended for use with anonymous, 'no login' vtys, to provide a subset of 'view' mode commands. * lib/command.c: Add RESTRICTED_NODE bits, nothing special, just following VIEW_NODE. * lib/vty.c: (vty_auth) enable authentication should fall back to restricted/view node as appropriate. (vty_create) init vty's to restricted/view node as appropriate, for the 'no login' case. (vty_{no_,}restricted_mode_cmd) config commands to enable 'anonymous restricted' in vty configuration. (vty_config_write) 'anonymous restricted' config. (vty_init) Install some commands to restricted mode, and the 'anonymous restricted' config commands into VTY_NODE. * bgpd/*.c: Install some of the safe(r) BGP commands into 'restricted mode', i.e. lookup commands of non-sensitive data. Useful with looking-glass route-servers.
| | | |
| | | \
| | *-. \ Merge commit 'remotes/jocke/ospf_neighbour'; commit ↵Paul Jakma2008-09-011-1/+3
| | |\ \ \ | | | | |/ | | | |/| | | | | | 'remotes/jocke/snmp_crosscompile'
| | | | * Make --enable-snmp cross compile and make libcrypto optional with ↵Joakim Tjernlund2008-08-251-1/+3
| | | |/ | | | | | | | | | | | | | | | | | | | | | | | | --without-crypto Autoconfig work by me, the rest was done by "Kirill K. Smirnov" <lich@math.spbu.ru>
| | * / Revert "[bgpd] Add 'bgp open-accept' option, to send OPEN immediately on ↵Paul Jakma2008-08-264-38/+1
| | |/ | | | | | | | | | | | | | | | | | | | | | accepted conns" Revert commit d664ae1182c29b74b409bc8594b7bd0575e91ce9. An experimental patch which violates RFC4271 quite badly, but managed to accidently sneak its way in.
| | * [administrivia] Update gitignore filesPaul Jakma2008-08-221-1/+1
| | | | | | | | | | | | - Add more stuff, archive libraries, etc..
| | * [administrivia] Git should ignore backup files and .loT filesPaul Jakma2008-08-221-0/+3
| | |
| | * [trivia] Remove ChangeLog files, as this data is now maintained in SCMPaul Jakma2008-08-221-3992/+0
| | |
| | * [bgpd] remove useless check and return in bgp_config_write_dampStephen Hemminger2008-08-222-26/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2008-08-17 Stephen Hemminger <stephen.hemminger@vyatta.com> * bgp_damp.?: (bgp_config_write_damp) remove useless check of statically allocated config storage, and useless return value Signed-off-by: Paul Jakma <paul@quagga.net>
| | * [warnings] Fix various SOS warningsPaul Jakma2008-08-223-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2008-08-15 Paul Jakma <paul.jakma@sun.com> * */*: Fix various problems flagged by Sun Studio compiler. - '<qualifier> <storage>' obsolescent in declarations - empty statements (';' after ALIAS definitions) - implicit declarations (e.g printstack in lib/log.c) - "\%" in printf string instead of "%%" - loops that return on the first iteration (legitimately, but compiler can't really know), e.g. bgp_routemap.c - internal declarations which mask prototypes.
| | * [lib] mes_lookup string lookup table argument should be marked constStephen Hemminger2008-08-221-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | 2008-08-14 Stephen Hemminger <stephen.hemminger@vyatta.com> * lib/log.{c,h}: struct message argument should point to const * */*.c: adjust to suit, Signed-off-by: Paul Jakma <paul@quagga.net>
| | * [lib] hash compare function arguments ought to be const qualifiedStephen Hemminger2008-08-228-40/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2008-08-14 Stephen Hemminger <stephen.hemminger@vyatta.com> * lib/hash.h: (struct hash) Hash comparator callback really ought to treat storage behind arguments as constant - a compare function with side-effects would be evil. * */*.c: Adjust comparator functions similarly, thus fixing at least a few compiler warnings about const qualifier being dropped. Signed-off-by: Paul Jakma <paul@quagga.net>
| | * [build] Test for GNU-style PIE support in toolchain and enablePaul P Komkoff Jr2008-08-221-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2008-08-13 Paul P Komkoff Jr <i@stingr.net> * configure.ac: add a configure flag and autoconf macro, which will determine if your toolchain supports PIE. * */Makefile.am: add corresponding CFLAGS and LDFLAGS into appropriate places. Signed-off-by: Paul Jakma <paul@quagga.net>
| | * [bgpd] Add 'bgp open-accept' option, to send OPEN immediately on accepted connsPaul Jakma2008-08-225-1/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2007-08-31 Paul Jakma <paul.jakma@sun.com> * (general) Add 'bgp open-accept' option, to allow bgpd to send OPEN on accepted connections, i.e. to not wait till after collision-detect to send OPEN, which appears to be allowed in RFC4271. This may help speed up establishing sessions, or help avoid FSM problems with sessions to certain peers. Not enabled by default though.
| | * [administrivia] Add .gitignore files, based on .cvsignores.Paul Jakma2008-08-221-0/+15
| | |
| | * [bgpd] Fix triggerable crash when compiled with --disable-bgp-announcequagga_cvs_finalcvs_headPaul Jakma2008-07-224-24/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2008-07-22 Paul Jakma <paul.jakma@sun.com> * HACKING: Document preference for compiler conditional code, over cpp conditional. * configure.ac: DISABLE_BGP_ANNOUNCE always should be defined. * bgp_{packet,route,advertise}.c: change to compiler testing of DISABLE_BGP_ANNOUNCE, rather than cpp. 2008-07-22 MIYAJIMA Mitsuharu <miyajima.mitsuharu@anchor.jp> * bgp_packet.c: (bgp_update_packet_eor) Fix crash triggerable if a bgpd was compiled with --disable-bgp-announce and if GR is advertised by peer.
| | * [bgpd] fix a couple of trivial compiler warningsPaul Jakma2008-07-225-17/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2008-07-22 Paul Jakma <paul.jakma@sun.com> * bgp_community.c: (community_str2com) assigns defaults to local vars * bgp_attr.c: (bgp_attr_parse) match format specifier to arg * bgp_table.{c,h}: (bgp_table_top) can take a * to a const, quelling warning in bgp_route.c
| | * [bgpd] TCP-MD5: password vty configuration and initial Linux supportPaul Jakma2008-07-217-5/+319
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2008-07-21 Paul Jakma <paul.jakma@sun.com> * bgp_packet.c: (bgp_open_receive) fix warning in a zlog call * bgp_vty.c: (bgp_vty_return) add return code * bgpd.c: (bgp_master_init) setup the socket list. * bgp_network.c: Remove the dual IPv4/6 socket thing for now, which was implemented by Michael, until such time as its clear its required for Linux (see sockopt comments). IPv6 support, including IPv4 sessions on AF_INET6 sockets, therefore is broken, and the '-l 0.0.0.0' arguments would need to be given to bgpd to make things work here. 2008-07-21 Michael H. Warfield <mhw@wittsend.com> YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Tomohiko Kusuda <kusuda@inetcore.com> Leigh Brown <leigh@solinno.co.uk> * bgp_network.c: (bgp_md5_set_one) shim between libzebra tcp-md5 sockopt and bgpd. (bgp_md5_set_socket) Helper for bgp_connect (bgp_md5_set) setup TCP-MD5SIG for the given peer. (bgp_connect) call out to bgp_md5_set_socket for the outgoing connect socket. (bgp_socket) save references to the listen sockets, needed if TCP-MD5SIG is applied later or changed. * bgp_vty.c: (*neighbor_password_cmd) New 'neighbor ... password' commands. * bgpd.c: (peer_{new,delete) manage TCP-MD5 password (peer_group2peer_config_copy) inherit TCP-MD5 password (peer_password_{un,}set) orchestrate the whole add/remove of TCP-MD5 passwords: applying checks, stopping peers, and trying to return errors to UI, etc. (bgp_config_write_peer) save password. Fix missing newline in writeout of neighbor ... port. 2008-07-21 Paul Jakma <paul.jakma@sun.com> * sockunion.c: ifdef out various places that converted v4mapped sockets to pure v4. Doesn't seem necessary at all, presumably a workaround for now historical inet_ntop bugs (?) 2008-07-21 Michael H. Warfield <mhw@wittsend.com> YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> * sockopt.{c,h}: (sockopt_tcp_signature) Add TCP-MD5SIG support.
| | * [vty] CMD_AS_RANGE accidently quoted and so not expanded in vtyPaul Jakma2008-07-023-49/+55
| | | | | | | | | | | | | | | | | | | | | 2008-07-02 MIYAJIMA Mitsuharu <miyajima.mitsuharu@anchor.jp> * *.c: CMD_AS_RANGE was being used inside command strings, and thus not being expanded, fix by dequoting.
| | * [bgpd] Fix double-free crash in bgp_table_finish, seen with rs-clientPaul Jakma2008-07-025-11/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2008-07-02 Stephen Hemminger <stephen.hemminger@vyatta.com> * bgp_table.{c,h}: (bgp_table_finish) Take a double pointer and scrub pointer in caller, so fixing double-free crashes seen with route-server-client configuration. * *.c: Adjust all callers of bgp_table_finish 2008-07-02 Paul Jakma <paul.jakma@sun.com> * bgp_table.{c,h}: (bgp_node_delete, bgp_table_free) shouldn't be exported.
| | * [bgpd] minor changes to bgp_mp_reach_parsePaul Jakma2008-06-073-13/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | 2008-06-07 Paul Jakma <paul@jakma.org> * bgp_attr.{c,h}: (bgp_mp_{un,}reach_parse) export, for unit tests. * bgp_attr.c: (bgp_mp_reach_parse) Add logging. Tighten length test to bounds check against the attribute length rather than the stream length..
| | * [bgpd] bug #419: partial aspath-limit incorrectly causes session resetPaul Jakma2008-06-012-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | 2008-06-01 jfletche@gmail.com * bgp_attr.c: (bgp_attr_aspathlimit) fix silly bug in flags check that was causing BGP to drop sessions if it received a aspath-limit with partial set. Fixes bug #419.
| | * [daemons] Sanity check port number arguments before usePaul Jakma2008-05-291-2/+8
| | | | | | | | | | | | | | | | | | 2008-05-29 Martin Nagy <mnagy@redhat.com> * */*main.c: Sanity check port numbers before using.
| | * + [bgpd] Added new route-map set statement: "as-path ignore"Denis Ovsienko2008-04-105-10/+211
| | |
| | * [bgpd] remove unnecessary 0 entries from struct message'sPaul Jakma2008-03-134-9/+5
| | | | | | | | | | | | | | | | | | | | | 2008-03-13 Paul Jakma <paul.jakma@sun.com> * (various) Remove 0 entries from struct message's, unneeded due to recent improvements in mes_lookup/LOOKUP.
| | * [bgpd] fix crash on startup if compiled IPv4-onlyPaul Jakma2008-01-292-5/+9
| | | | | | | | | | | | | | | | | | | | | 2008-01-29 Jorge Boncompte <jorge@dti2.net> * bgp_network.c: (bgp_socket) IPv4-only version crashes if -l is not used as address will be null.
| | * [bgpd] Fix number of DoS security issues, restricted to configured peers.Paul Jakma2007-12-225-8/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2007-12-22 Paul Jakma <paul.jakma@sun.com> * Fix series of vulnerabilities reported by "Mu Security Research Team", where bgpd can be made to crash by sending malformed packets - requires that bgpd be configured with a session to the peer. * bgp_attr.c: (bgp_attr_as4_path) aspath_parse may fail, only set the attribute flag indicating AS4_PATH if we actually managed to parse one. (bgp_attr_munge_as4_attrs) Assert was too general, it is possible to receive AS4_AGGREGATOR before AGGREGATOR. (bgp_attr_parse) Check that we have actually received the extra byte of header for Extended-Length attributes. * bgp_attr.h: Fix BGP_ATTR_MIN_LEN to account for the length byte. * bgp_open.c: (cap_minsizes) Fix size of CAPABILITY_CODE_RESTART, incorrect -2 left in place from a development version of as4-path patch. * bgp_packet.c: (bgp_route_refresh_receive) ORF length parameter needs to be properly sanity checked. * tests/bgp_capability_test.c: Test for empty capabilities.
| | * + fixed no_set_aspath_prepend() to correctly match existing "set" statementDenis Ovsienko2007-12-182-1/+16
| | |
| | * [bgpd] Fix typo in previous commit to bgp_main.cPaul Jakma2007-11-211-1/+1
| | |
| | * [bgpd] small fix for crash if 'listenon' argument is not givenPaul Jakma2007-11-132-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | 2007-11-13 Paul Jakma <paul.jakma@sun.com> * bgp_main.c: Small fix, format string parameters should never be NULL - it's not strictly valid and some libc's don't let you away with.
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-04 00:54:27 +0000