| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Bugfix 2847
Set TOS to internet control for BGP traffic
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from http://www.gossamer-threads.com/lists/quagga/dev/15611
[clear_shim] Re: [quagga-users 9315] New md5 signature patch for bgp... quagga_md5_bsd_linux_v9.diff Remove Highlighting [In reply to]
mhw at wittsend ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Jan 28, 2008, 12:55 PM And, of course, the moment I send off a patch against 0.99.9 and claim
it should patch the CVS, I find out it does not.
Post #2 of 3 (192
views) On Mon, 2008-01-28 at 14:50 -0500, Michael H. Warfield wrote:
Permalink > Hello all!
> Building on the efforts of Leigh Brown and the earlier works on an MD5
> signature patch for bgpd, I've incorporated the autoconf efforts by
> Sargun Dhillon on top of my own changes for IPv6 along with filling in a
> few missing spots in the autoconf stuff myself. Leigh had released a v7
> and I subsequently released a v8 patch for md5 signatures for Linux and
> BSD to deal with conflicts with IPv6. This is now a v9 patch
> incorporating some of the changes from Sargun and adding a few of my own
> to complete the autoconf changes.
> This patch is still against 0.99.9 but should patch cleanly against
> CVS.
Attached is the patch against CVS. It does NOT have a patch for
config.h.in (that was a mistake on my part, it's not in CVS, it's
generated but it's not regenerated if you are working from the releases
and don't rerun autoheader) and fixes a problem with a header file and
some alignments.
[cl] > This adds a configure option, --enable-tcp-md5, to enable tcp md5 [cl]
> signatures. This is not qualified against the operating system on which
> it is being built. The patch should work on BSD and Linux. Other
> operation systems are a crap shoot. I don't know. I presume some other
> errors will occur on other operating systems which do not support MD5
> signatures in this manner. Since they're not supported now, this is no
> great loss. Someone might want to test this in other environments,
> though, and enhance it for those other environments.
>
> Attached...
>
> quagga_md5_bsd_linux_v9.diff
>
> http://www.wittsend.com/mhw/md5sig/quagga_md5_bsd_linux_v9.diff
>
> Is there anything left that needs to be done before this can be
> committed to CVS? Can someone with commit privs please do the honors?
Mike
--
Michael H. Warfield (AI4NB) | (770) 985-6132 | mhw[at]WittsEnd.com
/\/\|=mhw=|\/\/ | (678) 463-0932 | http://www.wittsend.com/mhw/
NIC whois: MHW9 | An optimist believes we live in the best of all
PGP Key: 0xDF1DD471 | possible worlds. A pessimist is sure of it!
Attachments: [unknown] quagga_cvs_md5_bsd_linux_v9.diff (18.4 KB)
<http://www.gossamer-threads.com/lists/engine?do=post_attachment;postatt_id=1184;list=quagga>
[unknown] signature.asc (0.30 KB)
<http://www.gossamer-threads.com/lists/engine?do=post_attachment;postatt_id=1185;list=quagga>
Signed-off-by: Tom Grennan <tgrennan@vyatta.com>
|
| |
|
|
|
|
|
|
|
| |
2007-07-06 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
* sockopt.{c,h}: (setsockopt_multicast_ipv4) Add some comments about
the arguments.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* (general) extern and static'ification of functions in code and
header.
Cleanup any definitions with unspecified arguments.
Add casts for callback assignments where the callback is defined,
typically, as passing void *, but the function being assigned has
some other pointer type defined as its argument, as gcc complains
about casts from void * to X* via function arguments.
Fix some old K&R style function argument definitions.
Add noreturn gcc attribute to some functions, as appropriate.
Add unused gcc attribute to some functions (eg ones meant to help
while debugging)
Add guard defines to headers which were missing them.
* command.c: (install_node) add const qualifier, still doesnt shut
up the warning though, because of the double pointer.
(cmp_node) ditto
* keychain.c: (key_str2time) Add GET_LONG_RANGE() macro, derived
fromn vty.h ones to fix some of the (long) < 0 warnings.
* thread.c: (various) use thread_empty
(cpu_record_hash_key) should cast to uintptr_t, a stdint.h type
* vty.h: Add VTY_GET_IPV4_ADDRESS and VTY_GET_IPV4_PREFIX so they
removed from ospfd/ospf_vty.h
* zebra.h: Move definition of ZEBRA_PORT to here, to remove
dependence of lib on zebra/zserv.h
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in lib/zebra.h, ensure that RFC3542-required CMSG_SPACE and CMSG_LEN
are defined. Warn if alignment assumptions are made, since they are
i386-centric.
in lib/sockopt.h, declare that sockopt sizes are without
CMSG_SPACE-required padding - just simple sizeof.
in ospfd/ospf_packet.c, simply use CMSG_SPACE
This should remove all instances of CMSG_ALIGN from the source code.
This is a nonstandard, though rational, construct; quagga should use
only those defines in RFC3542.
|
|
|
|
| |
* sockopt.h: Fix elif that should be an else.
|
|
|
|
|
|
|
| |
* sockopt.c: (setsockopt_pktinfo) unexported
* sockopt.h: Cleanup SOCKOPT_CMSG defines a bit. Add a throwaway
define for SOPT_SIZE_CMSG_IFINDEX_IPV4 for systems which have
neither IP_RECVIF nor IP_PKTINFO (eg openbsd).
|
|
|
|
|
|
| |
* sockopt.{c,h}: add sockopt_iphdrincl_swab_{htosys,systoh},
functions to change byte order between system IP_HDRINCL order
and host order.
|
|
|
|
|
|
|
|
| |
* ripngd/ripngd.c: move setsockopt_so_recvbuf to lib.
* lib/sockopt.{c,h}: Add setsockopt_so_recvbuf, for ripd and ripngd.
* ripd/ripd.c: set receive buffer to a decent size, some systems
have low defaults. Problem noted and fix suggested by Stephan
Schweizer in [zebra 20967].
|
|
|
|
| |
Thanks to Hasso for code review.
|
|
|
|
|
| |
* sockopt.h: Define method-independent macro for callers of
get_ifindex to use for cmsg length.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2004-08-19 Paul Jakma <paul@dishone.st>
* sockopt.c: include sockopt.h
rename some of the _pktinfo_ functions to _ifindex, where that is
their purpose.
(getsockopt_ipv6_pktinfo_ifindex) renamed to
getsockopt_ipv6_ifindex.
(setsockopt_ipv4_pktinfo) renamed to setsockopt_ipv4_ifindex
(setsockopt_pktinfo) update with previous and add comment re
AF_INET portability.
(setsockopt_ifindex) generic ifindex function ala
setsockopt_pktinfo.
(getsockopt_ipv4_pktinfo_ifindex) renamed to
getsockopt_ipv4_ifindex.
(getsockopt_ipv4_ifindex) rejiggling to reduce repeated
ifdef/elses. pktinfo case forgot to set ifindex.
(getsockopt_pktinfo_ifindex) renamed to
getsockopt_ifindex. update some calls to renamed functions.
* sockopt.h: Update renamed exported functions
Rename the CMSG_SIZE macros to IFINDEX.
Guard IPv4 PKTINFO in a conditional define.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* sockopt.h: Add SOPT_SIZE_CMSG_PKTINFO{_IPV{4,6}} define, for
sizeof pktinfo as appropriate, to be used when allocating msg
buffers. export setsockopt_pktinfo() and
getsockopt_pktinfo_ifindex()
* sockopt.c: (setsockopt_pktinfo_ifindex) new function to portably
set received ifindex sock option.
(getsockopt_pktinfo_ifindex) portably retrieve ifindex.
(getsockopt_cmsg_data) retrieve indicated control info from
message header.
(getsockopt_ipv6_pktinfo_ifindex) ipv6 version of above.
(setsockopt_ipv4_pktinfo) v4 version
(setsockopt_pktinfo) the exported version
(getsockopt_ipv4_pktinfo_ifindex) v4 specific version
(getsockopt_pktinfo_ifindex) the exported version
|
|
|