summaryrefslogtreecommitdiffstats
path: root/ripd/ripd.c
Commit message (Collapse)AuthorAgeFilesLines
...
| * Sync with changes in lib. Make more strings const.hasso2004-10-111-5/+5
| |
| * There is no warnings here any more.hasso2004-10-081-8/+9
| |
| * Fix compiler warning.hasso2004-09-261-0/+1
| |
| * Remove usage of evil list and listnode typedefs.hasso2004-09-231-8/+8
| |
| * 2004-09-17 Paul Jakma <paul@dishone.st>paul2004-09-171-0/+5
| | | | | | | | | | | | | | | | * ripngd/ripngd.c: move setsockopt_so_recvbuf to lib. * lib/sockopt.{c,h}: Add setsockopt_so_recvbuf, for ripd and ripngd. * ripd/ripd.c: set receive buffer to a decent size, some systems have low defaults. Problem noted and fix suggested by Stephan Schweizer in [zebra 20967].
| * 2004-08-19 Paul Jakma <paul@dishone.st>paul2004-08-191-1/+1
| | | | | | | | | | | | | | | | | | * rip_interface.c: (rip_interface_multicast_set) get rid of extraneous if_pointopoint arg. ifp is accessible via connected. pass connected->ifp->ifindex to setsockopt_multicast_ipv4. * ripd.c: (rip_send_packet) update call to rip_interface_multicast_set * ripd.h: update rip_interface_multicast_set prototype
| * 2004-06-11 Sowmini Varadhan <sowmini.varadhan@sun.com>paul2004-06-111-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * filter.c: (access_list_remark_cmd) buffer_putstr doesnt need cast to u_char. (ipv6_access_list_remark_cmd) ditto. if.c: ditto * network.c: (readn/writen) pointer arg should be type u_char. * plist.c: needs to include stream.h, not declare stream functions internally. (various) Add static qualifier to internal functions. (prefix_list_type_str) extraneous breaks in switch statement. (ip_prefix_list_description_cmd) buffer_putstr doesnt need cast * stream.h: depends on plist.h and export stream_put_prefix * vty.c: (vty_<telnet option build functions>) should use unsigned char, telnet options are 0 -> 255. * zclient.c: various u_char<->char type cleanups. * zebra.h: Having to define CMSG_* can apply to more than just BSDI_NRL. * ripd.c: (rip_distribute_update_all) distribute list hook function pointer prototype requires struct prefix_list * arg. (rip_distribute_update_all_wrapper) update to pass required arg, NULL.
| * 2004-06-06 Paul Jakma <paul.jakma@sun.com>paul2004-06-061-49/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ripd.h: Add define for the RIPv2 Authentication Data family Move the auth type defines up to where other defines live. Add RIP_AUTH_MD5_COMPAT_SIZE, for backwards compatible md5->auth_len size. Add md5_auth_len field to struct rip_interface: (rip_interface_new) Init md5_auth_len to compatible size. (ip_rip_authentication_mode_cmd) Extended to handle setting md5 auth-length. Appropriate aliases added. (no_ip_rip_authentication_mode_cmd) Reset md5_auth_len to compatible size. (rip_interface_config_write) Teach it about md5_auth_len. _always_ write out the auth-length, so that everyone will get the setting in their config file, and hence allow for a future change of default for md5_auth_len to be less painful - every md5 user will have this setting in their config file. ripd.c: (rip_packet_dump) Change nasty hard coded constants to symbolic defines. Change various tests of 'ntoh.(variable) == constant' to test 'variable == ntoh.(constant)'. Clean up indentation on some long lines. (rip_auth_simple_password) ditto. (rip_auth_md5) ditto, also add length argument and sanity check md5 data offset field. Sanity check md5 auth length, accept RFC or old-ripd/cisco lengths. (rip_auth_md5_set) as per (rip_packet_dump), also write out the configured md5 auth length for the interface (old-ripd or rfc) (rip_read) as per (rip_packet_dump) (rip_write_rte) ditto (rip_response_process) ditto (rip_write_rte) ditto
| * 2004-06-04 JJ Ludman <jacques.ludman@sun.com>paul2004-06-041-3/+13
| | | | | | | | | | | | * ripd.c: Interoperability fix. Correct value for MD5 auth length is 16. Accept packets with this set to >= 16, and set to 16 ourselves.
| * 2004-05-31 Sowmini Varadhan <sowmini.varadhan@sun.com>paul2004-05-311-12/+21
| | | | | | | | | | * ripd.c: Fixup compile warnings * rip_routemap.c: Ditto
| * 2004-05-05 Anthony.Golia@morganstanley.compaul2004-05-051-1/+16
| | | | | | | | | | * ripd.c: (rip_update_jitter) Bound jitter to a more sensible value, eg 1/4 of update time.
| * 2004-05-03 Paul Jakma <paul@dishone.st>paul2004-05-031-172/+171
| | | | | | | | | | * ripd.c: (rip_rte_process) fix typo in merge of previous patch and run function through indent.
| * 2004-03-19 Jean-Yves Simon <lethalwp@tiscali.be>paul2004-05-011-5/+19
| | | | | | | | | | * ripd.c: make ripd also check on administrative distance of his own links to update routes.
| * From Sowmini fix for crash reported in [quagga-dev 929].hasso2004-03-181-2/+3
| |
| * [quagga-dev 489] - fix ripd version send by Krzysztof Oledzki.hasso2004-03-031-2/+2
| |
| * "show ip rip" fix from Krzysztof Oledzki ([quagga-dev 437]).hasso2004-03-031-2/+2
| |
| * Fix typo in comment.hasso2004-02-221-1/+1
| |
| * 2004-01-23 sowmini.varadhan@sun.compaul2004-01-231-30/+101
| | | | | | | | | | | | | | | | | | | | | | | | | | * rip_interface.c: obsolete unbind code in rip_interface_multicast_set, and instead do the more portable (though slower) method of creating a socket for each outgoing packet and binding the source address on the new socket. * rip_interface.c, ripd.c, ripd.h: Modify rip_request_send so that source address is determined by the caller of rip_request_send for ripv1 packets and non-multicast interfaces (rip_request_send loops over all connected address in all other cases). * rip_send_packet: don't send packets with source set to ZEBRA_IFA_SECONDARY connected addresses; improved debug messages;
| * 2003-11-17 sowmini.varadhan@sun.compaul2003-11-171-5/+28
| | | | | | | | | | * ripd/ripd.c: rip_output_process() fixup aspects of split-horizon route suppression. See [quagga-dev 429].
| * 2003-11-17 Hasso Tepper <hasso@estpak.ee>paul2003-11-171-0/+2
| | | | | | | | | | * ripd/ripd.c: rip_create_socket() privs were not dropped if bind failed.
| * 2003-10-15 sowmini.varadhan@sun.compaul2003-10-151-29/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * ripd/ripd.c: (rip_send_packet) use rip->sock for mcast sends, instead of creating one socket per send. send source addr to rip_update_interface. (rip_update_process) should send an update on every connected network for each interface. (rip_request_send) should send a request on every connected network for each interface. * ripd/ripd.h: update prototype for rip_interface_multicast_set * ripd/rip_interface.c: (rip_interface_multicast_set) reorganized so that it can be called repeatedly for aliased interfaces (on multiple networks).
| * 2003-09-29 Paul Jakma <paul@dishone.st>paul2003-09-291-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * zebra/connected.c: revert the 'generic PtP' patch as it causes far too many problems. People who use FreeSWAN should investigate native linux ipsec. * zebra/rt_netlink.c: ditto * lib/if.c: ditto * ripd/ripd.h: ditto * ripd/ripd.c: ditto * ripd/rip_interface.c: ditto * ospfd/ospfd.c: ditto * ospfd/ospf_snmp.c: ditto * bgpd/bgp_nexthop.c: ditto
| * 2003-06-08 Paul Jakma <paul@dishone.st>paul2003-06-081-5/+5
| | | | | | | | Compile and warning fixes for the ripd 'passive-interface default' patch.
| * From: Andrew J. Schorr <aschorr@telemetry-investments.com>paul2003-06-071-40/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Subject: [zebra 12403] patch for ripd to accept any version of RIP by default The default Cisco IOS behavior is to send RIP version 1 packets and receive version 1 and version 2 packets. But zebra version 0.92a sends and receives only version 2 packets by default. I have patched the code to change zebra's default behavior to sending version 2 packets (same as before) but receiving both versions. While this is still not identical to Cisco's behavior, it does now accept packets of both versions and retains backwards compatibility with zebra configurations.
| * From: Andrew J. Schorr <aschorr@telemetry-investments.com>paul2003-06-071-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | Subject: [zebra 12406] patch for ripd to support "passive-interface default" behavior In Cisco IOS, the router rip passive-interface subcommand can accept an interface name of "default". In that cases, all interfaces are set to be passive by default, and you must explicitly make it non-passive by using the "no passive-interface <ifname>" command if you want updates to go to that interface. <command implemented for zebra>
| * 2003-06-04 Paul Jakma <paul@dishone.st>paul2003-06-041-1/+8
| | | | | | | | * Merge of zebra privileges
| * Merge RIP part of 6Wind patch.hasso2003-05-251-39/+241
| |
| * [zebra 14631] Generic PtP and RFC3021 interface addressing supportpatch_z14631_ptp_rfc3021paul2002-12-131-2/+2
| |
| * zebra link state detection supportpatch_z12269_linkstatepaul2002-12-131-1/+1
| |
| * Added RIPv1 patch - bug fixes and improved/more interoperable classfulpatch_z15769_ripv1paul2002-12-131-31/+101
| | | | | | | | subnet handling
| * Initial revisionpaul2002-12-131-0/+3536
|
* Use XCALLOCStephen Hemminger2008-08-181-11/+3
| | | | Replace calls to XMALLOC followed by memset with XCALLOC.
* Make command nodes staticStephen Hemminger2008-08-111-1/+1
| | | | | The cmd_nodes used to configure vty, can mostly be static so (basic data hiding 101).
* Make log message lookup function use const tablesStephen Hemminger2008-08-011-2/+3
| | | | Message tables should be unaltered.
* comment out unused codeStephen Hemminger2008-05-281-0/+2
| | | | remove unused code, compiler flags this as unused
* Handle empty auth string properlyStephen Hemminger2008-05-281-1/+1
| | | | | | | | | | | Compiler warned about dubious code where test was: char auth_str[]; ... if (!auth_str) return 0; Looks like what was meant was testing for empty auth string.
* [ripd] remove unnecessary 0 entries from struct message'spaul2008-03-131-1/+0
| | | | | | | | 2008-03-13 Paul Jakma <paul.jakma@sun.com> * ripd.c/rip_interface.c: Remove 0 entries from rip_msg ri_version_msg struct message's, not needed with recent fixes to mes_lookup.
* [autoconf] bugs 162,303,178: Fix 'present but can not be compiled' warningspaul2007-05-101-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | 2007-05-09 Paul Jakma <paul.jakma@sun.com> * configure.ac: sys/conf.h depends on sys/param.h, at least on FBSD 6.2. (bug #363) Should check for in_pktinfo for IRDP 2006-05-27 Paul Jakma <paul.jakma@sun.com> * configure.ac: General cleanup of header and type checks, introducing an internal define, QUAGGA_INCLUDES, to build up a list of stuff to include so as to avoid 'present but cant be compiled' warnings. Misc additional checks of things missing according to autoscan. Add LIBM, for bgpd's use of libm, so as to avoid burdening LIBS, and all the binaries, with libm linkage. Remove the bad practice of using m4 changequote(), just quote the []'s in the case statements properly. This should fix bugs 162, 303 and 178. * */*.{c,h}: Update all HAVE_* to the standard autoconf namespaced HAVE_* defines. I.e. HAVE_SA_LEN -> HAVE_STRUCT_SOCKADDR_SA_LEN, * bgpd/Makefile.am: Add LIBM to bgpd's LDADD, for pow().
* [ripd, ripngd] Remove useless code in rip_vty_out_uptime functionajs2007-04-271-3/+0
| | | | | | | | 2007-04-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * ripd/ripd.c: (rip_vty_out_uptime) Remove unused variable timer_now. * ripngd/ripngd.c: (ripng_vty_out_uptime) Remove unused variable timer_now.
* Fix the display of route timeout in "show ip rip". (Use ↵vincent2007-04-111-2/+2
| | | | thread_timer_remain_second)
* [ripd] Fix "show ip rip status" display of time until next updateajs2007-03-211-13/+2
| | | | | | | | | 2007-03-21 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * ripd.c: (show_ip_rip_status) Use new thread_timer_remain_second function instead of rip_next_thread_timer to display the time until next update properly. (rip_next_thread_timer) Remove obsolete function.
* [PtP over ethernet] New peer flag allows much more addressing flexibilityajs2006-12-121-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * if.h: (struct connected) Add new ZEBRA_IFA_PEER flag indicating whether a peer address has been configured. Comment now shows the new interpretation of the destination addr: if ZEBRA_IFA_PEER is set, then it must contain the destination address, otherwise it may contain the broadcast address or be NULL. (CONNECTED_DEST_HOST,CONNECTED_POINTOPOINT_HOST) Remove obsolete macros that were specific to IPv4 and not fully general. (CONNECTED_PEER) New macro to check ZEBRA_IFA_PEER flag. (CONNECTED_PREFIX) New macro giving the prefix to insert into the RIB: if CONNECTED_PEER, then use the destination (peer) address, else use the address field. (CONNECTED_ID) New macro to come up with an identifying address for the struct connected. * if.c: (if_lookup_address, connected_lookup_address) Streamline logic with new CONNECTED_PREFIX macro. * prefix.h: (PREFIX_COPY_IPV4, PREFIX_COPY_IPV6) New macros for better performance than the general prefix_copy function. * zclient.c: (zebra_interface_address_read) For non-null destination addresses, set prefixlen to equal the address prefixlen. This is needed to get the new CONNECTED_PREFIX macro to work properly. * connected.c: (connected_up_ipv4, connected_down_ipv4, connected_up_ipv6, connected_down_ipv6) Simplify logic using the new CONNECTED_PREFIX macro. (connected_add_ipv4) Set prefixlen in destination addresses (required by the CONNECTED_PREFIX macro). Use CONNECTED_PEER macro instead of testing for IFF_POINTOPOINT. Delete invalid warning message. Warn about cases where the ZEBRA_IFA_PEER is set but no destination address has been supplied (and turn off the flag). (connected_add_ipv6) Add new flags argument so callers may set the ZEBRA_IFA_PEER flag. If peer/broadcast address satisfies IN6_IS_ADDR_UNSPECIFIED, then reject it with a warning. Set prefixlen in destination address so CONNECTED_PREFIX will work. * connected.h: (connected_add_ipv6) Add new flags argument so callers may set the ZEBRA_IFA_PEER flag. * interface.c: (connected_dump_vty) Use CONNECTED_PEER macro to decide whether the destination address is a peer or broadcast address (instead of checking IFF_BROADCAST and IFF_POINTOPOINT). * if_ioctl.c: (if_getaddrs) Instead of setting a peer address only when the IFF_POINTOPOINT is set, we now accept a peer address whenever it is available and not the same as the local address. Otherwise (no peer address assigned), we check for a broadcast address (regardless of the IFF_BROADCAST flag). And must now pass a flags value of ZEBRA_IFA_PEER to connected_add_ipv4 when a peer address is assigned. The same new logic is used with the IPv6 code as well (and we pass the new flags argument to connected_add_ipv6). (if_get_addr) Do not bother to check IFF_POINTOPOINT: just issue the SIOCGIFDSTADDR ioctl and see if we get back a peer address not matching the local address (and set the ZEBRA_IFA_PEER in that case). If there's no peer address, try to grab SIOCGIFBRDADDR regardless of whether IFF_BROADCAST is set. * if_ioctl_solaris.c: (if_get_addr) Just try the SIOCGLIFDSTADDR ioctl without bothering to check the IFF_POINTOPOINT flag. And if no peer address was found, just try the SIOCGLIFBRDADDR ioctl without checking the IFF_BROADCAST flag. Call connected_add_ipv4 and connected_add_ipv6 with appropriate flags. * if_proc.c: (ifaddr_proc_ipv6) Must pass new flags argument to connected_add_ipv6. * kernel_socket.c: (ifam_read) Must pass new flags argument to connected_add_ipv6. * rt_netlink.c: (netlink_interface_addr) Copy logic from iproute2 to determine local and possible peer address (so there's no longer a test for IFF_POINTOPOINT). Set ZEBRA_IFA_PEER flag appropriately. Pass new flags argument to connected_add_ipv6. (netlink_address) Test !CONNECTED_PEER instead of if_is_broadcast to determine whether the connected destination address is a broadcast address. * bgp_nexthop.c: (bgp_connected_add, bgp_connected_delete) Simplify logic by using new CONNECTED_PREFIX macro. * ospf_interface.c: (ospf_if_is_configured, ospf_if_lookup_by_prefix, ospf_if_lookup_recv_if) Simplify logic using new CONNECTED_PREFIX macro. * ospf_lsa.c: (lsa_link_ptop_set) Using the new CONNECTED_PREFIX macro, both options collapse into the same code. * ospf_snmp.c: (ospf_snmp_if_update) Simplify logic using new CONNECTED_ID macro. (ospf_snmp_is_if_have_addr) Simplify logic using new CONNECTED_PREFIX macro. * ospf_vty.c: (show_ip_ospf_interface_sub) Use new CONNECTED_PEER macro instead of testing the IFF_POINTOPOINT flag. * ospfd.c: (ospf_network_match_iface) Use new CONNECTED_PEER macro instead of testing with if_is_pointopoint. And add commented-out code to implement alternative (in my opinion) more elegant behavior that has no special-case treatment for PtP addresses. (ospf_network_run) Use new CONNECTED_ID macro to simplify logic. * rip_interface.c: (rip_interface_multicast_set) Use new CONNECTED_ID macro to simplify logic. (rip_request_interface_send) Fix minor bug: ipv4_broadcast_addr does not give a useful result if prefixlen is 32 (we require a peer address in such cases). * ripd.c: (rip_update_interface) Fix same bug as above.
* [ripd] bug #278: remove gratuitous use of mid-function declarationpaul2006-09-111-2/+3
| | | | | | | 2006-09-11 Paul Jakma <paul.jakma@sun.com> * ripd.c: (rip_read) remove gratuitous use of mid-function declaration of vrecv, bug #278.
* [ripd] bugs #261, #262: Fix RIPv1 info-leak and unauthenticated route updatespaul2006-05-041-102/+103
| | | | | | | | | | | | | | | | | | 2006-05-04 Paul Jakma <paul.jakma@sun.com> * (general) Fixes for bugs #261 and 262. Thanks to Konstantin V. Gavrilenko <kos@arhont.com> for the problem reports, testing of a series of proposed patches and comment on the proposed changes in behaviour. * rip_interface.c: (ip_rip_authentication_mode_cmd) Parse all of the command before making any changes to configured state. * ripd.c: (rip_read) RIP version control should be absolute and always apply, fixes bug #261 by allowing RIPv1 to be disabled. Fix bug #262: If authentication is enabled, then unauthenticated packets should not be accepted. We do however make an exception for RIPv1 REQUEST packets, to which we will reply as RIPv1 can now be disabled fully, to allow ripd to still provide routing /information/ to simple devices.
* [ripd] Fix logic to send updates on all connected addresses.ajs2006-04-281-31/+17
| | | | | | | | | | | | | 2006-04-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * ripd.c: (rip_update_process) Try to fix the logic for sending an updated on each connected network. The new code will attempt to send the update on each connected network, whereas the previous code seemed to be attempting to avoid sending more than one RIPv1 update on a given interface, but was coded incorrectly. The actual effect of the old code was to send an update only on the first connected address in the cases where the interface is not multicast, or RIPv2 is not being used.
* ripd.c: correct bug that allowed route learnt through RIP to take precedence ↵vincent2006-01-301-1/+3
| | | | over connected routes
* [ripd] Fix verification of received MD5 authenticated packetspaul2006-01-171-23/+17
| | | | | | | | | | | | | | | | | | 2006-01-17 Paul Jakma <paul.jakma@sun.com> * ripd.c: (rip_auth_md5) remove pdigest, not needed. Use a local buffer for the auth_str, where it can be properly nul padded. Do so, hence fixing MD5 authentication. Key looked up via key ring should be used in preference to the RIPv1 simple password, not other way around. No need to copy around digests, we can reference them directly. The auth_len received can't be trusted, some implementations lie (e.g. older ripd). (rip_auth_md5_ah_write) rename len local variable to doff to be consistent with other functions. (rip_auth_header_write) add the missing return. (rip_auth_md5_set) use the proper constructs to access stream.
* 2005-10-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>ajs2005-10-301-2/+2
| | | | | | | | | * ripd.c: (rip_response_process) Instead of calling rip_interface.c:if_valid_neighbor(), call the equivalent library function if_lookup_address(). * rip_interface.c: (if_valid_neighbor) Remove function, since it is essentially equivalent to the if_lookup_address() library function. * ripd.h: (if_valid_neighbor) Remove function declaration.
* 2005-10-26 Paul Jakma <paul.jakma@sun.com>paul2005-10-251-6/+6
| | | | | * ripd.c: Update couple more functions to specify void explicitely.
* 2005-10-26 Paul Jakma <paul.jakma@sun.com>paul2005-10-251-50/+51
| | | | | | * (general) static/extern functions and definitions. * rip_interface.h: new file, export the public functions from rip_interface.c
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-04 17:00:00 +0000