From 6f0e3f6e17687eb25b7b77c4fdc8324837d4700f Mon Sep 17 00:00:00 2001 From: Paul Jakma Date: Thu, 10 May 2007 02:38:51 +0000 Subject: [autoconf] bugs 162,303,178: Fix 'present but can not be compiled' warnings 2007-05-09 Paul Jakma * configure.ac: sys/conf.h depends on sys/param.h, at least on FBSD 6.2. (bug #363) Should check for in_pktinfo for IRDP 2006-05-27 Paul Jakma * configure.ac: General cleanup of header and type checks, introducing an internal define, QUAGGA_INCLUDES, to build up a list of stuff to include so as to avoid 'present but cant be compiled' warnings. Misc additional checks of things missing according to autoscan. Add LIBM, for bgpd's use of libm, so as to avoid burdening LIBS, and all the binaries, with libm linkage. Remove the bad practice of using m4 changequote(), just quote the []'s in the case statements properly. This should fix bugs 162, 303 and 178. * */*.{c,h}: Update all HAVE_* to the standard autoconf namespaced HAVE_* defines. I.e. HAVE_SA_LEN -> HAVE_STRUCT_SOCKADDR_SA_LEN, * bgpd/Makefile.am: Add LIBM to bgpd's LDADD, for pow(). --- ospfclient/ospf_apiclient.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'ospfclient') diff --git a/ospfclient/ospf_apiclient.c b/ospfclient/ospf_apiclient.c index 09d90b3a..64b83123 100644 --- a/ospfclient/ospf_apiclient.c +++ b/ospfclient/ospf_apiclient.c @@ -118,9 +118,9 @@ ospf_apiclient_connect (char *host, int syncport) myaddr_async.sin_addr.s_addr = htonl (INADDR_ANY); myaddr_async.sin_port = htons (syncport+1); size = sizeof (struct sockaddr_in); -#ifdef HAVE_SIN_LEN +#ifdef HAVE_STRUCT_SOCKADDR_IN_SIN_LEN myaddr_async.sin_len = size; -#endif /* HAVE_SIN_LEN */ +#endif /* HAVE_STRUCT_SOCKADDR_IN_SIN_LEN */ /* This is a server socket, reuse addr and port */ ret = setsockopt (async_server_sock, SOL_SOCKET, @@ -209,9 +209,9 @@ ospf_apiclient_connect (char *host, int syncport) memset (&myaddr_sync, 0, sizeof (struct sockaddr_in)); myaddr_sync.sin_family = AF_INET; myaddr_sync.sin_port = htons (syncport); -#ifdef HAVE_SIN_LEN +#ifdef HAVE_STRUCT_SOCKADDR_IN_SIN_LEN myaddr_sync.sin_len = sizeof (struct sockaddr_in); -#endif /* HAVE_SIN_LEN */ +#endif /* HAVE_STRUCT_SOCKADDR_IN_SIN_LEN */ ret = bind (fd1, (struct sockaddr *) &myaddr_sync, size); if (ret < 0) @@ -225,9 +225,9 @@ ospf_apiclient_connect (char *host, int syncport) memcpy (&myaddr_sync.sin_addr, hp->h_addr, hp->h_length); myaddr_sync.sin_family = AF_INET; myaddr_sync.sin_port = htons(ospf_apiclient_getport ()); -#ifdef HAVE_SIN_LEN +#ifdef HAVE_STRUCT_SOCKADDR_IN_SIN_LEN myaddr_sync.sin_len = sizeof (struct sockaddr_in); -#endif /* HAVE_SIN_LEN */ +#endif /* HAVE_STRUCT_SOCKADDR_IN_SIN_LEN */ /* Now establish synchronous channel with OSPF daemon */ ret = connect (fd1, (struct sockaddr *) &myaddr_sync, -- cgit v1.2.3 From 3c5a0a4f8fe3811affff6d5e123379eedb083571 Mon Sep 17 00:00:00 2001 From: Paul Jakma Date: Sun, 19 Feb 2006 17:30:10 +0000 Subject: [administrivia] Add .gitignore files, based on .cvsignores. --- ospfclient/.gitignore | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 ospfclient/.gitignore (limited to 'ospfclient') diff --git a/ospfclient/.gitignore b/ospfclient/.gitignore new file mode 100644 index 00000000..d6de29ab --- /dev/null +++ b/ospfclient/.gitignore @@ -0,0 +1,13 @@ +Makefile +Makefile.in +*.o +ospfclient +tags +TAGS +.deps +.nfs* +*.lo +*.la +*.libs +.arch-inventory +.arch-ids -- cgit v1.2.3 From 46bc0e432e756fcb8fc4f703b47cd25b9fc7139c Mon Sep 17 00:00:00 2001 From: Paul P Komkoff Jr Date: Wed, 13 Aug 2008 16:17:04 +0100 Subject: [build] Test for GNU-style PIE support in toolchain and enable 2008-08-13 Paul P Komkoff Jr * configure.ac: add a configure flag and autoconf macro, which will determine if your toolchain supports PIE. * */Makefile.am: add corresponding CFLAGS and LDFLAGS into appropriate places. Signed-off-by: Paul Jakma --- ospfclient/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) (limited to 'ospfclient') diff --git a/ospfclient/Makefile.am b/ospfclient/Makefile.am index ab2a3786..b8aae84b 100644 --- a/ospfclient/Makefile.am +++ b/ospfclient/Makefile.am @@ -21,4 +21,6 @@ ospfclient_SOURCES = \ ospfclient_LDADD = libospfapiclient.la \ ../ospfd/libospf.la ../lib/libzebra.la @LIBCAP@ +ospfclient_CFLAGS = $(AM_CFLAGS) $(PICFLAGS) +ospfclient_LDFLAGS = $(AM_LDFLAGS) $(PILDFLAGS) -- cgit v1.2.3 From 30a2231a4881f53deca61ef7a62b225a43dab4c5 Mon Sep 17 00:00:00 2001 From: Paul Jakma Date: Fri, 15 Aug 2008 14:05:22 +0100 Subject: [warnings] Fix various SOS warnings 2008-08-15 Paul Jakma * */*: Fix various problems flagged by Sun Studio compiler. - ' ' obsolescent in declarations - empty statements (';' after ALIAS definitions) - implicit declarations (e.g printstack in lib/log.c) - "\%" in printf string instead of "%%" - loops that return on the first iteration (legitimately, but compiler can't really know), e.g. bgp_routemap.c - internal declarations which mask prototypes. --- ospfclient/ospfclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ospfclient') diff --git a/ospfclient/ospfclient.c b/ospfclient/ospfclient.c index b0056155..ef1d22b4 100644 --- a/ospfclient/ospfclient.c +++ b/ospfclient/ospfclient.c @@ -121,7 +121,7 @@ lsa_inject (struct thread *t) counter++; return 0; -}; +} /* This thread handles asynchronous messages coming in from the OSPF -- cgit v1.2.3 From 3998bfd76620a676fbd77f19c5c6ea80a4cc88d2 Mon Sep 17 00:00:00 2001 From: Paul Jakma Date: Tue, 19 Aug 2008 14:13:43 +0100 Subject: [trivia] Remove ChangeLog files, as this data is now maintained in SCM --- ospfclient/ChangeLog | 71 ---------------------------------------------------- 1 file changed, 71 deletions(-) delete mode 100644 ospfclient/ChangeLog (limited to 'ospfclient') diff --git a/ospfclient/ChangeLog b/ospfclient/ChangeLog deleted file mode 100644 index e678affd..00000000 --- a/ospfclient/ChangeLog +++ /dev/null @@ -1,71 +0,0 @@ -2005-11-24 Paul Jakma - - * ospf_apiclient.c: add static qualifier to relevant functions. - * ospfclient.c: ditto - -2005-04-20 Paul Jakma - - * Makefile.am: Add @INCLUDES@ and srcdir to allow out-of-tree - builds to work. - -2004-06-30 Greg Troxel - - * Makefile.am: Add libtool/shlib support. - -2003-01-10 Ralph Keller - * New ChangeLog - -2003-01-08 Ralph Keller - * apiclient message passing bug resolved - * (proposed by Masahiko) - -2002-10-09 Ralph Keller - * Includes patch in OSPFd for ISM, NSM, neighbor - -2002-09-16 Ralph Keller - * Current patch vs. Zebra-0.93b - -2002-08-22 Ralph Keller - * Bugfix: LSA updates are now received only once even - * if multiple opaque types are registered - -2002-08-06 Ralph Keller - * Upgrade of OSPF API to Zebra-0.93a. - -2002-06-13 Ralph Keller - * Opaque LSA origination bug fixed by Masahiko. - * This code is based on 0.93-pre - -2002-05-03 Ralph Keller - * Upgrade to newest Zebra from CVS repository. ospf_flood_through - * function did not work after upgrade. Function - * ospf_apiserver_flood_opaque_lsa added. Also byte order problem - * with port numbers resolved. - -2002-05-02 Ralph Keller - - * new autoconf and automake files, now called configure.in - * instead of configure.ac - -2002-04-24 Ralph Keller - - * reverse channel now works (syncport and syncport+1) - * ospf_apiclient.c: standard includes removed (not needed) - * bzero replaced with memset - -2002-04-18 Ralph Keller - - * 2-way phase connection setup - -2002-04-05 Ralph Keller - - * Changes incorporated as proposed by Masahiko - -2002-04-05 Ralph Keller - - * autoconf and automake-style Makefile - -2002-04-04 Ralph Keller - - * 1st public release of OSPF API - -- cgit v1.2.3 From d68cbf9261869e532dfdd14dbb4122b3f3feb0d4 Mon Sep 17 00:00:00 2001 From: Paul Jakma Date: Sat, 21 Oct 2006 18:35:27 +0100 Subject: [administrivia] Git should ignore backup files and .loT files --- ospfclient/.gitignore | 3 +++ 1 file changed, 3 insertions(+) (limited to 'ospfclient') diff --git a/ospfclient/.gitignore b/ospfclient/.gitignore index d6de29ab..191322b6 100644 --- a/ospfclient/.gitignore +++ b/ospfclient/.gitignore @@ -11,3 +11,6 @@ TAGS *.libs .arch-inventory .arch-ids +*~ +*.loT + -- cgit v1.2.3