Fix a potential memleak if two threads fingerprint a credential simultaneously

1 files changed, 6 insertions, 1 deletions

diff --git a/src/libstrongswan/credentials/cred_encoding.c b/src/libstrongswan/credentials/cred_encoding.c
index edd76205b..ac3266f4c 100644
--- a/src/libstrongswan/credentials/cred_encoding.c
+++ b/src/libstrongswan/credentials/cred_encoding.c
@@ -180,8 +180,13 @@ static bool encode(private_cred_encoding_t *this, cred_encoding_type_t type,
 		chunk = malloc_thing(chunk_t);
 		*chunk = *encoding;
 		this->lock->write_lock(this->lock);
-		this->cache[type]->put(this->cache[type], cache, chunk);
+		chunk = this->cache[type]->put(this->cache[type], cache, chunk);
 		this->lock->unlock(this->lock);
+		if (chunk)
+		{
+			free(chunk->ptr);
+			free(chunk);
+		}
 	}
 	return success;
 }