From 7a07cd1c75839a0d6d53b5462b9fd40f7608e47e Mon Sep 17 00:00:00 2001 From: Andreas Steffen Date: Tue, 7 Oct 2008 21:41:45 +0000 Subject: fixed loop termination criterion in addr_in_subnet(). Thanks go to Wolfgang Steudel, TU Ilmenau --- src/charon/plugins/kernel_netlink/kernel_netlink_net.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/charon/plugins/kernel_netlink/kernel_netlink_net.c b/src/charon/plugins/kernel_netlink/kernel_netlink_net.c index f14776287..6e1489c81 100644 --- a/src/charon/plugins/kernel_netlink/kernel_netlink_net.c +++ b/src/charon/plugins/kernel_netlink/kernel_netlink_net.c @@ -698,14 +698,16 @@ static bool addr_in_subnet(chunk_t addr, chunk_t net, int net_len) /* scan through all bits, beginning in the front */ for (byte = 0; byte < addr.len; byte++) { - for (bit = 7; bit >= 0; bit--) + for (bit = 0; bit < 8; bit++) { + u_char bitpos = 1 << (7-bit); + /* check if bits are equal (or we reached the end of the net) */ if (bit + byte * 8 > net_len) { return TRUE; } - if (((1<