1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
|
--- a/arch/um/drivers/mconsole_kern.c 2008-07-13 23:51:29.000000000 +0200
+++ b/arch/um/drivers/mconsole_kern.c 2008-10-07 11:03:31.000000000 +0200
@@ -4,6 +4,7 @@
* Licensed under the GPL
*/
+#include "linux/kmod.h"
#include <linux/console.h>
#include <linux/ctype.h>
#include <linux/interrupt.h>
@@ -18,6 +19,8 @@
#include <linux/utsname.h>
#include <linux/workqueue.h>
#include <linux/mutex.h>
+#include <linux/completion.h>
+#include <linux/file.h>
#include <asm/uaccess.h>
#include "init.h"
@@ -199,6 +202,65 @@
}
#endif
+void mconsole_exec(struct mc_request *req)
+{
+ DECLARE_COMPLETION_ONSTACK(done);
+ struct subprocess_info *sub_info;
+ int res, len;
+ struct file *out;
+ char buf[MCONSOLE_MAX_DATA];
+
+ char *envp[] = {
+ "HOME=/", "TERM=linux",
+ "PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin",
+ NULL
+ };
+ char *argv[] = {
+ "/bin/sh", "-c",
+ req->request.data + strlen("exec "),
+ NULL
+ };
+
+ sub_info = call_usermodehelper_setup("/bin/sh", argv, envp, GFP_ATOMIC);
+ if (sub_info == NULL) {
+ mconsole_reply(req, "call_usermodehelper_setup failed", 1, 0);
+ return;
+ }
+ res = call_usermodehelper_stdoutpipe(sub_info, &out);
+ if (res < 0) {
+ call_usermodehelper_freeinfo(sub_info);
+ mconsole_reply(req, "call_usermodehelper_stdoutpipe failed", 1, 0);
+ return;
+ }
+
+ call_usermodehelper_setcomplete(sub_info, &done);
+
+ res = call_usermodehelper_exec(sub_info, UMH_WAIT_EXT);
+ if (res < 0) {
+ call_usermodehelper_freeinfo(sub_info);
+ mconsole_reply(req, "call_usermodehelper_exec failed", 1, 0);
+ return;
+ }
+
+ for (;;) {
+ len = out->f_op->read(out, buf, sizeof(buf), 0);
+ if (len < 0) {
+ mconsole_reply(req, "reading output failed", 1, 0);
+ break;
+ }
+ if (len == 0)
+ break;
+ mconsole_reply_len(req, buf, len, 0, 1);
+ }
+ fput(out);
+
+ wait_for_completion(&done);
+ res = call_usermodehelper_getretval(sub_info) >> 8;
+ call_usermodehelper_freeinfo(sub_info);
+
+ mconsole_reply_len(req, buf, len, res, 0);
+}
+
void mconsole_proc(struct mc_request *req)
{
char path[64];
@@ -270,6 +332,7 @@
stop - pause the UML; it will do nothing until it receives a 'go' \n\
go - continue the UML after a 'stop' \n\
log <string> - make UML enter <string> into the kernel log\n\
+ exec <string> - pass <string> to /bin/sh -c synchronously\n\
proc <file> - returns the contents of the UML's /proc/<file>\n\
stack <pid> - returns the stack of the specified pid\n\
"
--- a/arch/um/drivers/mconsole_user.c 2008-07-13 23:51:29.000000000 +0200
+++ b/arch/um/drivers/mconsole_user.c 2008-10-07 11:00:55.000000000 +0200
@@ -32,6 +32,7 @@
{ "stop", mconsole_stop, MCONSOLE_PROC },
{ "go", mconsole_go, MCONSOLE_INTR },
{ "log", mconsole_log, MCONSOLE_INTR },
+ { "exec", mconsole_exec, MCONSOLE_PROC },
{ "proc", mconsole_proc, MCONSOLE_PROC },
{ "stack", mconsole_stack, MCONSOLE_INTR },
};
--- a/arch/um/include/mconsole.h 2008-07-13 23:51:29.000000000 +0200
+++ b/arch/um/include/mconsole.h 2008-10-07 11:00:55.000000000 +0200
@@ -85,6 +85,7 @@
extern void mconsole_stop(struct mc_request *req);
extern void mconsole_go(struct mc_request *req);
extern void mconsole_log(struct mc_request *req);
+extern void mconsole_exec(struct mc_request *req);
extern void mconsole_proc(struct mc_request *req);
extern void mconsole_stack(struct mc_request *req);
--- a/kernel/kmod.c 2008-10-07 10:31:12.000000000 +0200
+++ b/kernel/kmod.c 2008-10-07 11:07:37.000000000 +0200
@@ -118,6 +118,7 @@
struct subprocess_info {
struct work_struct work;
struct completion *complete;
+ struct completion *executed;
char *path;
char **argv;
char **envp;
@@ -125,6 +126,7 @@
enum umh_wait wait;
int retval;
struct file *stdin;
+ struct file *stdout;
void (*cleanup)(char **argv, char **envp);
};
@@ -160,8 +162,26 @@
FD_SET(0, fdt->open_fds);
FD_CLR(0, fdt->close_on_exec);
spin_unlock(&f->file_lock);
-
- /* and disallow core files too */
+ }
+ if (sub_info->stdout) {
+ struct files_struct *f = current->files;
+ struct fdtable *fdt;
+
+ sys_close(1);
+ sys_close(2);
+ get_file(sub_info->stdout);
+ fd_install(1, sub_info->stdout);
+ fd_install(2, sub_info->stdout);
+ spin_lock(&f->file_lock);
+ fdt = files_fdtable(f);
+ FD_SET(1, fdt->open_fds);
+ FD_CLR(1, fdt->close_on_exec);
+ FD_SET(2, fdt->open_fds);
+ FD_CLR(2, fdt->close_on_exec);
+ spin_unlock(&f->file_lock);
+ }
+ if (sub_info->stdin || sub_info->stdout) {
+ /* disallow core files */
current->signal->rlim[RLIMIT_CORE] = (struct rlimit){0, 0};
}
@@ -243,7 +263,7 @@
/* CLONE_VFORK: wait until the usermode helper has execve'd
* successfully We need the data structures to stay around
* until that is done. */
- if (wait == UMH_WAIT_PROC || wait == UMH_NO_WAIT)
+ if (wait == UMH_WAIT_PROC || wait == UMH_NO_WAIT || wait == UMH_WAIT_EXT)
pid = kernel_thread(wait_for_helper, sub_info,
CLONE_FS | CLONE_FILES | SIGCHLD);
else
@@ -254,6 +274,16 @@
case UMH_NO_WAIT:
break;
+ case UMH_WAIT_EXT:
+ if (pid > 0) {
+ complete(sub_info->executed);
+ break;
+ }
+ sub_info->retval = pid;
+ complete(sub_info->executed);
+ complete(sub_info->complete);
+ break;
+
case UMH_WAIT_PROC:
if (pid > 0)
break;
@@ -405,6 +435,19 @@
}
EXPORT_SYMBOL(call_usermodehelper_setcleanup);
+void call_usermodehelper_setcomplete(struct subprocess_info *info,
+ struct completion* complete)
+{
+ info->complete = complete;
+}
+EXPORT_SYMBOL(call_usermodehelper_setcomplete);
+
+int call_usermodehelper_getretval(struct subprocess_info *info)
+{
+ return info->retval;
+}
+EXPORT_SYMBOL(call_usermodehelper_getretval);
+
/**
* call_usermodehelper_stdinpipe - set up a pipe to be used for stdin
* @sub_info: a subprocess_info returned by call_usermodehelper_setup
@@ -434,6 +477,29 @@
}
EXPORT_SYMBOL(call_usermodehelper_stdinpipe);
+int call_usermodehelper_stdoutpipe(struct subprocess_info *sub_info,
+ struct file **filp)
+{
+ struct file *f;
+
+ f = create_write_pipe(0);
+ if (IS_ERR(f))
+ return PTR_ERR(f);
+ sub_info->stdout = f;
+
+ f = create_read_pipe(f, 0);
+ if (IS_ERR(f)) {
+ free_write_pipe(sub_info->stdout);
+ sub_info->stdout = NULL;
+ return PTR_ERR(f);
+ }
+ *filp = f;
+
+ return 0;
+}
+EXPORT_SYMBOL(call_usermodehelper_stdoutpipe);
+
+
/**
* call_usermodehelper_exec - start a usermode application
* @sub_info: information about the subprocessa
@@ -461,15 +527,22 @@
goto out;
}
- sub_info->complete = &done;
+ if (wait == UMH_WAIT_EXT)
+ sub_info->executed = &done;
+ else
+ sub_info->complete = &done;
+
sub_info->wait = wait;
queue_work(khelper_wq, &sub_info->work);
if (wait == UMH_NO_WAIT) /* task has freed sub_info */
goto unlock;
+
wait_for_completion(&done);
- retval = sub_info->retval;
+ retval = sub_info->retval;
+ if (wait == UMH_WAIT_EXT) /* caller will free sub_info */
+ goto unlock;
out:
call_usermodehelper_freeinfo(sub_info);
unlock:
--- a/include/linux/kmod.h 2008-10-07 10:31:11.000000000 +0200
+++ b/include/linux/kmod.h 2008-10-07 11:00:55.000000000 +0200
@@ -40,6 +40,7 @@
struct key;
struct file;
struct subprocess_info;
+struct completion;
/* Allocate a subprocess_info structure */
struct subprocess_info *call_usermodehelper_setup(char *path, char **argv,
@@ -50,13 +51,20 @@
struct key *session_keyring);
int call_usermodehelper_stdinpipe(struct subprocess_info *sub_info,
struct file **filp);
+int call_usermodehelper_stdoutpipe(struct subprocess_info *sub_info,
+ struct file **filp);
+void call_usermodehelper_setcomplete(struct subprocess_info *sub_info,
+ struct completion *complete);
void call_usermodehelper_setcleanup(struct subprocess_info *info,
void (*cleanup)(char **argv, char **envp));
+int call_usermodehelper_getretval(struct subprocess_info *sub_info);
enum umh_wait {
UMH_NO_WAIT = -1, /* don't wait at all */
UMH_WAIT_EXEC = 0, /* wait for the exec, but not the process */
UMH_WAIT_PROC = 1, /* wait for the process to complete */
+ UMH_WAIT_EXT = 2, /* wait for the exec then return and signal
+ when the process is complete */
};
/* Actually execute the sub-process */
--- a/arch/um/Makefile 2008-07-13 23:51:29.000000000 +0200
+++ b/arch/um/Makefile 2008-10-07 11:00:55.000000000 +0200
@@ -77,6 +77,7 @@
KERNEL_DEFINES = $(strip -Derrno=kernel_errno -Dsigprocmask=kernel_sigprocmask \
-Dmktime=kernel_mktime $(ARCH_KERNEL_DEFINES))
KBUILD_CFLAGS += $(KERNEL_DEFINES)
+KBUILD_CFLAGS += $(call cc-option,-fno-unit-at-a-time,)
PHONY += linux
--- a/arch/um/Makefile-i386 2008-07-13 23:51:29.000000000 +0200
+++ b/arch/um/Makefile-i386 2008-10-07 11:00:55.000000000 +0200
@@ -32,11 +32,4 @@
# an unresolved reference.
cflags-y += -ffreestanding
-# Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
-# a lot more stack due to the lack of sharing of stacklots. Also, gcc
-# 4.3.0 needs -funit-at-a-time for extern inline functions.
-KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \
- echo $(call cc-option,-fno-unit-at-a-time); \
- else echo $(call cc-option,-funit-at-a-time); fi ;)
-
KBUILD_CFLAGS += $(cflags-y)
--- a/arch/um/Makefile-x86_64 2008-07-13 23:51:29.000000000 +0200
+++ b/arch/um/Makefile-x86_64 2008-10-07 11:00:55.000000000 +0200
@@ -21,6 +21,3 @@
LINK-$(CONFIG_LD_SCRIPT_DYN) += -Wl,-rpath,/lib64
LINK-y += -m64
-
-# Do unit-at-a-time unconditionally on x86_64, following the host
-KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time)
--- a/arch/um/drivers/line.c 2008-10-07 10:31:00.000000000 +0200
+++ b/arch/um/drivers/line.c 2008-10-07 11:00:55.000000000 +0200
@@ -864,6 +864,6 @@
return base;
}
- snprintf(title, len, "%s (%s)", base, umid);
+ snprintf(title, len, "%s (%s)", umid, base);
return title;
}
|