aboutsummaryrefslogtreecommitdiffstats
path: root/main/xen/xsa41c.patch
diff options
context:
space:
mode:
authorRoger Pau Monne <roger.pau@citrix.com>2013-01-18 18:07:00 +0100
committerNatanael Copa <ncopa@alpinelinux.org>2013-01-18 17:30:58 +0000
commit72b0ec467593775da3253251cecdb84f4bb10b13 (patch)
treea89257a64623365a072af5928bd8bcbb2ee514af /main/xen/xsa41c.patch
parentda422d63cf72f05137326de21e931e64108f9636 (diff)
downloadaports-72b0ec467593775da3253251cecdb84f4bb10b13.tar.bz2
aports-72b0ec467593775da3253251cecdb84f4bb10b13.tar.xz
xen: XSA-41 remaining patches
Some patches where not included in the original XSA, this are the remaining ones (so far). To be applied to edge and 2.5
Diffstat (limited to 'main/xen/xsa41c.patch')
-rw-r--r--main/xen/xsa41c.patch39
1 files changed, 39 insertions, 0 deletions
diff --git a/main/xen/xsa41c.patch b/main/xen/xsa41c.patch
new file mode 100644
index 0000000000..d346937817
--- /dev/null
+++ b/main/xen/xsa41c.patch
@@ -0,0 +1,39 @@
+From 2a1354d655d816feaad7dbdb8364f40a208439c1 Mon Sep 17 00:00:00 2001
+From: Ian Jackson <ian.jackson@eu.citrix.com>
+Date: Thu, 17 Jan 2013 15:52:16 +0000
+Subject: [PATCH] e1000: fix compile warning introduced by security fix, and debugging
+
+e33f918c19e393900b95a2bb6b10668dfe96a8f2, the fix for XSA-41,
+and its cherry picks in 4.2 and 4.1 introduced this compiler warning:
+ hw/e1000.c:641: warning: 'return' with a value, in function returning void
+
+In upstream qemu (where this change came from), e1000_receive returns
+a value used by queueing machinery to decide whether to try
+resubmitting the packet later. Returning "size" means that the packet
+has been dealt with and should not be retried.
+
+In this old branch (aka qemu-xen-traditional), this machinery is
+absent and e1000_receive returns void. Fix the return statement.
+
+Also add a debugging statement along the lines of the others in this
+function.
+
+Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
+---
+diff --git a/tools/qemu-xen-traditional/hw/e1000.c b/tools/qemu-xen-traditional/hw/e1000.c
+index 67d2651..c75bc5e 100644
+--- a/tools/qemu-xen-traditional/hw/e1000.c
++++ b/tools/qemu-xen-traditional/hw/e1000.c
+@@ -638,7 +638,8 @@ e1000_receive(void *opaque, const uint8_t *buf, int size)
+ (size > MAXIMUM_ETHERNET_VLAN_SIZE
+ && !(s->mac_reg[RCTL] & E1000_RCTL_LPE)))
+ && !(s->mac_reg[RCTL] & E1000_RCTL_SBP)) {
+- return size;
++ DBGOUT(RX, "packet too large for applicable LPE/VLAN size\n");
++ return;
+ }
+
+ if (!receive_filter(s, buf, size))
+--
+1.7.2.5
+