aboutsummaryrefslogtreecommitdiffstats
path: root/testing/keepalived/fix-configure.patch
blob: 14c43d8048a0955c3caa93e142153e5a1791da05 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
From 4b6ceb48080044d675bc67ac93a86513b61eea63 Mon Sep 17 00:00:00 2001
From: Jakub Jirutka <jakub@jirutka.cz>
Date: Sat, 19 Nov 2016 01:43:24 +0100
Subject: [PATCH] Fix illegal syntax in configure script

Indirect expansion (`${!foo}`) is a bashism, it's not POSIX-sh
compatible and is not supported by common shells except Bash and ZSH!
Configure script should be portable, hence strictly POSIX compliant.
Moreover it has shebang /bin/sh.

Sent to upstream: https://github.com/acassen/keepalived/pull/456
---
 configure    | 4 ++--
 configure.ac | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index bfd0acb..c6085e2 100755
--- a/configure
+++ b/configure
@@ -7087,8 +7087,8 @@ cat >>confdefs.h <<_ACEOF
 _ACEOF
 
 for flag in RTA_ENCAP RTA_EXPIRES RTA_NEWDST RTA_PREF RTA_VIA FRA_OIFNAME FRA_SUPPRESS_PREFIXLEN FRA_SUPPRESS_IFGROUP FRA_TUN_ID RTAX_CC_ALGO RTAX_QUICKACK; do
-  decl_var=ac_cv_have_decl_$flag
-  if test ${!decl_var} = yes; then
+  eval decl_var=\$ac_cv_have_decl_$flag
+  if test ${decl_var} = yes; then
     BUILD_OPTIONS="$BUILD_OPTIONS "${flag}
   fi
 done
diff --git a/configure.ac b/configure.ac
index 2496be1..15ffc40 100644
--- a/configure.ac
+++ b/configure.ac
@@ -422,8 +422,8 @@ AC_CHECK_DECLS([RTA_VIA, FRA_OIFNAME], [], [],
     #include <sys/socket.h>
     #include <linux/fib_rules.h>]])
 for flag in RTA_ENCAP RTA_EXPIRES RTA_NEWDST RTA_PREF RTA_VIA FRA_OIFNAME FRA_SUPPRESS_PREFIXLEN FRA_SUPPRESS_IFGROUP FRA_TUN_ID RTAX_CC_ALGO RTAX_QUICKACK; do
-  decl_var=ac_cv_have_decl_$flag
-  if test ${!decl_var} = yes; then
+  AS_VAR_COPY([decl_var], [ac_cv_have_decl_$flag])
+  if test ${decl_var} = yes; then
     add_build_opt[${flag}]
   fi
 done