diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2009-08-13 07:49:07 -0400 |
|---|---|---|
| committer | Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> | 2009-12-19 02:17:55 +0100 |
| commit | 38dcba96af08c05f91608017fda1b5f54b0307c3 (patch) | |
| tree | 2d0042da66645046de578e146c0dfce137a49eec | |
| parent | c3b9093409d9d7eade3ccefa6b61cac5985cb8af (diff) | |
| download | uClibc-alpine-38dcba96af08c05f91608017fda1b5f54b0307c3.tar.bz2 uClibc-alpine-38dcba96af08c05f91608017fda1b5f54b0307c3.tar.xz | |
daemon: fix up INTERNAL_SYSCALL() usage
Make sure we declare the error properly in case a port uses it, and fix the
invocation of exit(). Since clone() will be returning a pid, assume that
the value will not have the MSB set (negative) to simplify the error test a
bit more. If gcc supports it, force this function to always be heavily
optimized in a bid to avoid stack usage as much as possible.
Signed-off-by: James Coleman <james.coleman@ubicom.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
| -rw-r--r-- | libc/unistd/daemon.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/libc/unistd/daemon.c b/libc/unistd/daemon.c index 240b489f1..6f414ae68 100644 --- a/libc/unistd/daemon.c +++ b/libc/unistd/daemon.c @@ -63,12 +63,14 @@ libc_hidden_proto(fork) /* use clone() to get fork() like behavior here -- we just want to disassociate * from the controlling terminal */ -static inline pid_t _fork_parent(void) +static inline attribute_optimize("O3") +pid_t _fork_parent(void) { - register unsigned long ret = INTERNAL_SYSCALL(clone, wtf, 2, CLONE_VM, 0); - if (ret != -1 && ret != 0) + INTERNAL_SYSCALL_DECL(err); + register long ret = INTERNAL_SYSCALL(clone, err, 2, CLONE_VM, 0); + if (ret > 0) /* parent needs to die now w/out touching stack */ - INTERNAL_SYSCALL(exit, wtf, 0); + INTERNAL_SYSCALL(exit, err, 1, 0); return ret; } static inline pid_t fork_parent(void) |