diff options
author | Jeremy Kerr <jk@ozlabs.org> | 2014-04-24 11:28:31 +0800 |
---|---|---|
committer | Jeremy Kerr <jk@ozlabs.org> | 2014-04-24 11:28:31 +0800 |
commit | 9aeaf0bf275b74afe4c91cf2ec1dc79750f7aa59 (patch) | |
tree | 21d19a27acfc8a266326b0e6ffce3bb20c1dda4d /apps | |
parent | a30e76289abc47527cfa2f0c13fbce59a5411c20 (diff) | |
download | patchwork-9aeaf0bf275b74afe4c91cf2ec1dc79750f7aa59.tar.bz2 patchwork-9aeaf0bf275b74afe4c91cf2ec1dc79750f7aa59.tar.xz |
utils/Order: Fix application of ordering
We can't just re-apply orderings to the same queryset, we need to apply
all at once.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Diffstat (limited to 'apps')
-rw-r--r-- | apps/patchwork/tests/test_list.py | 78 | ||||
-rw-r--r-- | apps/patchwork/utils.py | 6 |
2 files changed, 81 insertions, 3 deletions
diff --git a/apps/patchwork/tests/test_list.py b/apps/patchwork/tests/test_list.py index 1bdb506..a795a5f 100644 --- a/apps/patchwork/tests/test_list.py +++ b/apps/patchwork/tests/test_list.py @@ -18,9 +18,14 @@ # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA import unittest +import random +import datetime +import string +import re from django.test import TestCase from django.test.client import Client from patchwork.tests.utils import defaults, create_user, find_in_context +from patchwork.models import Person, Patch from django.core.urlresolvers import reverse class EmptyPatchListTest(TestCase): @@ -36,3 +41,76 @@ class EmptyPatchListTest(TestCase): self.assertContains(response, 'No patches to display') self.assertNotContains(response, 'tbody') +class PatchOrderTest(TestCase): + + d = datetime.datetime + patchmeta = [ + ('AlCMyjOsx', 'AlxMyjOsx@nRbqkQV.wBw', d(2014,3,16,13, 4,50, 155643)), + ('MMZnrcDjT', 'MMmnrcDjT@qGaIfOl.tbk', d(2014,1,25,13, 4,50, 162814)), + ('WGirwRXgK', 'WGSrwRXgK@TriIETY.GhE', d(2014,2,14,13, 4,50, 169305)), + ('isjNIuiAc', 'issNIuiAc@OsEirYx.EJh', d(2014,3,15,13, 4,50, 176264)), + ('XkAQpYGws', 'XkFQpYGws@hzntTcm.JSE', d(2014,1,18,13, 4,50, 182493)), + ('uJuCPWMvi', 'uJACPWMvi@AVRBOBl.ecy', d(2014,3,12,13, 4,50, 189554)), + ('TyQmWtcbg', 'TylmWtcbg@DzrNeNH.JuB', d(2014,2, 3,13, 4,50, 195685)), + ('FpvAhWRdX', 'FpKAhWRdX@agxnCAI.wFO', d(2014,3,15,13, 4,50, 201398)), + ('bmoYvnyWa', 'bmdYvnyWa@aeoPnlX.juy', d(2014,3, 4,13, 4,50, 206800)), + ('CiReUQsAq', 'CiieUQsAq@DnOYRuf.TTI', d(2014,3,28,13, 4,50, 212169)), + ] + + def setUp(self): + defaults.project.save() + + for (name, email, date) in self.patchmeta: + patch_name = 'testpatch' + name + person = Person(name = name, email = email) + person.save() + patch = Patch(project = defaults.project, msgid = patch_name, + submitter = person, content = '', date = date) + patch.save() + + def _extract_patch_ids(self, response): + id_re = re.compile('<tr id="patch_row:(\d+)" ') + ids = [ int(m.group(1)) for m in id_re.finditer(response.content) ] + return ids + + def _test_sequence(self, response, test_fn): + ids = self._extract_patch_ids(response) + self.assertTrue(bool(ids)) + patches = [ Patch.objects.get(id = i) for i in ids ] + pairs = zip(patches, patches[1:]) + [ test_fn(p1, p2) for (p1, p2) in pairs ] + + def testDateOrder(self): + url = reverse('patchwork.views.patch.list', + kwargs={'project_id': defaults.project.linkname}) + response = self.client.get(url + '?order=date') + def test_fn(p1, p2): + self.assertLessEqual(p1.date, p2.date) + self._test_sequence(response, test_fn) + + def testDateReverseOrder(self): + url = reverse('patchwork.views.patch.list', + kwargs={'project_id': defaults.project.linkname}) + response = self.client.get(url + '?order=-date') + def test_fn(p1, p2): + self.assertGreaterEqual(p1.date, p2.date) + self._test_sequence(response, test_fn) + + def testSubmitterOrder(self): + url = reverse('patchwork.views.patch.list', + kwargs={'project_id': defaults.project.linkname}) + response = self.client.get(url + '?order=submitter') + def test_fn(p1, p2): + self.assertLessEqual(p1.submitter.name.lower(), + p2.submitter.name.lower()) + self._test_sequence(response, test_fn) + + def testSubmitterReverseOrder(self): + url = reverse('patchwork.views.patch.list', + kwargs={'project_id': defaults.project.linkname}) + response = self.client.get(url + '?order=-submitter') + def test_fn(p1, p2): + self.assertGreaterEqual(p1.submitter.name.lower(), + p2.submitter.name.lower()) + self._test_sequence(response, test_fn) + diff --git a/apps/patchwork/utils.py b/apps/patchwork/utils.py index 7e3346e..9ed9e41 100644 --- a/apps/patchwork/utils.py +++ b/apps/patchwork/utils.py @@ -99,7 +99,7 @@ class Order(object): if self.reversed: q = '-' + q - qs = qs.order_by(q) + orders = [q] # if we're using a non-default order, add the default as a secondary # ordering. We reverse the default if the primary is reversed. @@ -108,9 +108,9 @@ class Order(object): q = self.order_map[default_name] if self.reversed ^ default_reverse: q = '-' + q - qs = qs.order_by(q) + orders.append(q) - return qs + return qs.order_by(*orders) bundle_actions = ['create', 'add', 'remove'] def set_bundle(user, project, action, data, patches, context): |