diff options
| author | gdt <gdt> | 2004-12-09 14:48:12 +0000 |
|---|---|---|
| committer | gdt <gdt> | 2004-12-09 14:48:12 +0000 |
| commit | 29804943c36cee0111c89fc1fb8d50aa2c698e11 (patch) | |
| tree | dbeead183f957ad71723bc9a1c0aae3236bf3fc5 | |
| parent | c363d62b25c09b19b15e86beb5552ca87ed1abeb (diff) | |
| download | quagga-29804943c36cee0111c89fc1fb8d50aa2c698e11.tar.bz2 quagga-29804943c36cee0111c89fc1fb8d50aa2c698e11.tar.xz | |
Add const to char * to quiet warnings.
Note two warnings in comments. The serious one is that struct
interface->ifindex probably needs to be signed, ssince we store and
compare to -1.
| -rw-r--r-- | zebra/ChangeLog | 4 | ||||
| -rw-r--r-- | zebra/kernel_socket.c | 7 |
2 files changed, 10 insertions, 1 deletions
diff --git a/zebra/ChangeLog b/zebra/ChangeLog index 696676bc..8d09f502 100644 --- a/zebra/ChangeLog +++ b/zebra/ChangeLog @@ -1,3 +1,7 @@ +2004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com> + + * kernel_socket.c (rtmsg_debug): char * => const char * + 2004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * *.c: Change level of debug messages to LOG_DEBUG. diff --git a/zebra/kernel_socket.c b/zebra/kernel_socket.c index e0f2a8f2..9027cd6a 100644 --- a/zebra/kernel_socket.c +++ b/zebra/kernel_socket.c @@ -276,6 +276,7 @@ ifm_read (struct if_msghdr *ifm) sdl = (struct sockaddr_dl *)cp; break; } + /* XXX warning: pointer of type `void *' used in arithmetic */ cp += SAROUNDUP(cp); } } @@ -324,6 +325,10 @@ ifm_read (struct if_msghdr *ifm) * If ifp does not exist or has an invalid index (-1), create or * fill in an interface. */ + /* + * XXX warning: comparison between signed and unsigned + * ifindex should probably be signed + */ if ((ifp == NULL) || (ifp->ifindex == -1)) { /* @@ -812,7 +817,7 @@ rtm_write (int message, static void rtmsg_debug (struct rt_msghdr *rtm) { - char *type = "Unknown"; + const char *type = "Unknown"; struct message *mes; for (mes = rtm_type_str; mes->str; mes++) |