diff options
| author | David Lamparter <equinox@opensourcerouting.org> | 2014-06-04 01:00:51 +0200 |
|---|---|---|
| committer | David Lamparter <equinox@opensourcerouting.org> | 2014-06-29 12:47:21 +0200 |
| commit | f80f838b2f54738937ef1281b237710132195c44 (patch) | |
| tree | e5dbb9062560ac02ad2e5baf62c8d820560c75d2 | |
| parent | 27bf90a14670283a899b96c56dd23f8413e0973e (diff) | |
| download | quagga-f80f838b2f54738937ef1281b237710132195c44.tar.bz2 quagga-f80f838b2f54738937ef1281b237710132195c44.tar.xz | |
bgpd: fix memory leak on malformed attribute
When bgp_attr_parse returns BGP_ATTR_PARSE_ERROR, it may already have
parsed and allocated some attributes before hitting that error. Free
the attr's data before returning.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
| -rw-r--r-- | bgpd/bgp_packet.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c index 80651f15..65c6cac1 100644 --- a/bgpd/bgp_packet.c +++ b/bgpd/bgp_packet.c @@ -1720,7 +1720,10 @@ bgp_update_receive (struct peer *peer, bgp_size_t size) attr_parse_ret = bgp_attr_parse (peer, &attr, attribute_len, &mp_update, &mp_withdraw); if (attr_parse_ret == BGP_ATTR_PARSE_ERROR) - return -1; + { + bgp_attr_unintern_sub (&attr); + return -1; + } } /* Logging the attribute. */ |