diff options
| author | paul <paul> | 2006-08-04 06:18:04 +0000 |
|---|---|---|
| committer | paul <paul> | 2006-08-04 06:18:04 +0000 |
| commit | 116008fe8eab1c67ab91d1851a659cc9e77d2f6d (patch) | |
| tree | 0c338fdbaa0f395a4c2337d9df0f310dfbd04c43 /zebra/irdp_packet.c | |
| parent | 88c2da7a4e865a2859a93b206be4690dda4da4a4 (diff) | |
| download | quagga-116008fe8eab1c67ab91d1851a659cc9e77d2f6d.tar.bz2 quagga-116008fe8eab1c67ab91d1851a659cc9e77d2f6d.tar.xz | |
[zebra] IRDP: Move stream_free to where its created, probably fixing a leak
2006-08-01 Paul Jakma <paul.jakma@sun.com>
* irdp_main.c: (irdp_advertisement) free the stream here, when done,
right under where it was allocated so it's blindingly obvious
it's correct. This possibly fixes a very slow leak of streams in
zebra.
* irdp_packet.c: (send_packet) don't free the stream here as
it's hard to tell if right, plus an error case seemed to
returning before free anyway.
Diffstat (limited to 'zebra/irdp_packet.c')
| -rw-r--r-- | zebra/irdp_packet.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/zebra/irdp_packet.c b/zebra/irdp_packet.c index 74c75ab2..3c5f1559 100644 --- a/zebra/irdp_packet.c +++ b/zebra/irdp_packet.c @@ -286,7 +286,7 @@ send_packet(struct interface *ifp, u_long src; int on; - if (!(ifp->flags & IFF_UP)) + if (!(ifp->flags & IFF_UP)) return; if (!p) @@ -311,7 +311,6 @@ send_packet(struct interface *ifp, /* icmp->checksum is already calculated */ ip->ip_len = sizeof(struct ip) + stream_get_endp(s); - stream_free(s); on = 1; if (setsockopt(irdp_sock, IPPROTO_IP, IP_HDRINCL, |