aboutsummaryrefslogtreecommitdiffstats
path: root/src/libcharon/sa/ikev2
diff options
context:
space:
mode:
authorTobias Brunner <tobias@strongswan.org>2016-05-12 12:22:35 +0200
committerTobias Brunner <tobias@strongswan.org>2016-06-17 18:48:01 +0200
commit94012e3f420bbd499e50ffd79613a1a611ea05b6 (patch)
tree4ca8b8a61a9521e0c67589a9bbd61dac9af83fd8 /src/libcharon/sa/ikev2
parent632ba2a21e28d80fadd14ccc1d910d8469f67979 (diff)
downloadstrongswan-94012e3f420bbd499e50ffd79613a1a611ea05b6.tar.bz2
strongswan-94012e3f420bbd499e50ffd79613a1a611ea05b6.tar.xz
child-delete: Remove unnecessary call to destroy_child_sa()
Generally, we will not find the CHILD_SA by searching for it with the outbound SPI (the initiator of the DELETE sent its inbound SPI) - and if we found a CHILD_SA it would most likely be the wrong one (one in which we used the same inbound SPI as the peer used for the one it deletes). And we don't actually want to destroy the CHILD_SA at this point as we know we already initiated a DELETE ourselves, which means that task still has a reference to it and will destroy the CHILD_SA when it receives the response from the other peer.
Diffstat (limited to 'src/libcharon/sa/ikev2')
-rw-r--r--src/libcharon/sa/ikev2/tasks/child_delete.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/libcharon/sa/ikev2/tasks/child_delete.c b/src/libcharon/sa/ikev2/tasks/child_delete.c
index 053a5c51d..52661f954 100644
--- a/src/libcharon/sa/ikev2/tasks/child_delete.c
+++ b/src/libcharon/sa/ikev2/tasks/child_delete.c
@@ -165,8 +165,6 @@ static void process_payloads(private_child_delete_t *this, message_t *message)
/* we don't send back a delete if we initiated ourself */
if (!this->initiator)
{
- this->ike_sa->destroy_child_sa(this->ike_sa,
- protocol, spi);
continue;
}
/* fall through */