diff options
| author | Tobias Brunner <tobias@strongswan.org> | 2012-06-25 16:09:00 +0200 |
|---|---|---|
| committer | Martin Willi <martin@revosec.ch> | 2012-07-16 14:53:35 +0200 |
| commit | 5025135f70e3c6f24dec4143c7de8640627d9026 (patch) | |
| tree | ab68004375a0ad04a97dba30cc9584216e03847c /src/libstrongswan/plugins/gmp/gmp_rsa_public_key.c | |
| parent | e93bb353d5b2750b3a89751a83086108e3d7c1ca (diff) | |
| download | strongswan-5025135f.tar.bz2 strongswan-5025135f.tar.xz | |
Check rng return value when generating DH secrets and primes in gmp plugin
Diffstat (limited to 'src/libstrongswan/plugins/gmp/gmp_rsa_public_key.c')
| -rw-r--r-- | src/libstrongswan/plugins/gmp/gmp_rsa_public_key.c | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/src/libstrongswan/plugins/gmp/gmp_rsa_public_key.c b/src/libstrongswan/plugins/gmp/gmp_rsa_public_key.c index 898892f5b..db7b8e49a 100644 --- a/src/libstrongswan/plugins/gmp/gmp_rsa_public_key.c +++ b/src/libstrongswan/plugins/gmp/gmp_rsa_public_key.c @@ -314,7 +314,7 @@ METHOD(public_key_t, encrypt_, bool, { chunk_t em; u_char *pos; - int padding, i; + int padding; rng_t *rng; if (scheme != ENCRYPT_RSA_PKCS1) @@ -348,16 +348,12 @@ METHOD(public_key_t, encrypt_, bool, *pos++ = 0x02; /* fill with pseudo random octets */ - rng->get_bytes(rng, padding, pos); - - /* replace zero-valued random octets */ - for (i = 0; i < padding; i++) + if (!rng_get_bytes_not_zero(rng, padding, pos, TRUE)) { - while (*pos == 0) - { - rng->get_bytes(rng, 1, pos); - } - pos++; + DBG1(DBG_LIB, "failed to allocate padding"); + chunk_clear(&em); + rng->destroy(rng); + return FALSE; } rng->destroy(rng); |