diff options
author | Tobias Brunner <tobias@strongswan.org> | 2016-05-02 15:14:40 +0200 |
---|---|---|
committer | Tobias Brunner <tobias@strongswan.org> | 2016-05-10 11:42:29 +0200 |
commit | 756cd28fb8b8ca16dca2897aef9190a4d0893794 (patch) | |
tree | e6d6f1445abc8e1809a8d71d77748dc2f4d0e4a3 /src | |
parent | 26aa9c638dff963f94cd7217cc682a44301a2198 (diff) | |
download | strongswan-756cd28fb8b8ca16dca2897aef9190a4d0893794.tar.bz2 strongswan-756cd28fb8b8ca16dca2897aef9190a4d0893794.tar.xz |
vici: Ensure we read exactly the specified amount of bytes from the socket in Python
recv() will return less bytes than specified (as that's the buffer size)
if not as many are ready to be read from the socket.
Diffstat (limited to 'src')
-rw-r--r-- | src/libcharon/plugins/vici/python/vici/protocol.py | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/src/libcharon/plugins/vici/python/vici/protocol.py b/src/libcharon/plugins/vici/python/vici/protocol.py index 855a7b2e2..4951817eb 100644 --- a/src/libcharon/plugins/vici/python/vici/protocol.py +++ b/src/libcharon/plugins/vici/python/vici/protocol.py @@ -20,15 +20,22 @@ class Transport(object): self.socket.sendall(struct.pack("!I", len(packet)) + packet) def receive(self): - raw_length = self.socket.recv(self.HEADER_LENGTH) + raw_length = self._recvall(self.HEADER_LENGTH) length, = struct.unpack("!I", raw_length) - payload = self.socket.recv(length) + payload = self._recvall(length) return payload def close(self): self.socket.shutdown(socket.SHUT_RDWR) self.socket.close() + def _recvall(self, count): + """Ensure to read count bytes from the socket""" + data = b"" + while len(data) < count: + data += self.socket.recv(count - len(data)) + return data + class Packet(object): CMD_REQUEST = 0 # Named request message |