diff options
| author | Tobias Brunner <tobias@strongswan.org> | 2009-03-12 15:12:11 +0000 |
|---|---|---|
| committer | Tobias Brunner <tobias@strongswan.org> | 2009-03-12 15:12:11 +0000 |
| commit | 9086102dfd4a9fe654af922d00bc5e5238547f21 (patch) | |
| tree | c0102ca3cc8d69ea4ec919b36a18b081a79b5f32 /src | |
| parent | 0e950903edb97300f37d9b3d7437c51a8466eaf7 (diff) | |
| download | strongswan-9086102dfd4a9fe654af922d00bc5e5238547f21.tar.bz2 strongswan-9086102dfd4a9fe654af922d00bc5e5238547f21.tar.xz | |
memleak fixed when reading smartcard secrets
Diffstat (limited to 'src')
| -rw-r--r-- | src/charon/plugins/stroke/stroke_cred.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/charon/plugins/stroke/stroke_cred.c b/src/charon/plugins/stroke/stroke_cred.c index 07e0ca768..434aec22b 100644 --- a/src/charon/plugins/stroke/stroke_cred.c +++ b/src/charon/plugins/stroke/stroke_cred.c @@ -804,7 +804,7 @@ static void load_secrets(private_stroke_cred_t *this) } else if (match("PIN", &token)) { - chunk_t sc = chunk_empty; + chunk_t sc = chunk_empty, secret = chunk_empty; char smartcard[32], keyid[22], pin[32]; private_key_t *key; u_int slot; @@ -847,13 +847,13 @@ static void load_secrets(private_stroke_cred_t *this) DBG1(DBG_CFG, "line %d: expected PIN", line_nr); goto error; } - ugh = extract_secret(&chunk, &line); + ugh = extract_secret(&secret, &line); if (ugh != NULL) { DBG1(DBG_CFG, "line %d: malformed PIN: %s", line_nr, ugh); goto error; } - snprintf(pin, sizeof(pin), "%.*s", chunk.len, chunk.ptr); + snprintf(pin, sizeof(pin), "%.*s", secret.len, secret.ptr); pin[sizeof(pin) - 1] = '\0'; /* we assume an RSA key */ @@ -867,6 +867,7 @@ static void load_secrets(private_stroke_cred_t *this) this->private->insert_last(this->private, key); } memset(pin, 0, sizeof(pin)); + chunk_clear(&secret); } else if ((match("PSK", &token) && (type = SHARED_IKE)) || (match("EAP", &token) && (type = SHARED_EAP)) || |